Commit Graph

5 Commits

Author SHA1 Message Date
zxyao
31aac9f914 refactor: unified use of FeedbackComponent for modal comfirm and drawer (#1263)
* refactor: support to use the same template for confirm and modal

* refactor: support to use the same template for drawer

* refactor: separate interface IOkCancelRef

* chore: modify EventUtil class summary

Co-authored-by: James Yeung <shunjiey@hotmail.com>
2021-04-04 15:40:54 +08:00
zxyao
ef4701b6ed refactor(module: modal): refactor the code of Modal, Confirm (#914)
* refactor(module: modal): refactor the code of Modal, Confirm and Dialog

refactor details:
- Add DialogWrapper compontent to control the logic of dialog removal from DOM
- Add the appropriate folders for Dialog, Modal, and Confirm
- Remove methods with the same logic but different names in ConfirmService
- Split Title into Title (string) and Titletemplate (renderfragment)
- Add comments to code
- Rename ConfirmDialog to Confirm
- Specification of method name in ConfirmService
- Adjust the time of throttle function for draggabe modal
- Extract the common part of ModalOptions, ConfirmOptions and DialogOptions as DialogOptionsBase

* refactor: move DefaultCloseIcon etc. static members to DialogOptionsBase

* docs(module: modal): update docs

* fix: dialog incorrect waiting

* fix: pickup missing pr/7
2020-12-26 21:39:04 +08:00
James Yeung
0ee2333857 fix(module: modal): the Title property is default to string.Empty in ModalOptions (#887) 2020-12-14 12:54:19 +08:00
zxyao
66a1169307 fix(module: modal): throw error when using ModalService if not set ModalOptions.AfterClose (#807) (#809)
* fix(module: modal): throw error when using ModalService (#807)

If ModalOptions.AfterClose is null, the exception will be thrown: delegate to an instance method cannot have null 'this'

* refactor: use automatic properties for  ModalOptions
2020-11-22 21:33:07 +08:00
zxyao
6bf817d1ea feat(module: modal): support creating Modal dialog from ModalService (#676)
* refactor: change the name of ModalRef to ConfirmRef

in order to create a Modal dialog in service mode

BREAKING CHANGE: all using of ModalRef must rename to ConfirmRef

* refactor: chang the name of ModalTemplate to ConfirmTemplate

in order to create a Modal dialog in service mode

BREAKING CHANGE: all using of ModalTemplate must rename to ConfirmTemplate

* feat(module: modal): support creating Modal dialog from ModalService

Co-authored-by: James Yeung <shunjiey@hotmail.com>
2020-10-14 15:09:11 +08:00