test/ant-design
1
0
Fork 0
mirror of https://gitee.com/ant-design/ant-design.git synced 2024-11-30 02:59:04 +08:00
Code Issues Actions 68 Packages Projects Releases Wiki Activity

fix icon miss viewBox (#14686)

Browse Source
This commit is contained in:
zombieJ 2019-02-01 23:04:41 +08:00 committed by GitHub
parent 6668c12c46
commit 0cb00e47b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
components/icon/__tests__/__snapshots__/index.test.js.snap
View File

@ -333,6 +333,20 @@ exports[`Icon should support two-tone icon 1`] = `
</i>
`;
exports[`Icon support render svg as component 1`] = `
<i
aria-label="icon: undefined"
class="anticon"
>
<svg
fill="currentColor"
height="1em"
viewBox="0 0 1024 1024"
width="1em"
/>
</i>
`;
exports[`Icon.createFromIconfontCN() should support iconfont.cn 1`] = `
<div
class="icons-list"

9
components/icon/__tests__/index.test.js
View File

@ -94,6 +94,15 @@ describe('Icon', () => {
}).not.toThrow();
});
it('support render svg as component', () => {
const renderSvg = () => (
<svg viewBox="0 0 1024 1024" width="1em" height="1em" fill="currentColor" />
);
const SvgIcon = props => <Icon component={renderSvg} {...props} />;
expect(mount(<SvgIcon />).render()).toMatchSnapshot();
});
describe('warning on conflicting theme', () => {
let errorSpy;
beforeEach(() => {

4
components/icon/index.tsx
View File

@ -121,6 +121,10 @@ const Icon: IconComponent<IconProps> = props => {
viewBox,
};
if (!viewBox) {
delete innerSvgProps.viewBox;
}
// component > children > type
if (Component) {
innerNode = <Component {...innerSvgProps}>{children}</Component>;