mirror of
https://gitee.com/iresty/apisix.git
synced 2024-12-02 03:58:02 +08:00
chore: only reviewer can mark the review resolved (#5994)
This commit is contained in:
parent
a2628a602e
commit
d3bb8f9035
3
.github/PULL_REQUEST_TEMPLATE.md
vendored
3
.github/PULL_REQUEST_TEMPLATE.md
vendored
@ -5,13 +5,14 @@
|
||||
### Pre-submission checklist:
|
||||
|
||||
<!--
|
||||
Please follow the requirements:
|
||||
Please follow the PR manners:
|
||||
1. Use Draft if the PR is not ready to be reviewed
|
||||
2. Test is required for the feat/fix PR, unless you have a good reason
|
||||
3. Doc is required for the feat PR
|
||||
4. Use a new commit to resolve review instead of `push -f`
|
||||
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
|
||||
6. Use "request review" to notify the reviewer once you have resolved the review
|
||||
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
|
||||
-->
|
||||
|
||||
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
|
||||
|
@ -48,6 +48,7 @@ Once we've discussed your changes and you've got your code ready, make sure that
|
||||
* References the original issue in the description, e.g. "Resolves #123".
|
||||
* Has a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
|
||||
* Ensure your pull request's title starts from one of the word in the `types` section of [semantic.yml](https://github.com/apache/apisix/blob/master/.github/semantic.yml).
|
||||
* Follow the [PR manners](https://raw.githubusercontent.com/apache/apisix/master/.github/PULL_REQUEST_TEMPLATE.md)
|
||||
|
||||
## Contribution Guidelines for Documentation
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user