test/arthas
1
0
Fork 0
mirror of https://gitee.com/arthas/arthas.git synced 2024-12-02 04:08:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

More user-friendly prompts when selecting pid.

Browse Source 
When users accidentally enter a non-integer, prompt instead of printing
stack trace.
This commit is contained in:
garenchan 2018-12-07 18:41:46 +08:00
parent f47596b2c2
commit 4fa7dc2560
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
boot/src/main/java/com/taobao/arthas/boot/Bootstrap.java
View File

@ -12,6 +12,7 @@ import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.logging.Level;
import java.util.InputMismatchException;
import javax.xml.parsers.ParserConfigurationException;
@ -249,7 +250,12 @@ public class Bootstrap {
int pid = bootStrap.getPid();
// select pid
if (pid < 0) {
pid = ProcessUtils.select(bootStrap.isVerbose());
try {
pid = ProcessUtils.select(bootStrap.isVerbose());
} catch (InputMismatchException e) {
System.out.println("Please input an integer to select pid.");
System.exit(1);
}
if (pid < 0) {
System.out.println("Please select an avaliable pid.");
System.exit(1);

4
boot/src/main/java/com/taobao/arthas/boot/ProcessUtils.java
View File

@ -12,6 +12,7 @@ import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Scanner;
import java.util.InputMismatchException;
import com.taobao.arthas.common.AnsiLog;
import com.taobao.arthas.common.ExecutingCommand;
@ -44,7 +45,8 @@ public class ProcessUtils {
return PID;
}
public static int select(boolean v) {
@SuppressWarnings("resource")
public static int select(boolean v) throws InputMismatchException {
Map<Integer, String> processMap = listProcessByJps(v);
if (processMap.isEmpty()) {