test/arthas
1
0
Fork 0
mirror of https://gitee.com/arthas/arthas.git synced 2024-11-30 11:17:39 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

print more detail when render object throw exception. #1740

Browse Source
This commit is contained in:
hengyunabc 2021-03-18 16:59:03 +08:00
parent e763ddcf58
commit a9784ef46d
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/main/java/com/taobao/arthas/core/util/StringUtils.java
View File

@ -12,7 +12,11 @@ import java.util.Set;
import java.util.StringTokenizer;
import java.util.TreeSet;
import com.alibaba.arthas.deps.org.slf4j.Logger;
import com.alibaba.arthas.deps.org.slf4j.LoggerFactory;
public abstract class StringUtils {
private static final Logger logger = LoggerFactory.getLogger(StringUtils.class);
private static final String AB = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
/**
@ -41,7 +45,10 @@ public abstract class StringUtils {
try {
return obj.toString();
} catch (Throwable t) {
return "ERROR DATA!!! Method toString() throw exception. obj class: " + obj.getClass() + ", exception message: " + t.getMessage();
logger.error("objectToString error, obj class: {}", obj.getClass(), t);
return "ERROR DATA!!! Method toString() throw exception. obj class: " + obj.getClass()
+ ", exception class: " + t.getClass()
+ ", exception message: " + t.getMessage();
}
}

10
core/src/main/java/com/taobao/arthas/core/view/ObjectView.java
View File

@ -1,5 +1,7 @@
package com.taobao.arthas.core.view;
import com.alibaba.arthas.deps.org.slf4j.Logger;
import com.alibaba.arthas.deps.org.slf4j.LoggerFactory;
import com.alibaba.fastjson.JSON;
import com.alibaba.fastjson.serializer.SerializerFeature;
import com.taobao.arthas.core.GlobalOptions;
@ -18,7 +20,7 @@ import static java.lang.String.format;
* Created by vlinux on 15/5/20.
*/
public class ObjectView implements View {
private static final Logger logger = LoggerFactory.getLogger(ObjectView.class);
private final static int MAX_OBJECT_LENGTH = 10 * 1024 * 1024; // 10M
private final Object object;
@ -50,7 +52,9 @@ public class ObjectView implements View {
.append(", try to specify -M size_limit in your command, check the help command for more.");
return buf.toString();
} catch (Throwable t) {
return "ERROR DATA!!! exception message: " + t.getMessage();
logger.error("ObjectView draw error, object class: {}", object.getClass(), t);
return "ERROR DATA!!! object class: " + object.getClass() + ", exception class: " + t.getClass()
+ ", exception message: " + t.getMessage();
}
}
@ -583,7 +587,7 @@ public class ObjectView implements View {
} else {
appendStringBuilder(buf, format("@%s[", className));
List<Field> fields = new ArrayList<Field>();
Class objClass = obj.getClass();
Class<?> objClass = obj.getClass();
if (GlobalOptions.printParentFields) {
// 当父类为null的时候说明到达了最上层的父类(Object类).
while (objClass != null) {