test/arthas
1
0
Fork 0
mirror of https://gitee.com/arthas/arthas.git synced 2024-12-04 05:09:54 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

better support LineBinding

Browse Source
This commit is contained in:
hengyunabc 2020-04-26 03:08:43 +08:00
parent 10575cf172
commit bbe10cb8d5
3 changed files with 43 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
bytekit/src/main/java/com/taobao/arthas/bytekit/asm/binding/Binding.java
View File

@ -313,27 +313,33 @@ public abstract class Binding {
}
}
@Documented
@Retention(RetentionPolicy.RUNTIME)
@java.lang.annotation.Target(ElementType.PARAMETER)
@BindingParserHandler(parser = LineBindingParser.class)
public static @interface Line {
boolean optional() default false;
/**
* 是否精确是在某个 LineNumberNode 上。如果为true的话，会向上找到最接近的 LineNumberNode
*
* @return
*/
boolean exact() default false;
}
public static class LineBindingParser implements BindingParser {
@Override
public Binding parse(Annotation annotation) {
return new LineBinding();
Line line = (Line) annotation;
return new LineBinding(line.exact());
}
}
@Documented
@Retention(RetentionPolicy.RUNTIME)
@java.lang.annotation.Target(ElementType.PARAMETER)

27
bytekit/src/main/java/com/taobao/arthas/bytekit/asm/binding/LineBinding.java
View File

@ -8,17 +8,38 @@ import com.alibaba.arthas.deps.org.objectweb.asm.tree.LineNumberNode;
import com.taobao.arthas.bytekit.asm.location.Location;
import com.taobao.arthas.bytekit.utils.AsmOpUtils;
/**
*
* @author hengyunabc
*
*/
public class LineBinding extends Binding {
private boolean exact;
public LineBinding(boolean exact) {
this.exact = exact;
}
@Override
public void pushOntoStack(InsnList instructions, BindingContext bindingContext) {
Location location = bindingContext.getLocation();
AbstractInsnNode insnNode = location.getInsnNode();
if (insnNode instanceof LineNumberNode) {
AsmOpUtils.push(instructions, ((LineNumberNode) insnNode).line);
if (exact) {
if (insnNode instanceof LineNumberNode) {
AsmOpUtils.push(instructions, ((LineNumberNode) insnNode).line);
} else {
throw new IllegalArgumentException("LineBinding location is not LineNumberNode, insnNode: " + insnNode);
}
} else {
throw new IllegalArgumentException("LineBinding location is not LineNumberNode, insnNode: " + insnNode);
while (insnNode != null) {
if (insnNode instanceof LineNumberNode) {
AsmOpUtils.push(instructions, ((LineNumberNode) insnNode).line);
break;
}
insnNode = insnNode.getPrevious();
}
}
}

7
bytekit/src/test/java/com/taobao/arthas/bytekit/asm/interceptor/AtInvokeTest.java
View File

@ -28,6 +28,7 @@ public class AtInvokeTest {
public int testCall(int ii) {
toBeCall(ii, 123L, "");
System.err.println("abc");
aaa("abc");
return 123;
}
@ -60,10 +61,12 @@ public class AtInvokeTest {
public static void onInvoke(
@Binding.This Object object,
@Binding.Class Object clazz
,
,
@Binding.Line int line,
@Binding.InvokeArgs Object[] args
) {
System.err.println("onInvoke: this" + object);
System.err.println("onInvoke: line: " + line);
System.err.println("onInvoke: this: " + object);
}
@AtInvoke(name = "toBeCall", inline = false, whenComplete = true)