test/arthas
1
0
Fork 0
mirror of https://gitee.com/arthas/arthas.git synced 2024-12-02 12:17:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

dump command support output directory. #419

Browse Source
This commit is contained in:
hengyunabc 2019-02-07 12:43:46 +08:00
parent 895f1cb14d
commit c18bd53ed5
2 changed files with 38 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
core/src/main/java/com/taobao/arthas/core/command/klass100/ClassDumpTransformer.java
View File

@ -24,10 +24,17 @@ class ClassDumpTransformer implements ClassFileTransformer {
private Map<Class<?>, File> dumpResult;
private File arthasLogHome;
private File directory;
public ClassDumpTransformer(Set<Class<?>> classesToEnhance) {
this(classesToEnhance, null);
}
public ClassDumpTransformer(Set<Class<?>> classesToEnhance, File directory) {
this.classesToEnhance = classesToEnhance;
this.dumpResult = new HashMap<Class<?>, File>();
this.arthasLogHome = new File(LogUtil.LOGGER_FILE).getParentFile();
this.directory = directory;
}
@Override
@ -50,7 +57,12 @@ class ClassDumpTransformer implements ClassFileTransformer {
String classDumpDir = "classdump";
// 创建类所在的包路径
File dumpDir = new File(arthasLogHome, classDumpDir);
File dumpDir = null;
if (directory != null) {
dumpDir = directory;
} else {
dumpDir = new File(arthasLogHome, classDumpDir);
}
if (!dumpDir.mkdirs() && !dumpDir.exists()) {
logger.warn("create dump directory:{} failed.", dumpDir.getAbsolutePath());
return;

28
core/src/main/java/com/taobao/arthas/core/command/klass100/DumpClassCommand.java
View File

@ -37,6 +37,7 @@ import static com.taobao.text.ui.Element.label;
@Summary("Dump class byte array from JVM")
@Description(Constants.EXAMPLE +
" dump java.lang.String\n" +
" dump -d /tmp/output java.lang.String\n" +
" dump org/apache/commons/lang/StringUtils\n" +
" dump *StringUtils\n" +
" dump -E org\\\\.apache\\\\.commons\\\\.lang\\\\.StringUtils\n" +
@ -48,6 +49,8 @@ public class DumpClassCommand extends AnnotatedCommand {
private String code = null;
private boolean isRegEx = false;
private String directory;
@Argument(index = 0, argName = "class-pattern")
@Description("Class name pattern, use either '.' or '/' as separator")
public void setClassPattern(String classPattern) {
@ -66,13 +69,27 @@ public class DumpClassCommand extends AnnotatedCommand {
isRegEx = regEx;
}
@Option(shortName = "d", longName = "directory")
@Description("Sets the destination directory for class files")
public void setDirectory(String directory) {
this.directory = directory;
}
@Override
public void process(CommandProcess process) {
RowAffect effect = new RowAffect();
Instrumentation inst = process.session().getInstrumentation();
Set<Class<?>> matchedClasses = SearchUtils.searchClass(inst, classPattern, isRegEx, code);
try {
if (directory != null) {
File dir = new File(directory);
if (dir.isFile()) {
process.write(directory + " :is not a directory, please check it\n");
return;
}
}
Instrumentation inst = process.session().getInstrumentation();
Set<Class<?>> matchedClasses = SearchUtils.searchClass(inst, classPattern, isRegEx, code);
if (matchedClasses == null || matchedClasses.isEmpty()) {
processNoMatch(process);
} else if (matchedClasses.size() > 5) {
@ -134,7 +151,12 @@ public class DumpClassCommand extends AnnotatedCommand {
}
private Map<Class<?>, File> dump(Instrumentation inst, Set<Class<?>> classes) throws UnmodifiableClassException {
ClassDumpTransformer transformer = new ClassDumpTransformer(classes);
ClassDumpTransformer transformer = null;
if (directory != null) {
transformer = new ClassDumpTransformer(classes, new File(directory));
} else {
transformer = new ClassDumpTransformer(classes);
}
Enhancer.enhance(inst, transformer, classes);
return transformer.getDumpResult();
}