test/cuba
1
0
Fork 0
mirror of https://gitee.com/jmix/cuba.git synced 2024-12-04 12:17:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Null pointer in EditorWindowDelegate #PL-1840

Browse Source
This commit is contained in:
Konstantin Krivopustov 2013-02-04 14:23:03 +00:00
parent 03ae3f9753
commit 4386d8e1f0
1 changed files with 23 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
modules/gui/src/com/haulmont/cuba/gui/components/EditorWindowDelegate.java
View File

@ -107,30 +107,32 @@ public class EditorWindowDelegate extends WindowDelegate {
Datasource ds = getDatasource();
DataSupplier dataservice = ds.getDataSupplier();
if (ds.getCommitMode().equals(Datasource.CommitMode.PARENT)
&& ds instanceof DatasourceImplementation
&& ((DatasourceImplementation) ds).getParent() instanceof DatasourceImplementation) {
DatasourceImplementation parentDs = (DatasourceImplementation) ((DatasourceImplementation) ds).getParent();
// We have to reload items in parent datasource because when item in child datasource is committed,
// an item in parent datasource must already have all item fields loaded.
if (parentDs != null) {
Collection<Object> justChangedItems = new HashSet<Object>(parentDs.getItemsToCreate());
justChangedItems.addAll(parentDs.getItemsToUpdate());
if (!PersistenceHelper.isNew(item)) {
if (ds.getCommitMode().equals(Datasource.CommitMode.PARENT)) {
if (ds instanceof DatasourceImplementation
&& ((DatasourceImplementation) ds).getParent() instanceof DatasourceImplementation) {
DatasourceImplementation parentDs =
(DatasourceImplementation) ((DatasourceImplementation) ds).getParent();
// We have to reload items in parent datasource because when item in child datasource is committed,
// an item in parent datasource must already have all item fields loaded.
if (parentDs != null) {
Collection<Object> justChangedItems = new HashSet<Object>(parentDs.getItemsToCreate());
justChangedItems.addAll(parentDs.getItemsToUpdate());
if (!justChangedItems.contains(item)
&& parentDs instanceof CollectionDatasource
&& ((CollectionDatasource) parentDs).containsItem(item)) {
item = dataservice.reload(item, ds.getView(), ds.getMetaClass());
if (parentDs instanceof CollectionPropertyDatasourceImpl) {
((CollectionPropertyDatasourceImpl) parentDs).replaceItem(item);
} else {
((CollectionDatasource) parentDs).updateItem(item);
if (!justChangedItems.contains(item)
&& parentDs instanceof CollectionDatasource
&& ((CollectionDatasource) parentDs).containsItem(item)) {
item = dataservice.reload(item, ds.getView(), ds.getMetaClass());
if (parentDs instanceof CollectionPropertyDatasourceImpl) {
((CollectionPropertyDatasourceImpl) parentDs).replaceItem(item);
} else {
((CollectionDatasource) parentDs).updateItem(item);
}
}
}
}
}
item = (Entity) InstanceUtils.copy(item);
} else {
if (!PersistenceHelper.isNew(item)) {
item = (Entity) InstanceUtils.copy(item);
} else {
boolean useSecConstraints = !WindowParams.DISABLE_SECURITY_CONSTRAINTS.getBool(window.getContext());
item = dataservice.reload(item, ds.getView(), ds.getMetaClass(), useSecConstraints);
}