test/dify
1
0
Fork 0
mirror of https://gitee.com/dify_ai/dify.git synced 2024-12-03 03:38:08 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

refactor: optimize-the-performance-of-var-reference-picker (#5918)

Browse Source
This commit is contained in:
AIxGEEK 2024-07-04 15:33:36 +08:00 committed by GitHub
parent 52e59cf4df
commit 4d9c22bfc6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
web/app/components/workflow/nodes/_base/components/variable/var-reference-picker.tsx
View File

@ -1,6 +1,6 @@
'use client'
import type { FC } from 'react'
import React, { useCallback, useEffect, useRef, useState } from 'react'
import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { useTranslation } from 'react-i18next'
import cn from 'classnames'
import {
@ -71,7 +71,9 @@ const VarReferencePicker: FC<Props> = ({
const isChatMode = useIsChatMode()
const { getTreeLeafNodes, getBeforeNodesInSameBranch } = useWorkflow()
const availableNodes = passedInAvailableNodes || (onlyLeafNodeVar ? getTreeLeafNodes(nodeId) : getBeforeNodesInSameBranch(nodeId))
const availableNodes = useMemo(() => {
return passedInAvailableNodes || (onlyLeafNodeVar ? getTreeLeafNodes(nodeId) : getBeforeNodesInSameBranch(nodeId))
}, [getBeforeNodesInSameBranch, getTreeLeafNodes, nodeId, onlyLeafNodeVar, passedInAvailableNodes])
const startNode = availableNodes.find((node: any) => {
return node.data.type === BlockEnum.Start
})
@ -91,7 +93,7 @@ const VarReferencePicker: FC<Props> = ({
const [varKindType, setVarKindType] = useState<VarKindType>(defaultVarKindType)
const isConstant = isSupportConstantValue && varKindType === VarKindType.constant
const outputVars = (() => {
const outputVars = useMemo(() => {
if (availableVars)
return availableVars
@ -104,7 +106,8 @@ const VarReferencePicker: FC<Props> = ({
})
return vars
})()
}, [iterationNode, availableNodes, isChatMode, filterVar, availableVars, t])
const [open, setOpen] = useState(false)
useEffect(() => {
onOpen()
@ -112,16 +115,16 @@ const VarReferencePicker: FC<Props> = ({
}, [open])
const hasValue = !isConstant && value.length > 0
const isIterationVar = (() => {
const isIterationVar = useMemo(() => {
if (!isInIteration)
return false
if (value[0] === node?.parentId && ['item', 'index'].includes(value[1]))
return true
return false
})()
}, [isInIteration, value, node])
const outputVarNodeId = hasValue ? value[0] : ''
const outputVarNode = (() => {
const outputVarNode = useMemo(() => {
if (!hasValue || isConstant)
return null
@ -132,16 +135,16 @@ const VarReferencePicker: FC<Props> = ({
return startNode?.data
return getNodeInfoById(availableNodes, outputVarNodeId)?.data
})()
}, [value, hasValue, isConstant, isIterationVar, iterationNode, availableNodes, outputVarNodeId, startNode])
const varName = (() => {
const varName = useMemo(() => {
if (hasValue) {
const isSystem = isSystemVar(value as ValueSelector)
const varName = value.length >= 3 ? (value as ValueSelector).slice(-2).join('.') : value[value.length - 1]
return `${isSystem ? 'sys.' : ''}${varName}`
}
return ''
})()
}, [hasValue, value])
const varKindTypes = [
{