Fix CMAKE issues mentioned in #2144 and a linking problem which manifest with gcc12.3 when building with shared libs (#2208) (#2213)
Some checks failed
Build & Test / windows/msvc - ${{ matrix.link }} (SHARED) (push) Has been cancelled
Build & Test / windows/msvc - ${{ matrix.link }} (STATIC) (push) Has been cancelled
Build & Test / macos (12) (push) Has been cancelled
Build & Test / macos (13) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:11], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:11], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:12], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:12], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:13], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:13], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:14], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:14], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:15], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:15], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:16], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:16], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:17], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:clang++ ver:17], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ feature:coroutines ver:13], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:10], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:10], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:11], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:11], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:12], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:12], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:13], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:13], STATIC) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:9], SHARED) (push) Has been cancelled
Build & Test / ubuntu (map[cxx:g++ ver:9], STATIC) (push) Has been cancelled
CodeQL / Analyze (cpp) (push) Has been cancelled
codespell / codespell (push) Has been cancelled
C++ / format (push) Has been cancelled
C++ / cpplint (push) Has been cancelled

* Respect find_package QUIET

* Add policy_max to cmake_minimum_required
Avoid deprecation warning introduced by cmake 3.31

* Add missing DROGON_EXPORT
This commit is contained in:
Eyal Niv 2024-11-26 07:53:09 -07:00 committed by GitHub
parent 71b6d57cae
commit 1765223755
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 6 additions and 4 deletions

View File

@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.5)
cmake_minimum_required(VERSION 3.5...3.31)
project(drogon)

View File

@ -17,7 +17,7 @@
# ParseAndAddDrogonTests(${PROJECT_NAME}) #
#==================================================================================================#
cmake_minimum_required(VERSION 3.5)
cmake_minimum_required(VERSION 3.5...3.31)
# This removes the contents between
# - block comments (i.e. /* ... */)

View File

@ -51,7 +51,9 @@ if(Jsoncpp_FOUND)
COMMAND awk "{ printf \$3 }"
COMMAND sed -e "s/\"//g"
OUTPUT_VARIABLE jsoncpp_ver)
if(NOT Jsoncpp_FIND_QUIETLY)
message(STATUS "jsoncpp version:" ${jsoncpp_ver})
endif()
if(jsoncpp_ver LESS 1.7)
message(
FATAL_ERROR

View File

@ -88,7 +88,7 @@ class StreamError final : public std::exception
* An interface for stream request reading.
* User should create an implementation class, or use built-in handlers
*/
class RequestStreamReader
class DROGON_EXPORT RequestStreamReader
{
public:
virtual ~RequestStreamReader() = default;