fix(select): fix filter method is not called when input first letter (#1711)

* fix(select): fix filter method is not called when input first letter

* chore(select): remove empty line

* test(select): add test case
This commit is contained in:
inottn 2021-04-06 16:21:40 +08:00 committed by GitHub
parent c81d8a30e8
commit a35b7b5d1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 78 additions and 6 deletions

View File

@ -986,4 +986,77 @@ describe('Select', () => {
await vm.$nextTick()
expect(innerInputEl.placeholder).toBe(placeholder)
})
describe('after search', () => {
async function testAfterSearch({ multiple, filterMethod, remote, remoteMethod }) {
const wrapper = _mount(`
<el-select
v-model="modelValue"
filterable
:multiple="multiple"
:filter-method="filterMethod"
:remote="remote"
:remote-method="remoteMethod"
>
<el-option
v-for="option in options"
:key="option.value"
:value="option.value"
:label="option.label"
>
</el-option>
</el-select>`, () => ({
modelValue: multiple ? [1] : 1,
options: [
{ label: 'Test 1', value: 1 },
{ label: 'Test 2', value: 2 },
{ label: 'Test 3', value: 3 },
{ label: 'Test 4', value: 4 },
],
multiple,
filterMethod,
remote,
remoteMethod,
}))
const method = remote ? remoteMethod : filterMethod
const firstInputLetter = 'a'
const secondInputLetter = 'aa'
const vm = wrapper.vm as any
await vm.$nextTick()
const input = wrapper.find(multiple ? '.el-select__input' : '.el-input__inner')
const inputEl = input.element as HTMLInputElement
await input.trigger('click')
inputEl.value = firstInputLetter
await input.trigger('input')
expect(method).toBeCalled()
expect(method.mock.calls[0][0]).toBe(firstInputLetter)
inputEl.value = secondInputLetter
await input.trigger('input')
expect(method).toBeCalledTimes(2)
expect(method.mock.calls[1][0]).toBe(secondInputLetter)
}
test('should call filter method', async () => {
const filterMethod = jest.fn()
await testAfterSearch({ filterMethod })
})
test('should call filter method in multiple mode', async () => {
const filterMethod = jest.fn()
await testAfterSearch({ multiple: true, filterMethod })
})
test('should call remote method', async () => {
const remoteMethod = jest.fn()
await testAfterSearch({ remote: true, remoteMethod })
})
test('should call remote method in multiple mode', async () => {
const remoteMethod = jest.fn()
await testAfterSearch({ multiple: true, remote: true, remoteMethod })
})
})
})

View File

@ -207,14 +207,13 @@ export const useSelect = (props, states: States, ctx) => {
states.currentPlaceholder = states.selectedLabel
states.selectedLabel = ''
}
}
if (!props.multiple && !props.remote) {
if (!props.remote) {
states.selectEmitter.emit('elOptionQueryChange', '')
states.selectEmitter.emit('elOptionGroupQueryChange')
} else {
handleQueryChange(states.query)
}
}
handleQueryChange(states.query)
}
}
ctx.emit('visible-change', val)
})