test/hyperf
1
0
Fork 0
mirror of https://gitee.com/hyperf/hyperf.git synced 2024-11-30 02:37:58 +08:00
Code Issues Actions 16 Packages Projects Releases Wiki Activity

Optimized code for socketio decode. (#6462)

Browse Source
This commit is contained in:
pandaLIU 2024-01-13 08:44:06 +08:00 committed by GitHub
parent 04f465aa94
commit d9377392c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
src/socketio-server/src/Parser/Decoder.php
View File

@ -46,41 +46,30 @@ class Decoder
if ($currentIndex + 1 === $payloadLength) {
goto _out;
}
if ($payload[$currentIndex + 1] === '/') {
$start = $currentIndex + 1;
while (++$currentIndex) {
if ($currentIndex === $payloadLength) {
break;
}
$char = $payload[$currentIndex];
if ($char === ',') {
break;
}
$nspStart = $currentIndex + 1;
$nspEnd = strpos($payload, ',');
$queryStart = strpos($payload, '?');
$currentIndex = $nspEnd !== false ? $nspEnd : $payloadLength;
if ($queryStart !== false) {
$queryLength = $nspEnd === false ? $currentIndex - $queryStart : $currentIndex - $queryStart - 1;
$queryStr = substr($payload, $queryStart + 1, $queryLength);
$nsp = substr($payload, $nspStart, $queryStart - $nspStart);
parse_str($queryStr, $query);
} else {
$nsp = substr($payload, $nspStart, $currentIndex - $nspStart);
}
$nspStart = $start;
$nspEnd = $currentIndex;
$queryStart = $nspStart;
// look up query in namespace (e.g. "1/ws?foo=bar&baz=1,")
while (++$queryStart) {
if ($queryStart === $currentIndex) {
break;
}
$char = $payload[$queryStart];
if ($char === '?') {
$queryLength = $nspEnd - $queryStart;
$queryStr = substr($payload, $queryStart + 1, $queryLength - 1);
parse_str($queryStr, $query);
$nspEnd = $queryStart;
break;
}
}
$nsp = substr($payload, $nspStart, $nspEnd - $nspStart);
}
// look up id
if ($currentIndex === $payloadLength) {
if ($currentIndex >= $payloadLength) {
goto _out;
}
// Parser packet id
$start = $currentIndex + 1;
while (++$currentIndex) {
if ($currentIndex === $payloadLength) {

9
src/socketio-server/tests/Cases/DecoderTest.php
View File

@ -88,6 +88,15 @@ class DecoderTest extends AbstractTestCase
], $result->query);
$this->assertEquals(['event' => 'JOIN'], $result->data);
$result = $decoder->decode('42/1?foo=xxx&bar=yyy');
$this->assertEquals(2, $result->type);
$this->assertEquals('/1', $result->nsp);
$this->assertEquals('', $result->id);
$this->assertEquals([
'foo' => 'xxx',
'bar' => 'yyy',
], $result->query);
try {
$decoder->decode('42/1?2["event","hellohyperf"]');
$this->assertTrue(false);