test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-12-03 04:19:18 +08:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

Add lock for segment manager during bulk insert (#23111)

Browse Source 
/kind bug

issue: #23106

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
This commit is contained in:
Ten Thousand Leaves 2023-03-31 20:16:24 +08:00 committed by GitHub
parent 8b7c9d4ff2
commit 1596abf6e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/datacoord/segment_manager.go
View File

@ -292,11 +292,15 @@ func (s *SegmentManager) AllocSegment(ctx context.Context, collectionID UniqueID
// allocSegmentForImport allocates one segment allocation for bulk insert.
func (s *SegmentManager) allocSegmentForImport(ctx context.Context, collectionID UniqueID,
partitionID UniqueID, channelName string, requestRows int64, importTaskID int64) (*Allocation, error) {
// init allocation
allocation := getAllocation(requestRows)
_, sp := otel.Tracer(typeutil.DataCoordRole).Start(ctx, "Alloc-ImportSegment")
defer sp.End()
s.mu.Lock()
defer s.mu.Unlock()
// create new segments and add allocations to meta
// to avoid mixing up with growing segments, the segment state is "Importing"
// Init allocation.
allocation := getAllocation(requestRows)
// Create new segments and add allocations to meta.
// To avoid mixing up with growing segments, the segment state is "Importing"
expireTs, err := s.genExpireTs(ctx, true)
if err != nil {
return nil, err