From 16b4c9a79e3f6227cde93e5289f124240b970dec Mon Sep 17 00:00:00 2001 From: "cai.zhang" Date: Thu, 22 Feb 2024 20:40:53 +0800 Subject: [PATCH] fix: Skip filling segmentID in indexBuildCh to prevent flush blocked (#30747) issue: #30580 Signed-off-by: Cai Zhang --- internal/datacoord/server.go | 5 ++++- internal/datacoord/services.go | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go index 20600da9df..d27c3b1cd6 100644 --- a/internal/datacoord/server.go +++ b/internal/datacoord/server.go @@ -1044,7 +1044,10 @@ func (s *Server) postFlush(ctx context.Context, segmentID UniqueID) error { log.Error("flush segment complete failed", zap.Error(err)) return err } - s.buildIndexCh <- segmentID + select { + case s.buildIndexCh <- segmentID: + default: + } insertFileNum := 0 for _, fieldBinlog := range segment.GetBinlogs() { diff --git a/internal/datacoord/services.go b/internal/datacoord/services.go index 6058afa5ab..10b1c65beb 100644 --- a/internal/datacoord/services.go +++ b/internal/datacoord/services.go @@ -468,7 +468,6 @@ func (s *Server) SaveBinlogPaths(ctx context.Context, req *datapb.SaveBinlogPath zap.Bool("isFlush", req.GetFlushed()), zap.Bool("isDropped", req.GetDropped()), zap.Bool("isImport", req.GetImporting()), - zap.Any("startPositions", req.GetStartPositions()), zap.Any("checkpoints", req.GetCheckPoints())) // for compatibility issue , if len(channelName) not exist, skip the check