From 46409282800bf3633b622fb00df07163de6aa783 Mon Sep 17 00:00:00 2001 From: jaime Date: Tue, 24 Oct 2023 22:14:14 +0800 Subject: [PATCH] Fix initialization and backward compatibility issue for GRPC compression (#27894) Signed-off-by: jaime --- configs/milvus.yaml | 2 +- internal/distributed/datacoord/service.go | 1 + internal/distributed/datanode/service.go | 1 + internal/distributed/indexnode/service.go | 1 + internal/distributed/proxy/service.go | 1 + internal/distributed/querycoord/service.go | 1 + internal/distributed/querynode/service.go | 1 + internal/distributed/rootcoord/service.go | 1 + pkg/util/paramtable/grpc_param.go | 2 +- 9 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configs/milvus.yaml b/configs/milvus.yaml index b7f35ef76b..98430939ea 100644 --- a/configs/milvus.yaml +++ b/configs/milvus.yaml @@ -443,7 +443,7 @@ grpc: serverMaxSendSize: 536870912 serverMaxRecvSize: 536870912 client: - compressionEnabled: true + compressionEnabled: false dialTimeout: 200 keepAliveTime: 10000 keepAliveTimeout: 20000 diff --git a/internal/distributed/datacoord/service.go b/internal/distributed/datacoord/service.go index 0d798d46b6..8d2e29973c 100644 --- a/internal/distributed/datacoord/service.go +++ b/internal/distributed/datacoord/service.go @@ -42,6 +42,7 @@ import ( "github.com/milvus-io/milvus/internal/proto/internalpb" "github.com/milvus-io/milvus/internal/types" "github.com/milvus-io/milvus/internal/util/dependency" + _ "github.com/milvus-io/milvus/internal/util/grpcclient" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/tracer" "github.com/milvus-io/milvus/pkg/util" diff --git a/internal/distributed/datanode/service.go b/internal/distributed/datanode/service.go index 3d3dba2537..0a8b29c727 100644 --- a/internal/distributed/datanode/service.go +++ b/internal/distributed/datanode/service.go @@ -43,6 +43,7 @@ import ( "github.com/milvus-io/milvus/internal/types" "github.com/milvus-io/milvus/internal/util/componentutil" "github.com/milvus-io/milvus/internal/util/dependency" + _ "github.com/milvus-io/milvus/internal/util/grpcclient" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/tracer" "github.com/milvus-io/milvus/pkg/util/etcd" diff --git a/internal/distributed/indexnode/service.go b/internal/distributed/indexnode/service.go index 4b969a5dfb..10b3b8ac02 100644 --- a/internal/distributed/indexnode/service.go +++ b/internal/distributed/indexnode/service.go @@ -40,6 +40,7 @@ import ( "github.com/milvus-io/milvus/internal/proto/internalpb" "github.com/milvus-io/milvus/internal/types" "github.com/milvus-io/milvus/internal/util/dependency" + _ "github.com/milvus-io/milvus/internal/util/grpcclient" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/tracer" "github.com/milvus-io/milvus/pkg/util/etcd" diff --git a/internal/distributed/proxy/service.go b/internal/distributed/proxy/service.go index a1545fcdb7..0b0df80abd 100644 --- a/internal/distributed/proxy/service.go +++ b/internal/distributed/proxy/service.go @@ -61,6 +61,7 @@ import ( "github.com/milvus-io/milvus/internal/types" "github.com/milvus-io/milvus/internal/util/componentutil" "github.com/milvus-io/milvus/internal/util/dependency" + _ "github.com/milvus-io/milvus/internal/util/grpcclient" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/tracer" "github.com/milvus-io/milvus/pkg/util" diff --git a/internal/distributed/querycoord/service.go b/internal/distributed/querycoord/service.go index 4281358f12..80716c1bd0 100644 --- a/internal/distributed/querycoord/service.go +++ b/internal/distributed/querycoord/service.go @@ -43,6 +43,7 @@ import ( "github.com/milvus-io/milvus/internal/types" "github.com/milvus-io/milvus/internal/util/componentutil" "github.com/milvus-io/milvus/internal/util/dependency" + _ "github.com/milvus-io/milvus/internal/util/grpcclient" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/tracer" "github.com/milvus-io/milvus/pkg/util" diff --git a/internal/distributed/querynode/service.go b/internal/distributed/querynode/service.go index 0233b3a98b..a94c68d221 100644 --- a/internal/distributed/querynode/service.go +++ b/internal/distributed/querynode/service.go @@ -40,6 +40,7 @@ import ( qn "github.com/milvus-io/milvus/internal/querynodev2" "github.com/milvus-io/milvus/internal/types" "github.com/milvus-io/milvus/internal/util/dependency" + _ "github.com/milvus-io/milvus/internal/util/grpcclient" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/tracer" "github.com/milvus-io/milvus/pkg/util/etcd" diff --git a/internal/distributed/rootcoord/service.go b/internal/distributed/rootcoord/service.go index e7be73f655..bb994ad4ca 100644 --- a/internal/distributed/rootcoord/service.go +++ b/internal/distributed/rootcoord/service.go @@ -43,6 +43,7 @@ import ( "github.com/milvus-io/milvus/internal/rootcoord" "github.com/milvus-io/milvus/internal/types" "github.com/milvus-io/milvus/internal/util/dependency" + _ "github.com/milvus-io/milvus/internal/util/grpcclient" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/tracer" "github.com/milvus-io/milvus/pkg/util" diff --git a/pkg/util/paramtable/grpc_param.go b/pkg/util/paramtable/grpc_param.go index 6264e4a71b..bd4a91b629 100644 --- a/pkg/util/paramtable/grpc_param.go +++ b/pkg/util/paramtable/grpc_param.go @@ -46,7 +46,7 @@ const ( DefaultMaxAttempts = 10 DefaultInitialBackoff float64 = 0.2 DefaultMaxBackoff float64 = 10 - DefaultCompressionEnabled bool = true + DefaultCompressionEnabled bool = false ProxyInternalPort = 19529 ProxyExternalPort = 19530