mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-02 20:09:57 +08:00
Rocksmq client should be closed when close a msgstream (#13865)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
This commit is contained in:
parent
f6ed8635bc
commit
4ba974d193
@ -766,6 +766,7 @@ func (ms *MqTtMsgStream) Close() {
|
||||
reader.Close()
|
||||
}
|
||||
}
|
||||
ms.client.Close()
|
||||
}
|
||||
|
||||
func (ms *MqTtMsgStream) bufMsgPackToChannel() {
|
||||
|
@ -123,5 +123,6 @@ func (pc *pulsarClient) BytesToMsgID(id []byte) (MessageID, error) {
|
||||
}
|
||||
|
||||
func (pc *pulsarClient) Close() {
|
||||
pc.client.Close()
|
||||
// FIXME(yukun): pulsar.client is a singleton, so can't invoke this close when server run
|
||||
// pc.client.Close()
|
||||
}
|
||||
|
@ -183,10 +183,5 @@ func (c *client) Close() {
|
||||
c.closeOnce.Do(func() {
|
||||
close(c.closeCh)
|
||||
c.wg.Wait()
|
||||
if c.server != nil {
|
||||
c.server.Close()
|
||||
}
|
||||
// Wait all consume goroutines exit
|
||||
c.consumerOptions = nil
|
||||
})
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user