test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-11-30 02:48:45 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Change Assert() to AssertInfo() to return error messages (#7843)

Browse Source 
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
This commit is contained in:
yukun 2021-09-14 10:06:40 +08:00 committed by GitHub
parent f1366b9451
commit 5c997710ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/core/src/index/unittest/test_ivf_cpu_nm.cpp
View File

@ -127,7 +127,6 @@ TEST_P(IVFNMCPUTest, ivf_basic_cpu) {
#ifdef MILVUS_GPU_VERSION
milvus::knowhere::FaissGpuResourceMgr::GetInstance().Dump();
#endif
}
TEST_P(IVFNMCPUTest, ivf_slice) {

10
internal/core/src/segcore/SegmentInterface.cpp
View File

@ -19,7 +19,8 @@ SegmentInternalInterface::FillTargetEntry(const query::Plan* plan, SearchResult&
std::shared_lock lck(mutex_);
AssertInfo(plan, "empty plan");
auto size = results.result_distances_.size();
Assert(results.internal_seg_offsets_.size() == size);
AssertInfo(results.internal_seg_offsets_.size() == size,
"Size of result distances is not equal to size of segment offsets");
// Assert(results.result_offsets_.size() == size);
Assert(results.row_data_.size() == 0);
@ -34,9 +35,10 @@ SegmentInternalInterface::FillTargetEntry(const query::Plan* plan, SearchResult&
bulk_subscript(SystemFieldType::RowId, results.internal_seg_offsets_.data(), size, blob.data());
} else {
auto key_offset_opt = get_schema().get_primary_key_offset();
Assert(key_offset_opt.has_value());
AssertInfo(key_offset_opt.has_value(), "Cannot get primary key offset from schema");
auto key_offset = key_offset_opt.value();
Assert(get_schema()[key_offset].get_data_type() == DataType::INT64);
AssertInfo(get_schema()[key_offset].get_data_type() == DataType::INT64,
"Primary key field is not INT64 type");
bulk_subscript(key_offset, results.internal_seg_offsets_.data(), size, blob.data());
}
blobs.emplace_back(std::move(blob));
@ -161,7 +163,7 @@ CreateDataArrayFrom(const void* data_raw, int64_t count, const FieldMeta& field_
break;
}
case DataType::VECTOR_BINARY: {
Assert(dim % 8 == 0);
AssertInfo(dim % 8 == 0, "Binary vector field dimension is not a multiple of 8");
auto num_bytes = count * dim / 8;
auto data = reinterpret_cast<const char*>(data_raw);
auto obj = vector_array->mutable_binary_vector();