From 7034260721c67d5a16ac362fdfa218f92034147c Mon Sep 17 00:00:00 2001 From: wei liu Date: Tue, 9 Jul 2024 10:00:14 +0800 Subject: [PATCH] fix: Query may return deleted records (#34502) issue: #34500 pr: #34501 cause the sort in `GetLevel0Deletions` will broken the corresponed order between pks and tss, then the pks and tss will be sorted in segment.Delete() interface. This PR remove this uncessary and incorrect sort progress to avoid query may return deleted records. Signed-off-by: Wei Liu --- internal/querynodev2/delegator/delegator_data.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/internal/querynodev2/delegator/delegator_data.go b/internal/querynodev2/delegator/delegator_data.go index b47f2c251e..f2f10884e0 100644 --- a/internal/querynodev2/delegator/delegator_data.go +++ b/internal/querynodev2/delegator/delegator_data.go @@ -21,7 +21,6 @@ import ( "fmt" "math/rand" "runtime" - "sort" "time" "github.com/cockroachdb/errors" @@ -591,10 +590,6 @@ func (sd *shardDelegator) GetLevel0Deletions(partitionID int64, candidate pkorac } } - sort.Slice(pks, func(i, j int) bool { - return tss[i] < tss[j] - }) - return pks, tss }