From 865a43095061cd43a54c4587feaefbd5532f449d Mon Sep 17 00:00:00 2001 From: XuanYang-cn Date: Wed, 22 Sep 2021 20:15:55 +0800 Subject: [PATCH] [skip-ci]Format markdown for better review (#8337) Signed-off-by: yangxuan --- CODE_REVIEW.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CODE_REVIEW.md b/CODE_REVIEW.md index 87f8a114bf..dbe7394b84 100644 --- a/CODE_REVIEW.md +++ b/CODE_REVIEW.md @@ -7,7 +7,11 @@ All PRs are checked in automatically by the sre-robot, with the following condit 4. Reviewe passed, with a "lgtm" label 5. Approver passed, with a "approved" label -Generally speaking, reviewer is volunteered and can be anyone in the community who is familiar with the packages the PR modifies. Reviewers are responsible for the logic correctness, error handling, unit test coverage and code readability. While Approver focus on overall design, code readability, and ensuring the PR follows code of conduct(Such as meaningful title and commit message, marked with correct labels, meaningful comments). Currently, all Approvers are listed under OWNERS_ALIASES file. +Generally speaking, reviewer is volunteered and can be anyone in the community who is familiar with the packages the PR modifies. +Reviewers are responsible for the logic correctness, error handling, unit test coverage and code readability. +While Approver focus on overall design, code readability, and ensuring the PR follows code of +conduct(Such as meaningful title and commit message, marked with correct labels, meaningful comments). Currently, +all Approvers are listed under OWNERS_ALIASES file. ## Things to do before review