test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-12-02 03:48:37 +08:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

[skip-ci]Format markdown for better review (#8337)

Browse Source 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
This commit is contained in:
XuanYang-cn 2021-09-22 20:15:55 +08:00 committed by GitHub
parent b6cea6539b
commit 865a430950
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CODE_REVIEW.md
View File

@ -7,7 +7,11 @@ All PRs are checked in automatically by the sre-robot, with the following condit
4. Reviewe passed, with a "lgtm" label 4. Reviewe passed, with a "lgtm" label
5. Approver passed, with a "approved" label 5. Approver passed, with a "approved" label
Generally speaking, reviewer is volunteered and can be anyone in the community who is familiar with the packages the PR modifies. Reviewers are responsible for the logic correctness, error handling, unit test coverage and code readability. While Approver focus on overall design, code readability, and ensuring the PR follows code of conduct(Such as meaningful title and commit message, marked with correct labels, meaningful comments). Currently, all Approvers are listed under OWNERS_ALIASES file. Generally speaking, reviewer is volunteered and can be anyone in the community who is familiar with the packages the PR modifies.
Reviewers are responsible for the logic correctness, error handling, unit test coverage and code readability.
While Approver focus on overall design, code readability, and ensuring the PR follows code of
conduct(Such as meaningful title and commit message, marked with correct labels, meaningful comments). Currently,
all Approvers are listed under OWNERS_ALIASES file.
## Things to do before review ## Things to do before review