test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-12-04 21:09:06 +08:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity

Use merr to prevent datanode panic (#28121)

Browse Source 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
This commit is contained in:
yihao.dai 2023-11-04 00:58:21 +08:00 committed by GitHub
parent 501cba90ce
commit 8d080383b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/datanode/channel_meta.go
View File

@ -18,7 +18,6 @@ package datanode
import ( import (
"context" "context"
"fmt"
"math" "math"
"path" "path"
"sync" "sync"
@ -201,7 +200,7 @@ func (c *ChannelMeta) getCollectionAndPartitionID(segID UniqueID) (collID, parti
if seg, ok := c.segments[segID]; ok && seg.isValid() { if seg, ok := c.segments[segID]; ok && seg.isValid() {
return seg.collectionID, seg.partitionID, nil return seg.collectionID, seg.partitionID, nil
} }
return 0, 0, fmt.Errorf("cannot find segment, id = %d", segID) return 0, 0, merr.WrapErrSegmentNotFound(segID)
} }
func (c *ChannelMeta) getChannelName() string { func (c *ChannelMeta) getChannelName() string {
@ -640,7 +639,7 @@ func (c *ChannelMeta) getSegmentStatisticsUpdates(segID UniqueID) (*commonpb.Seg
return &commonpb.SegmentStats{SegmentID: segID, NumRows: seg.numRows}, nil return &commonpb.SegmentStats{SegmentID: segID, NumRows: seg.numRows}, nil
} }
return nil, fmt.Errorf("error, there's no segment %d", segID) return nil, merr.WrapErrSegmentNotFound(segID)
} }
func (c *ChannelMeta) getCollectionID() UniqueID { func (c *ChannelMeta) getCollectionID() UniqueID {