test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-12-02 11:59:00 +08:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Fix segment released early in case of balancing (#25453)

Browse Source 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2023-07-10 18:58:28 +08:00 committed by GitHub
parent 5aad0ceec3
commit 9e3a591bda
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
internal/querynodev2/delegator/distribution.go
View File

@ -253,11 +253,9 @@ func (d *distribution) RemoveDistributions(sealedSegments []SegmentEntry, growin
d.mut.Lock()
defer d.mut.Unlock()
changed := false
for _, sealed := range sealedSegments {
if d.offlines.Contain(sealed.SegmentID) {
d.offlines.Remove(sealed.SegmentID)
changed = true
}
entry, ok := d.sealedSegments[sealed.SegmentID]
if !ok {
@ -265,7 +263,6 @@ func (d *distribution) RemoveDistributions(sealedSegments []SegmentEntry, growin
}
if entry.NodeID == sealed.NodeID || sealed.NodeID == wildcardNodeID {
delete(d.sealedSegments, sealed.SegmentID)
changed = true
}
}
@ -276,14 +273,10 @@ func (d *distribution) RemoveDistributions(sealedSegments []SegmentEntry, growin
}
delete(d.growingSegments, growing.SegmentID)
changed = true
}
if !changed {
// no change made, return closed signal channel
return getClosedCh()
}
// wait previous read even not distribution changed
// in case of segment balance caused segment lost track
return d.genSnapshot()
}