test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-11-30 10:59:32 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

fix: adding blob memory size in binlog serde (#33324)

Browse Source 
See: #33280

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
This commit is contained in:
Ted Xu 2024-05-24 10:33:40 +08:00 committed by GitHub
parent 4004e4c545
commit a8bd9bea39
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/storage/serde.go
View File

@ -925,9 +925,10 @@ func (bsw *BinlogStreamWriter) Finalize() (*Blob, error) {
return nil, err return nil, err
} }
return &Blob{ return &Blob{
Key: strconv.Itoa(int(bsw.fieldSchema.FieldID)), Key: strconv.Itoa(int(bsw.fieldSchema.FieldID)),
Value: b.Bytes(), Value: b.Bytes(),
RowNum: int64(bsw.rw.numRows), RowNum: int64(bsw.rw.numRows),
MemorySize: int64(bsw.memorySize),
}, nil }, nil
} }
@ -1016,6 +1017,7 @@ func NewBinlogSerializeWriter(schema *schemapb.CollectionSchema, partitionID, se
if !ok { if !ok {
return nil, 0, errors.New(fmt.Sprintf("serialize error on type %s", types[fid])) return nil, 0, errors.New(fmt.Sprintf("serialize error on type %s", types[fid]))
} }
writers[fid].memorySize += int(typeEntry.sizeof(e))
memorySize += typeEntry.sizeof(e) memorySize += typeEntry.sizeof(e)
} }
} }

1
internal/storage/serde_test.go
View File

@ -160,6 +160,7 @@ func TestBinlogSerializeWriter(t *testing.T) {
blob, err := w.Finalize() blob, err := w.Finalize()
assert.NoError(t, err) assert.NoError(t, err)
assert.NotNil(t, blob) assert.NotNil(t, blob)
assert.True(t, blob.MemorySize > 0)
newblobs[i] = blob newblobs[i] = blob
i++ i++
} }