From b79a4084918cfe529790faf9c23266161f91ae89 Mon Sep 17 00:00:00 2001
From: sunby <bingyi.sun@zilliz.com>
Date: Mon, 19 Apr 2021 19:28:45 +0800
Subject: [PATCH] Remove unused config item in dataservice and datanode

Signed-off-by: sunby <bingyi.sun@zilliz.com>
---
 configs/advanced/data_node.yaml                | 4 ----
 configs/advanced/data_service.yaml             | 3 ---
 internal/dataservice/param.go                  | 6 ------
 internal/distributed/dataservice/paramtable.go | 2 +-
 4 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/configs/advanced/data_node.yaml b/configs/advanced/data_node.yaml
index 9a2bdf095b..cd3642316b 100644
--- a/configs/advanced/data_node.yaml
+++ b/configs/advanced/data_node.yaml
@@ -30,10 +30,6 @@ dataNode:
       recvBufSize: 1024 # msgPack chan buffer size
       pulsarBufSize: 1024 # pulsar chan buffer size
 
-    segStatistics:
-      recvBufSize: 64
-      updateInterval: 1000 # milliseconds
-
   flush:
     # max buffer size to flush
     insertBufSize: 32000 # number of rows
diff --git a/configs/advanced/data_service.yaml b/configs/advanced/data_service.yaml
index 86f8b3324c..8e0e0ada57 100644
--- a/configs/advanced/data_service.yaml
+++ b/configs/advanced/data_service.yaml
@@ -1,11 +1,8 @@
 dataservice:
   nodeID: 14040
-  address: "127.0.0.1"
-  port: 13333
   segment:
     size: 512 # MB
     sizeFactor: 0.75
-    defaultSizePerRecord: 1024
     IDAssignExpiration: 2000 # ms
   insertChannelNum: 2
   dataNodeNum: 1
diff --git a/internal/dataservice/param.go b/internal/dataservice/param.go
index cdb7bb4a57..edb54f662d 100644
--- a/internal/dataservice/param.go
+++ b/internal/dataservice/param.go
@@ -33,7 +33,6 @@ type ParamTable struct {
 	// segment
 	SegmentSize           float64
 	SegmentSizeFactor     float64
-	DefaultRecordSize     int64
 	SegIDAssignExpiration int64
 
 	InsertChannelPrefixName     string
@@ -72,7 +71,6 @@ func (p *ParamTable) Init() {
 
 		p.initSegmentSize()
 		p.initSegmentSizeFactor()
-		p.initDefaultRecordSize()
 		p.initSegIDAssignExpiration()
 		p.initInsertChannelPrefixName()
 		p.initInsertChannelNum()
@@ -139,10 +137,6 @@ func (p *ParamTable) initSegmentSizeFactor() {
 	p.SegmentSizeFactor = p.ParseFloat("dataservice.segment.sizeFactor")
 }
 
-func (p *ParamTable) initDefaultRecordSize() {
-	p.DefaultRecordSize = p.ParseInt64("dataservice.segment.defaultSizePerRecord")
-}
-
 func (p *ParamTable) initSegIDAssignExpiration() {
 	p.SegIDAssignExpiration = p.ParseInt64("dataservice.segment.IDAssignExpiration") //ms
 }
diff --git a/internal/distributed/dataservice/paramtable.go b/internal/distributed/dataservice/paramtable.go
index ef5a1310cb..1e25de1d52 100644
--- a/internal/distributed/dataservice/paramtable.go
+++ b/internal/distributed/dataservice/paramtable.go
@@ -45,7 +45,7 @@ func (pt *ParamTable) LoadFromEnv() {
 }
 
 func (pt *ParamTable) initPort() {
-	pt.Port = pt.ParseInt("dataservice.port")
+	pt.Port = pt.ParseInt("dataService.port")
 }
 
 func (pt *ParamTable) initMasterAddress() {