test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-12-02 03:48:37 +08:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

enhance: [2.4] Prevent generate "null" search params (#37811)
Some checks are pending
Build and test / Build and test AMD64 Ubuntu 22.04 (push) Waiting to run
Details
Build and test / UT for Cpp (push) Blocked by required conditions
Details
Build and test / UT for Go (push) Blocked by required conditions
Details
Build and test / Integration Test (push) Blocked by required conditions
Details
Build and test / Upload Code Coverage (push) Blocked by required conditions
Details

Browse Source 
pr: #37812
Preventing generating null search params in restful search request

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2024-11-19 18:20:32 +08:00 committed by GitHub
parent ebfd917bb6
commit cffde80e68
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/distributed/proxy/httpserver/handler_v2.go
View File

@ -943,6 +943,9 @@ func generatePlaceholderGroup(ctx context.Context, body string, collSchema *sche
func generateSearchParams(ctx context.Context, c *gin.Context, reqSearchParams searchParams) []*commonpb.KeyValuePair {
var searchParams []*commonpb.KeyValuePair
if reqSearchParams.Params == nil {
reqSearchParams.Params = make(map[string]any)
}
bs, _ := json.Marshal(reqSearchParams.Params)
searchParams = append(searchParams, &commonpb.KeyValuePair{Key: Params, Value: string(bs)})
searchParams = append(searchParams, &commonpb.KeyValuePair{Key: common.IgnoreGrowing, Value: strconv.FormatBool(reqSearchParams.IgnoreGrowing)})