test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-11-30 02:48:45 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Enable to gen compaction plan for stale segments (#20741)

Browse Source 
See also: #20502

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
This commit is contained in:
XuanYang-cn 2022-11-22 17:33:16 +08:00 committed by GitHub
parent f76ea292d2
commit d1cb380ee0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/datacoord/compaction_trigger.go
View File

@ -476,11 +476,6 @@ func (t *compactionTrigger) generatePlans(segments []*SegmentInfo, force bool, c
// TODO, currently we lack of the measurement of data distribution, there should be another compaction help on redistributing segment based on scalar/vector field distribution // TODO, currently we lack of the measurement of data distribution, there should be another compaction help on redistributing segment based on scalar/vector field distribution
for _, segment := range segments { for _, segment := range segments {
segment := segment.ShadowClone() segment := segment.ShadowClone()
// by-pass stale segments
if !force && t.isStaleSegment(segment) {
log.Debug("generate plans skip stale segment", zap.Int64("segmentID", segment.GetID()), zap.Time("lastFlushTime", segment.lastFlushTime))
continue
}
// TODO should we trigger compaction periodically even if the segment has no obvious reason to be compacted? // TODO should we trigger compaction periodically even if the segment has no obvious reason to be compacted?
if force || t.ShouldDoSingleCompaction(segment, compactTime) { if force || t.ShouldDoSingleCompaction(segment, compactTime) {
prioritizedCandidates = append(prioritizedCandidates, segment) prioritizedCandidates = append(prioritizedCandidates, segment)

2
internal/datacoord/compaction_trigger_test.go
View File

@ -1057,7 +1057,7 @@ func Test_compactionTrigger_smallfiles(t *testing.T) {
}, },
}, },
}, },
lastFlushTime: time.Now(), lastFlushTime: time.Now().Add(-100 * time.Minute),
}, },
2: { 2: {
SegmentInfo: &datapb.SegmentInfo{ SegmentInfo: &datapb.SegmentInfo{