test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-12-02 20:09:57 +08:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Expose created time and updated time to datanode metrics (#8173)

Browse Source 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
This commit is contained in:
dragondriver 2021-09-17 21:32:47 +08:00 committed by GitHub
parent 57e46c5f2c
commit daf001f683
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/datanode/data_node.go
View File

@ -159,6 +159,7 @@ func (node *DataNode) Register() error {
log.Debug("DataNode Init",
zap.String("MsgChannelSubName", Params.MsgChannelSubName),
)
return nil
}
@ -342,6 +343,10 @@ func (node *DataNode) Start() error {
FilterThreshold = rep.GetTimestamp()
go node.BackGroundGC(node.clearSignal)
Params.CreatedTime = time.Now()
Params.UpdatedTime = time.Now()
node.UpdateStateCode(internalpb.StateCode_Healthy)
return nil
}

5
internal/datanode/metrics_info.go
View File

@ -39,8 +39,9 @@ func (node *DataNode) getSystemInfoMetrics(ctx context.Context, req *milvuspb.Ge
SystemVersion: os.Getenv(metricsinfo.GitCommitEnvKey),
DeployMode: os.Getenv(metricsinfo.DeployModeEnvKey),
},
// TODO(dragondriver): CreatedTime & UpdatedTime, easy but time-costing
Type: typeutil.DataNodeRole,
CreatedTime: Params.CreatedTime.String(),
UpdatedTime: Params.UpdatedTime.String(),
Type: typeutil.DataNodeRole,
},
SystemConfigurations: metricsinfo.DataNodeConfiguration{
FlushInsertBufferSize: Params.FlushInsertBufferSize,

4
internal/datanode/param_table.go
View File

@ -16,6 +16,7 @@ import (
"strconv"
"strings"
"sync"
"time"
"github.com/milvus-io/milvus/internal/log"
"github.com/milvus-io/milvus/internal/util/paramtable"
@ -62,6 +63,9 @@ type ParamTable struct {
MinioSecretAccessKey string
MinioUseSSL bool
MinioBucketName string
CreatedTime time.Time
UpdatedTime time.Time
}
var Params ParamTable

11
internal/datanode/param_table_test.go
View File

@ -14,6 +14,7 @@ package datanode
import (
"log"
"testing"
"time"
)
func TestParamTable_DataNode(t *testing.T) {
@ -98,4 +99,14 @@ func TestParamTable_DataNode(t *testing.T) {
name := Params.MinioBucketName
log.Println("MinioBucketName:", name)
})
t.Run("Test CreatedTime", func(t *testing.T) {
Params.CreatedTime = time.Now()
log.Println("CreatedTime: ", Params.CreatedTime)
})
t.Run("Test UpdatedTime", func(t *testing.T) {
Params.UpdatedTime = time.Now()
log.Println("UpdatedTime: ", Params.UpdatedTime)
})
}