test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-12-01 03:18:29 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Disk quota only checks healthy segments (#20574)

Browse Source 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
This commit is contained in:
bigsheeper 2022-11-14 21:03:09 +08:00 committed by GitHub
parent 69481471ec
commit e73bdbe17d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
internal/datacoord/meta.go
View File

@ -209,17 +209,23 @@ func (m *meta) GetNumRowsOfCollection(collectionID UniqueID) int64 {
return ret return ret
} }
// GetTotalBinlogSize returns the total size (bytes) of all segments in cluster. // GetTotalBinlogSize returns the total size (bytes) of healthy segments in cluster.
func (m *meta) GetTotalBinlogSize() int64 { func (m *meta) GetTotalBinlogSize() int64 {
m.RLock() m.RLock()
defer m.RUnlock() defer m.RUnlock()
var ret int64 var totalHealthySize int64
segments := m.segments.GetSegments() segments := m.segments.GetSegments()
sizes := make(map[commonpb.SegmentState]int64)
for _, segment := range segments { for _, segment := range segments {
ret += segment.getSegmentSize() if isSegmentHealthy(segment) {
totalHealthySize += segment.getSegmentSize()
}
sizes[segment.GetState()] += segment.getSegmentSize()
} }
metrics.DataCoordStoredBinlogSize.WithLabelValues().Set(float64(ret)) for state, size := range sizes {
return ret metrics.DataCoordStoredBinlogSize.WithLabelValues(state.String()).Set(float64(size))
}
return totalHealthySize
} }
// AddSegment records segment info, persisting info into kv store // AddSegment records segment info, persisting info into kv store

4
internal/metrics/datacoord_metrics.go
View File

@ -92,8 +92,8 @@ var (
Namespace: milvusNamespace, Namespace: milvusNamespace,
Subsystem: typeutil.DataCoordRole, Subsystem: typeutil.DataCoordRole,
Name: "stored_binlog_size", Name: "stored_binlog_size",
Help: "binlog size of all collections/segments", Help: "binlog size of segments",
}, []string{}) }, []string{segmentStateLabelName})
/* hard to implement, commented now /* hard to implement, commented now
DataCoordSegmentSizeRatio = prometheus.NewHistogramVec( DataCoordSegmentSizeRatio = prometheus.NewHistogramVec(