Add dimension validation.

Signed-off-by: sunby <bingyi.sun@zilliz.com>

configs/advanced/proxy.yaml

@@ -28,4 +28,5 @@ proxy:
       bufSize: 512
 
   maxNameLength: 255
-  maxFieldNum: 64
+  maxFieldNum: 64
+  maxDimension: 32768

internal/proxy/paramtable.go

@@ -480,6 +480,18 @@ func (pt *ParamTable) MaxFieldNum() int64 {
 	return maxFieldNum
 }
 
+func (pt *ParamTable) MaxDimension() int64 {
+	str, err := pt.Load("proxy.maxDimension")
+	if err != nil {
+		panic(err)
+	}
+	maxDimension, err := strconv.ParseInt(str, 10, 64)
+	if err != nil {
+		panic(err)
+	}
+	return maxDimension
+}
+
 func (pt *ParamTable) defaultPartitionTag() string {
 	tag, err := pt.Load("common.defaultPartitionTag")
 	if err != nil {

internal/proxy/task.go

@@ -181,6 +181,33 @@ func (cct *CreateCollectionTask) PreExecute() error {
 		if err := ValidateFieldName(field.Name); err != nil {
 			return err
 		}
+		if field.DataType == schemapb.DataType_VECTOR_FLOAT || field.DataType == schemapb.DataType_VECTOR_BINARY {
+			exist := false
+			var dim int64 = 0
+			for _, param := range field.TypeParams {
+				if param.Key == "dim" {
+					exist = true
+					tmp, err := strconv.ParseInt(param.Value, 10, 64)
+					if err != nil {
+						return err
+					}
+					dim = tmp
+					break
+				}
+			}
+			if !exist {
+				return errors.New("dimension is not defined in field type params")
+			}
+			if field.DataType == schemapb.DataType_VECTOR_FLOAT {
+				if err := ValidateDimension(dim, false); err != nil {
+					return err
+				}
+			} else {
+				if err := ValidateDimension(dim, true); err != nil {
+					return err
+				}
+			}
+		}
 	}
 
 	return nil

internal/proxy/validate_util.go

@@ -116,3 +116,14 @@ func ValidateFieldName(fieldName string) error {
 	}
 	return nil
 }
+
+func ValidateDimension(dim int64, isBinary bool) error {
+	if dim <= 0 || dim > Params.MaxDimension() {
+		return errors.New("invalid dimension: " + strconv.FormatInt(dim, 10) + ". should be in range 1 ~ " +
+			strconv.FormatInt(Params.MaxDimension(), 10) + ".")
+	}
+	if isBinary && dim%8 != 0 {
+		return errors.New("invalid dimension: " + strconv.FormatInt(dim, 10) + ". should be multiple of 8.")
+	}
+	return nil
+}

internal/proxy/validate_util_test.go

@@ -82,3 +82,16 @@ func TestValidateFieldName(t *testing.T) {
 		assert.NotNil(t, ValidateFieldName(name))
 	}
 }
+
+func TestValidateDimension(t *testing.T) {
+	Params.Init()
+	assert.Nil(t, ValidateDimension(1, false))
+	assert.Nil(t, ValidateDimension(Params.MaxDimension(), false))
+	assert.Nil(t, ValidateDimension(8, true))
+	assert.Nil(t, ValidateDimension(Params.MaxDimension(), true))
+
+	// invalid dim
+	assert.NotNil(t, ValidateDimension(-1, false))
+	assert.NotNil(t, ValidateDimension(Params.MaxDimension()+1, false))
+	assert.NotNil(t, ValidateDimension(9, true))
+}