test/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2024-11-29 18:38:44 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

enhance: Reduce delegator memory overloaded factor to 0.1 (#35092)

Browse Source 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
This commit is contained in:
wei liu 2024-08-01 10:21:50 +08:00 committed by GitHub
parent dfda9f0478
commit e9d61daa3f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
configs/milvus.yaml
View File

@ -278,7 +278,7 @@ queryCoord:
rowCountMaxSteps: 50 # segment count based plan generator max steps
randomMaxSteps: 10 # segment count based plan generator max steps
growingRowCountWeight: 4 # the memory weight of growing segment row count
delegatorMemoryOverloadFactor: 0.3 # the factor of delegator overloaded memory
delegatorMemoryOverloadFactor: 0.1 # the factor of delegator overloaded memory
balanceCostThreshold: 0.001 # the threshold of balance cost, if the difference of cluster's cost after executing the balance plan is less than this value, the plan will not be executed
checkSegmentInterval: 1000
checkChannelInterval: 1000

3
internal/querycoordv2/balance/channel_level_score_balancer_test.go
View File

@ -337,6 +337,9 @@ func (suite *ChannelLevelScoreBalancerTestSuite) TestAssignSegmentWithGrowing()
{SegmentInfo: &datapb.SegmentInfo{ID: 4, NumOfRows: 10, CollectionID: 1}, Node: 3},
}
paramtable.Get().Save(paramtable.Get().QueryCoordCfg.DelegatorMemoryOverloadFactor.Key, "0.3")
defer paramtable.Get().Reset(paramtable.Get().QueryCoordCfg.DelegatorMemoryOverloadFactor.Key)
// mock 50 growing row count in node 1, which is delegator, expect all segment assign to node 2
leaderView := &meta.LeaderView{
ID: 1,

2
pkg/util/paramtable/component_param.go
View File

@ -1874,7 +1874,7 @@ func (p *queryCoordConfig) init(base *BaseTable) {
p.DelegatorMemoryOverloadFactor = ParamItem{
Key: "queryCoord.delegatorMemoryOverloadFactor",
Version: "2.3.19",
DefaultValue: "0.3",
DefaultValue: "0.1",
PanicIfEmpty: true,
Doc: "the factor of delegator overloaded memory",
Export: true,

2
pkg/util/paramtable/component_param_test.go
View File

@ -340,7 +340,7 @@ func TestComponentParam(t *testing.T) {
assert.Equal(t, 200, Params.CheckExecutedFlagInterval.GetAsInt())
params.Reset("queryCoord.checkExecutedFlagInterval")
assert.Equal(t, 0.3, Params.DelegatorMemoryOverloadFactor.GetAsFloat())
assert.Equal(t, 0.1, Params.DelegatorMemoryOverloadFactor.GetAsFloat())
assert.Equal(t, 5, Params.CollectionBalanceSegmentBatchSize.GetAsInt())
})