Commit Graph

138 Commits

Author SHA1 Message Date
jaime
832b771dcd
[skip ci] Add comments for Task interface (#12420)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Co-authored-by: yun.zhang <yun.zhang@zilliz.com>
2021-11-29 23:57:45 +08:00
dragondriver
b6d0150dc5
Fix health check when disconnect to etcd (#12292)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-26 11:39:16 +08:00
dragondriver
6c4c0ef6b5
Add more deploy metrics (#12248)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-24 15:43:15 +08:00
congqixia
4121e31df1
Send SIGINT to runner goroutine after etcd disconnects (#12163)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-22 16:23:17 +08:00
dragondriver
ee0f753f7a
Fix datarace between GetComponentStates and Register (#11935)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-19 13:57:12 +08:00
congqixia
5edbb82610
Add session revoke (#11908)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-16 22:31:14 +08:00
Xiangyu Wang
12f50cb22c
[skip ci]Update OWNERS files (#11898)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-16 15:41:11 +08:00
Xiaofan
5f08b67156
Move node.yaml to component.yaml (#11363)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-11-10 14:27:37 +08:00
XuanYang-cn
35e8779bd9
Rename IndexRootPath to IndexStorageRootPath (#11236)
IndexRootPath is index file's blob storage prefix.
But the name is confusing with the MetaRootPath, which is prefix of etcd.

This PR changes the IndexRootPath to IndexStorageRootPath to
elimilate the confusion.

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-05 11:45:00 +08:00
cai.zhang
5e077fd261
Fix bug for indexnode load balancing (#10994)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-11-01 17:16:05 +08:00
Xiaofan
2df2d488e1
Fix Unit test fatal fail (#10933)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-30 10:24:38 +08:00
cai.zhang
e5f159ddd6
IndexNode finished the task before IndexCoord changes the meta (#10821)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-28 18:20:27 +08:00
Xiaofan
6fddcb3925
Fix Session checker for proxy (#10737)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-27 21:58:33 +08:00
XuanYang-cn
a030c2a81b
[skip ci]Update license for ic node (#10758)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-27 19:00:48 +08:00
XuanYang-cn
46add09692
[skip ci]Update license for ic meta (#10757)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-27 18:04:47 +08:00
XuanYang-cn
92185a7465
[skip ci]Update license for ic ic (#10756)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-27 18:02:56 +08:00
XuanYang-cn
4c46948a7d
[skip ci]Update license for ic task (#10759)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-27 17:44:48 +08:00
cai.zhang
e18debb3cf
Fix the bug of indexcoord meta returns the underlying pointer (#10504)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-24 13:29:10 +08:00
congqixia
6b8ff60de3
Close event channel when watch event found error (#9819)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-14 19:20:35 +08:00
congqixia
ec6e8e4127
Hide liveChn into sessionutil and fix liveness init order (#9860)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-14 16:40:35 +08:00
dragondriver
72d3d470ba
Use the server id as identifier in system topology graph (#9825)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-10-14 11:12:38 +08:00
Xiaofan
91641b75d3
Refine index coord logs (#9492)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-09 19:49:53 +08:00
cai.zhang
c49122457d
[skip ci]Fix golint for IndexAddTask in indexcoord.go (#9557)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-09 18:15:19 +08:00
cai.zhang
efd17aad74
Fix golint for BaseTask in indexcoord.go (#9550)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-09 18:13:30 +08:00
cai.zhang
8e93dcbe79
[skip ci]Add comment for initMinioBucketName in indexcoord/param_table.go (#9373)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-07 02:10:13 +08:00
cai.zhang
d9dcb3cfe9
[skip ci]Fix golint in indexcoord/prama_table.go (#9371)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-07 02:08:22 +08:00
cai.zhang
c792e534db
[skip ci]Fix golint in indexcoord/prama_table.go (#9369)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-07 02:06:40 +08:00
cai.zhang
7b54242194
[skip ci]Fix golint in indexcoord/prama_table.go (#9368)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-07 02:04:43 +08:00
cai.zhang
85f5e07943
[skip ci]Add comment for initIndexRootPath in indexcoord/param_table.go (#9372)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-07 02:00:26 +08:00
cai.zhang
3f116c9aed
[skip ci]Fix golint in indexcoord/prama_table.go (#9370)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-06 23:56:03 +08:00
cai.zhang
744fc8d078
[skip ci]Fix golint in indexcoord/prama_table.go (#9301)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-06 22:08:02 +08:00
cai.zhang
33e73f3648
[skip ci]Fix golint in indexcoord/prama_table.go (#9300)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-06 22:06:13 +08:00
congqixia
9b65aad4cf
Add IndexCoord implementation Assertion (#9203)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-04 17:26:38 +08:00
cai.zhang
1f231853ae
[skip ci] Fix golint in indexcoord/priority_queue.go (#9116)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-03 10:13:55 +08:00
zhenshan.cao
cf93fadabc
[skip ci] Fix golint error in indexcoord (#9041)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-01 23:34:20 +08:00
Xiaofan
2c2b800ff4
Change Log Name with NodeId (#8721)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-01 08:52:50 +08:00
cai.zhang
0b6f792a69
[skip ci] Fix golint in indexcoord/priority_queue.go (#8848)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-30 11:06:04 +08:00
cai.zhang
246f45322a
[skip ci] Fix golint in indexcoord/param_table.go (#8875)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-29 23:36:19 +08:00
cai.zhang
83d6339188
[skip ci] Fix golint in indexcoord/task_scheduler.go (#8872)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-29 23:34:26 +08:00
zhenshan.cao
d1d5f9e409
Replace proto.MarshalTextString with proto.Marshal (#8542)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-29 20:26:00 +08:00
cai.zhang
5681042f1d
[skip ci] Fix golint in index_coord_mock.go (#8786)
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2021-09-28 22:00:29 +08:00
cai.zhang
eab7027a60
[skip ci] Fix golint in index_coord.go (#8785)
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2021-09-28 21:58:33 +08:00
cai.zhang
ed4d912b5b
Add minio root path for indexcoord (#8673)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-27 23:54:03 +08:00
Xiaofan
55f8baa6cc
[skip ci]Remove unnecessary log in index (#8630)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-26 22:03:58 +08:00
cai.zhang
9e37881b29
Standard indexcoord log printing (#8588)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-26 21:23:57 +08:00
Xiaofan
d38adda8c2
Rename log file based on node id (#8517)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-26 21:18:11 +08:00
cai.zhang
ea1e2dd63f
Add comment for indexcoord nodemanager (#8603)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-26 18:55:58 +08:00
dragondriver
0d41efe154
Expose created time and updated time to indexcoord metrics (#8591)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-26 17:54:06 +08:00
groot
e4e762f2e8
Reduce go unittest time cost (#8503)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-26 12:50:24 +08:00
cai.zhang
bd48f6f2db
Add comment for metaTable of indexcoord (#8411)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-23 21:37:55 +08:00
congqixia
da6d93527d
Add session liveness check (#8408)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-23 18:29:55 +08:00
Xiaofan
f5173b595f
Add a channel prefix for all channels (#8166)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-23 10:53:53 +08:00
cai.zhang
41a6f9b5f7
Init once for IndexCoord (#8028)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-22 19:31:54 +08:00
Xiaofan
0c35cd57b0
Unify param table to the same naming format (#8254)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-20 23:27:52 +08:00
Xiangyu Wang
c314b2b4a8
Remove unused label rules (#7929)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-18 18:19:51 +08:00
congqixia
bdfb8768d4
Enable gosec (#8202)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-18 14:45:50 +08:00
cai.zhang
57e46c5f2c
Start once for indexcoord (#8026)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-17 20:17:53 +08:00
cai.zhang
fa00f1f48a
It is also correct to get the failed index status in indexcoord ut (#8059)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-16 19:56:41 +08:00
cai.zhang
4814f9cb1c
Add opentrace log for index component (#7946)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-16 10:07:48 +08:00
cai.zhang
130817d8c6
Add comment for indexcoord (#7950)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-15 22:09:50 +08:00
cai.zhang
b965767e5c
Increase code coverage rate for indexcoord (#7857)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-14 14:09:48 +08:00
cai.zhang
63a83f027f
Reduce running unit test time for indexcoord (#7779)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-14 10:41:21 +08:00
cai.zhang
be9427e8b9
Increase covd coverage for paramtable (#7583)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-10 14:14:12 +08:00
dragondriver
9b21b3b5fd
Initialize test framework of proxy (#7563)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-09 10:06:29 +08:00
cai.zhang
e1081b6783
Increase indexcoord component code coverage (#7558)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-08 14:23:59 +08:00
cai.zhang
e6e03fc93f
Add unittest for index component (#7475)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-06 17:54:41 +08:00
dragondriver
960741ee16
Support more detailed metrics information (#7472)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-03 19:35:47 +08:00
dragondriver
1db573731b
Cache the system information metrics (#7436)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-03 17:15:26 +08:00
dragondriver
3721cbfea1
Proxy metrics integrates with other coordinators (#7400)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-01 17:35:00 +08:00
Xiaofan
58b2089692
Import Embedded Etcd Kv Part 1(#7112) (#7174)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-08-24 09:45:51 +08:00
cai.zhang
171088409b
Increase the timeout for grpc connection when create index (#7163)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-19 14:32:11 +08:00
dragondriver
648d22ee40
Expose metrics of IndexCoord and IndexNodes (#7157)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-19 10:28:10 +08:00
cai.zhang
3d83e99a99
Adding indexnode should be processed asynchronously (#7141)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-17 20:26:11 +08:00
cai.zhang
c2a4bd3e9c
Lock when writing meta instead of trying to connect to indexnode (#7136)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-17 17:54:10 +08:00
cai.zhang
382fa6f274
IndexNode dose not need to wait for IndexCoord to start to comlete (#7074)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-13 18:12:08 +08:00
XuanYang-cn
6c5be83ea1
Refactor NewEtcdKV API (#7075)
This PR mainly did the following 3 things:

- Refactor NewEtcdKV API
- Add unittests for `kv/etcd/`, raise the coverage
up to 94%
- Correct some APIs from version to revision

The old NewEtcdKV() API took `clientv3.Client` as
one of the input, making everyone who using this API
had to create a new `clientv3.Client`. So there're a lot
of repeated codes everywhere.

Meanwhile, someplace didn't even check whether the
`clientv3.New()` returned error or not, and the old API
also didn't check whether the clientv3.Client was Nil.
This caused issue#6955.

Ectd's version and revision have nothing alike, they
represent different concepts, but our APIs kind of
mixed them all up. So I correct those APIs' names.

Resolves: #6955

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 11:04:09 +08:00
Xiangyu Wang
5e78fd6a97
[skip ci]Update approvers (#7063)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-08-12 19:36:09 +08:00
cai.zhang
d51fec6678
Enhance log when create index failed (#6871)
* Enhance log when create index failed

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug for repeatedly drop index

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-29 14:47:22 +08:00
cai.zhang
e1b52b0583
Add unittest for IndexCoord and IndexNode (#6698)
* Add unittest for IndexCoord and IndexNode

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix verifiers

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-23 10:44:12 +08:00
cai.zhang
9aa56cd7b8
Add log for IndexCoord and IndexNode (#6597)
* Add log for IndexCoord and IndexNode

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Make verifier

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Delete unused script

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-22 11:40:11 +08:00
cai.zhang
f469a315d6
Refactor the logic of assign tasks in IndexCoord (#6328)
* Refactor the logic of assign tasks in IndexCoord

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bugs

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug for unittest

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Add lock for map

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Improve code

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix unittest bug

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Reduce duriation for timetick

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Update orm version

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Reset sdk version

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Reset orm version

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Reset test ip

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug for unissued

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Rename some variables

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Use break instead of continue in select::case

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-14 14:15:55 +08:00
zhenshan.cao
6b4b71bf03
Fixbug: remove wrong check code (#6372)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-08 20:17:43 +08:00
Cai Yudong
6436f596de
add GetIndexStates (#6213)
* add GetIndexStates

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename indexservice to index_coord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-06-30 14:32:19 +08:00
godchen
3785bb6330
Change retry times (#6083)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-06-24 19:05:06 +08:00
neza2017
bf068d84ad
fix index coord (#6042)
* fix index coord

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* remove memstream from RmsFactory

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-06-24 14:36:08 +08:00
godchen
99be4c09a5
change retry (#5996)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-06-23 09:24:10 +08:00
Cai Yudong
7dbf33b788
Update component names in config files (#5989)
* rename master/indexService in .yaml

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename proxyNode to proxy in config files

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move master.yaml to root_coord.yaml, move proxy_node.yaml to proxy.yaml

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move proto/query_service.proto to proto/query_coord.proto

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move proxy_node_manager.go to proxy_manager.go

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add query_coord.pb.go

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update ci

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-06-22 19:08:03 +08:00
Cai Yudong
92e429d812
Rename IndexService to IndexCoord (#5932)
* rename package indexservice to indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename indexservice to indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix queryservice static-check

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move distributed/indexservice to distributed/indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* move internal/indexservice to internal/indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename indexservice to indexcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename MasterComponent to RootCoordComponent

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for queryservice

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for dataservice

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for datanode

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for proxynode

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord for querynode

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename master to rootcoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename IndexService to IndexCoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* rename IndexService to IndexCoord

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix rebase issue

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-06-21 17:28:03 +08:00