Commit Graph

1027 Commits

Author SHA1 Message Date
congqixia
a0614a3ff8
Use NodeIds instead of NodeID in segment info (#16912)
The NodeID field is deprecated in current design
Query Node segment detector shall read NodeIds instead of NodeID

Fix #16911

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-05-11 17:39:53 +08:00
congqixia
34833680da
Add lock before query release collection from replica (#16880)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-05-10 18:09:53 +08:00
Ten Thousand Leaves
216c45fbd6
Add tests where segments load delta logs (#16825)
issue: #16821

/kind improvements

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-05-10 17:59:52 +08:00
congqixia
c7935d1a86
Add legacySegments for load balance segments rc track (#16831)
- Add legacySegments in ShardCluster tracking old segment inUse
- Apply node id check for segment online/inUse check
- Add unit test simulating load balance case

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-05-07 18:25:52 +08:00
Xiaofan
92b6293be4
Fix QueryNode log level (#16604)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-05-07 10:27:51 +08:00
Letian Jiang
b0053b7a45
Add isShardLeader field in search/query request (#16798)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-05-06 16:55:51 +08:00
congqixia
8c004fa981
Fix replicaID is allow zero from watch channel task (#16788)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-05-05 18:11:51 +08:00
Xiaofan
337ad53613
Support config small index nprobe and nlist (#16731)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-05-05 09:49:50 +08:00
Cai Yudong
6a62ff18bf
Support easylogging config for segcore and knowhere (#16751)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-05-03 08:39:49 +08:00
bigsheeper
1a29337e6b
Print unflushed segmentIDs instead of whole SegmentInfo (#16301)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-29 19:13:47 +08:00
bigsheeper
f18b3c44ee
Print msgID instead of msg (#16268)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-29 19:11:47 +08:00
congqixia
9e09434a4b
Remove not used QueryService in querynode (#16735)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-29 18:15:48 +08:00
zhenshan.cao
97757405de
Fix bug: wrong metrics name and forget to register metrics (#16714)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-04-29 15:35:47 +08:00
yah01
415a0e5978
Fix miss segments/DmChannel when query by nodeID (#16719)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-04-29 14:11:47 +08:00
Letian Jiang
a38c84e7e7
Lock meta-replica during search/query (#16703)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-29 13:37:47 +08:00
xige-16
515d0369de
Support string type in segcore (#16546)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
Co-authored-by: dragondriver <jiquan.long@zilliz.com>

Co-authored-by: dragondriver <jiquan.long@zilliz.com>
2022-04-29 13:35:49 +08:00
jaime
68b1b82faf
Remove DataKV interface (#16692)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-04-28 21:03:47 +08:00
jaime
2205b878b1
Refine log in query_shard.go (#16693)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-04-28 17:13:48 +08:00
zhenshan.cao
0a953948af
Simplify monitoring metrics (#16687)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-04-27 23:03:47 +08:00
congqixia
3a6db2faeb
Fix handling segment change logic (#16695)
Dispatch segmentChangeInfo to ShardCluster leader
Hold segment remove before search is done

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-27 22:23:46 +08:00
Letian Jiang
2879796b42
Validate partitionIDs & segmentIDs in query request (#16684)
* check partitions if they are released or unloaded
    * check segments if their collection/partition(s) are released or unloaded

Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-27 19:23:48 +08:00
congqixia
0bf176a7e1
Add SyncReplicaSegments interface for QueryNode (#16672)
Add SyncReplicaSegments for LoadCollection/LoadPartition child task
This API notifies related ShardCluster to record segment Loaded
Preventing the Etcd events is delayed, which will cause some segment not search

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-27 10:41:46 +08:00
Xiaofan
b657b10eb5
Remove useless log (#16624)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-04-27 10:01:47 +08:00
Letian Jiang
f75dedb317
Validate partitionIDs & segmentIDs in search request (#16639)
* check partitions if they are released or unloaded
* check segments if their collection/partition(s) are released or unloaded

Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-26 14:19:45 +08:00
yah01
80ae6de323
Add comments for concurrency package (#16654)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-04-26 11:33:45 +08:00
congqixia
bb69e09736
Use fmt.Errorf instead of string concat in querynode/segment.go (#16422)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-25 16:11:48 +08:00
yah01
7af02fa531
Improve load performance, load binlogs concurrently per file, deserialize binlogs concurrently per field/segment (#16514)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-04-25 15:57:47 +08:00
congqixia
b99b65c26e
Add segment reference count and handles change info in ShardCluster (#16620)
Resolves #16619
Add reference count for each search/query request
For SegmentChangeInfo
- Wait all segments in OnlineList to be loaded
- Add handoff event into pending list
- Wait all segments in OfflineList is not used (reference count = 0)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-25 11:51:46 +08:00
Ten Thousand Leaves
4ef2df8cb9
Fix an issue where query coord calls MinioChunkManager during init (#16629)
It causes Milvus not runnable with local storage.

issue: #15604

/kind enhancement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-04-25 11:11:46 +08:00
Xiaofan
89b4a34892
Fix Data race in NodeID (#16603)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-04-24 22:03:44 +08:00
congqixia
bd29518b6e
Remove debug log with no meaning (#16583)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-22 13:11:42 +08:00
congqixia
6de1d223a6
Remove debug log in querynode segment/node detector (#16572)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-22 11:07:42 +08:00
congqixia
69252f812d
Implement memory replica in Proxy, QueryNode and QueryCoord (#16470)
Related to #16298 #16291 #16154
Co-authored-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: yangxuan <xuan.yang@zilliz.com>
Co-authored-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Letian Jiang <letian.jiang@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-20 16:15:41 +08:00
codeman
4e12271d79
Support login with username and password (#15656) (#16341)
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Co-authored-by: kejiang <ke.jiang@zilliz.com>
2022-04-11 19:49:34 +08:00
Cai Yudong
71cd7ba67a
Add configuration common.indexSliceSize (#16438)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-04-08 20:29:33 +08:00
xige-16
27b4cbc098
Cherry pick remove translateHits commit to mater (#16436)
Signed-off-by: xige-16 <xi.ge@zilliz.com>

Co-authored-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-08 20:27:31 +08:00
godchen
bb7a0766fe
Add dependency factory (#16204)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2022-04-07 22:05:32 +08:00
congqixia
4cb7c28bfa
Fix ReplicaInfo package name (#16400)
Fix #16399
PR 16373 breaks the build after ReplicaInfo moved from querypb to milvuspb
Also fix  problem in Makefile
Limit action/setup-go version to ~1.17.1(>=1.17.1 <1.18.0)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-06 19:47:31 +08:00
congqixia
18d76261a0
Add ShardNodeDetector implementation (#16373)
Use etcd as a ShardNodeDetector
Unit tests is based on embedded etcd

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-06 15:43:31 +08:00
bigsheeper
2b27fa4609
Print numTimestamps instead of Timestamps (#16369)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-06 14:47:31 +08:00
bigsheeper
4f4a417c8f
Unify in log print (#16368)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2022-04-06 14:09:35 +08:00
Letian Jiang
09b90fd8bf
Fix QueryCollection retrieve unit test (#16376)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-04 21:07:30 +08:00
xige-16
99984b88e1
Support delete varChar value (#16229)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-04-02 17:43:29 +08:00
congqixia
aa1c26de77
Add ShardCluster implementation (#16360)
ShardCluster maintains shard replica meta information
It watches node & segment change events
Provides shard replica search/query services

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-02 17:35:29 +08:00
Letian Jiang
028c5cb882
Modify grpc interface for replica Search/Query in QueryNode (#16326)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-02 14:15:31 +08:00
congqixia
7a44fff8cd
Use fmt.Errorf instead of string concat in tsafe_replica (#16344)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-04-01 18:37:28 +08:00
Letian Jiang
cb65860e22
Add implementation for QueryShardService (#16317)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-04-01 14:19:29 +08:00
Letian Jiang
ad9a2217ae
Add interface for QueryShardService and QueryShard (#16309)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-03-31 14:05:28 +08:00
congqixia
899638810a
Add error log when tsafe register watcher more than once (#16294)
Add some test case to cover the error case
Add log in error branch

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-30 22:07:28 +08:00
Jiquan Long
ba37531456
Add support for loading multiple indexes (#16138)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-30 21:11:28 +08:00