Commit Graph

20538 Commits

Author SHA1 Message Date
yihao.dai
399ae75277
Revert "enhance: Support db for bulkinsert (#37012) (#37017)" (#37415)
This reverts commit d6adc62765.

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-11-04 18:24:59 +08:00
aoiasd
8370caa4a6
enhance: [Cherry-pick]Add collection name label for some metric (#36951) (#37159)
pr: https://github.com/milvus-io/milvus/pull/36951

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-10-29 17:38:22 +08:00
cai.zhang
05c40522ce
enhance: [cherry-pick ]Enhance the expression template to support AND and OR operations (#37217)
issue: #36672

master pr: #37033

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-10-29 15:38:40 +08:00
congqixia
3d1e81fb31
fix: [2.4] Use singleton delete pool and avoid goroutine leakage (#37225)
Cherry-pick from master
pr: #37220
Related to #36887

Previously using newly create pool per request shall cause goroutine
leakage. This PR change this behavior by using singleton delete pool.
This change could also provide better concurrency control over delete
memory usage.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-29 14:44:23 +08:00
congqixia
0b284ccc23
enhance: Bump milvus & proto version to v2.4.14 (#37198)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-29 10:44:25 +08:00
congqixia
49147524be
enhance: [2.4] Use middleware to observe restful v2 in/out rpc stats (#37224)
Cherry pick from master
pr: #37223
Related to #36102

Previous PR #36107 add grpc inteceptor to observe rpc stats. Using same
strategy, this pr add gin middleware to observer restful v2 rpc stats.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-29 10:26:24 +08:00
congqixia
b44ef8207e
fix: [2.4] Check whether new collection name is alias (#36981) (#37208)
Cherry pick from master
pr: #36981

Related to #36963

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-28 22:46:24 +08:00
wei liu
79e6ef2617
fix: Search/Query may failed during updating delegator cache (#37174)
issue: #37115
pr: #37116
casue init query node client is too heavy, so we remove
updateShardClient from leader mutex, which cause much more concurrent
cornor cases.

This PR delay query node client's init operation until `getClient` is
called, then use leader mutex to protect updating shard client progress
to avoid concurrent issues.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-10-28 20:08:25 +08:00
cai.zhang
9c0f59488a
feat: [cherry-pick]The expression supports filling elements through templates (#37058)
issue: #36672 

master pr: #37033 

milvus-proto pr: https://github.com/milvus-io/milvus-proto/pull/332

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-10-28 15:17:30 +08:00
XuanYang-cn
4cb5b2c3b5
fix: [cp24]Exlude L0 compaction when clustering is executing (#37142)
Also remove conflit check when executing L0. The exclusive is already
guarenteed in scheduler

See also: #37140
pr: #37141

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-10-28 15:01:30 +08:00
congqixia
223badc482
fix: [2.4] Ref collection meta when load l0 segment meta only (#37179)
Cherry pick from master
pr: #37178
Related to #37177

Previous PR #37160

Collection meta is not ref-ed when loading l0 segment in `RemoteLoad`
policy, which cause collection meta release when lots of l0 segment
released.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-28 14:07:30 +08:00
congqixia
9d37ade24f
enhance: [2.4] Make skip load work for all branches (#37161)
Cherry-pick from master
pr: #37160
Related to #37112

Skip load logic used to work only when there is multiple segment load
info entires in load request. In continous delete case, delegator still
loads l0 segment, which occupies lot of memory.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-25 22:11:30 +08:00
yihao.dai
d30e27e6f9
enhance: Make dataNode.import.maxConcurrentTaskNum dynamic (#37102) (#37103)
Resize import execution pool when config
`dataNode.import.maxConcurrentTaskNum` update.

issue: https://github.com/milvus-io/milvus/issues/37095

pr: https://github.com/milvus-io/milvus/pull/37102

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-10-25 18:21:29 +08:00
yihao.dai
da897e41f4
fix: Fix collection leak in querynode (#37061) (#37079)
Unref the removed L0 segment count.

issue: https://github.com/milvus-io/milvus/issues/36918

pr: https://github.com/milvus-io/milvus/pull/37061

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-10-25 18:19:39 +08:00
SimFG
ae4ce9bbba
enhance: [2.4] allow to delete data when disk quota exhausted (#37139)
- issue: #37133
- pr: #37134

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-10-25 16:07:32 +08:00
Xiaofan
2dc89b1cad
enhance: upgrade minio dependency (#37089)
fix #34910
upgrade minio dependency

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
2024-10-25 15:05:30 +08:00
wei liu
057bfbe678
fix: Delegator may becomes unserviceable after querycoord restart (#37055) (#37100)
issue: #37054
pr: #37055
after querycoord restart, segment_checker may release segment by mistake
due to next target isn't ready yet.

This PR requires release segment must happens after next target is
ready.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-10-25 14:55:31 +08:00
foxspy
ba8328727f
enhance: Update Knowhere version (#37132)
/kind branch-feature

release note:
https://github.com/zilliztech/knowhere/releases/tag/v2.3.12

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-10-25 14:47:30 +08:00
yihao.dai
ca2057c57d
enhance: Tidy import options (#37077) (#37078)
1. Tidy import options.
2. Tidy common import util functions.

issue: https://github.com/milvus-io/milvus/issues/34150

pr: https://github.com/milvus-io/milvus/pull/37077

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-10-25 14:35:45 +08:00
congqixia
6bc8aba17f
enhance: [2.4] Batch forward delete when using DirectForward (#37076) (#37107)
Cherry pick from master
pr: #37076
Related #36887

DirectFoward streaming delete will cause memory usage explode if the
segments number was large. This PR add batching delete API and using it
for direct forward implementation.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-25 11:53:29 +08:00
congqixia
79891f047d
enhance: [2.4]Skip load delta data in delegater when using RemoteLoad (#37082) (#37112)
Cherry-pick from master
pr: #37082
Related to #35303

Delta data is not needed when using `RemoteLoad` l0 forward policy. By
skipping load delta data, memory pressure could be eased if l0 segment
size/number is large.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-25 11:41:30 +08:00
wei liu
59b2563029
fix: Dynamic release parition may fail search/query. (#37049) (#37099)
issue: #33550
pr: #37049
cause wrong impl of UpdateCollectionNextTarget, if ReleaseCollection and
UpdateCollectionNextTarget happens at same time, the the released
partition's segment list may be add to target again, and delegator will
be marked as unserviceable due to lack of segment.

This PR fix the impl of UpdateCollectionNextTarget

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-10-24 18:01:30 +08:00
congqixia
3db137f4ad
enhance: [2.4] Add metrics for querynode delete buffer info (#37081) (#37097)
Cherry pick from master
pr: #37081
Related to #35303

This PR add metrics for querynode delegator delete buffer information,
which is related to dml quota logic.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-24 16:21:37 +08:00
yellow-shine
2abc28ec4f
enhance: [2.4]update nightly ci (#36423)
https://github.com/milvus-io/milvus/pull/37080

1. enhance: send email to qa when nightly ci failure

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-10-23 17:45:34 +08:00
presburger
27a4fe002a
enhance:change gpu default mem pool size (#36969)
Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
2024-10-23 17:17:28 +08:00
yihao.dai
d6adc62765
enhance: Support db for bulkinsert (#37012) (#37017)
issue: https://github.com/milvus-io/milvus/issues/31273

pr: https://github.com/milvus-io/milvus/pull/37012

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-10-23 16:31:29 +08:00
congqixia
b958c56f48
fix: [2.4] Rectify delete buffer row count quota value (#37060) (#37068)
Cherry pick from master
pr: #37060

Related to #37057

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-23 14:13:28 +08:00
congqixia
7eba3aa67e
fix: [2.4] Pass full field list when partial load enabled (#37053) (#37063)
Cherry-pick from master
pr: #37053

Related to #37038

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-23 11:03:28 +08:00
Alexander Guzhva
415f2f47c0
enhance: [2.4][bitset] multiple 'and' and 'or' in a single op (#36973)
issue: #34117
pr: #33345 

Refactoring:
* Added a capability to perform multiple bitwise and and or operations
in a single op
* AVX2, AVX512, ARM NEON, ARM SVE backed bitwise and, op, xor and sub
ops
* more unit tests for bitset
* fixed a bug in or_with_count for certain bitset sizes
* fixed a bug for certain offset values for inplace operations that take
two bitsets

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
2024-10-22 16:25:33 +08:00
smellthemoon
d2a1db922f
enhance: refactor createCollection in RESTful API(#36790) (#36885)
pr: #36790 
and pr:#36930

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-10-22 14:21:27 +08:00
congqixia
7acf1d53c1
enhance: [2.4] Preallocate delete data slice to avoid growslice (#37044)
Rewritten based on master pr
pr: #37043

Related to #36887

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-22 14:15:28 +08:00
SimFG
55caf41169
enhance: [2.4] set the rpc error code to avoid the invalid retry (#37025)
- pr: #37024

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-10-22 11:17:28 +08:00
yihao.dai
539f56220f
enhance: Remove bf from datanode (#36367) (#37027)
Remove bf from datanode:
1. When watching vchannels, skip loading **flushed** segments's bf. For
generating merged bf, we need to keep loading **growing** segments's bf.
2. Bypass bloom filter checks for delete messages, directly writing to
L0 segments.
3. In version 2.4, when dropping a partition, marking segments as
dropped depends on having the full segment list in the DataNode. So, we
need to keep syncing the segments every 10 minutes.

issue: https://github.com/milvus-io/milvus/issues/34585

pr: https://github.com/milvus-io/milvus/pull/35902,
https://github.com/milvus-io/milvus/pull/36367,
https://github.com/milvus-io/milvus/pull/36592

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-10-22 11:15:28 +08:00
Chun Han
a2d4520dc7
enhance: avoid limiting ddl operations repeatedly(#37006) (#37011)
related: #37006

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
2024-10-22 10:41:28 +08:00
XuanYang-cn
6b68ec55e1
enhance: [24]Track complex delete rates (#36958)
See also: #36953
pr: #36957

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-10-22 10:07:27 +08:00
yanliang567
80db377586
test: [cherry pick]Add alias tests for rename collection (#37008)
related issue: https://github.com/milvus-io/milvus/issues/36963
pr: https://github.com/milvus-io/milvus/pull/36978

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2024-10-21 18:45:32 +08:00
wei liu
1dcc393e54
fix: Query node panic during sending rpc to worker (#36975) (#36988)
issue: #36976
pr: #36975

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-10-21 10:15:26 +08:00
yihao.dai
4e0f5845a1
enhance: Limit import job number (#36891) (#36892)
issue: https://github.com/milvus-io/milvus/issues/36890

pr: https://github.com/milvus-io/milvus/pull/36891

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-10-18 18:13:25 +08:00
XuanYang-cn
7847b662d4
enhance: [cp24]Log when limit writing by deletion (#36955)
See also: #36953
pr: #36954

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-10-18 17:47:30 +08:00
yihao.dai
8923936c9a
enhance: Support memory mode chunk cache (#35347) (#35836)
Chunk cache supports loading raw vectors into memory.

issue: https://github.com/milvus-io/milvus/issues/35273

pr: https://github.com/milvus-io/milvus/pull/35347

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-10-18 17:03:25 +08:00
Ted Xu
2742524508
enhance: enable parallel execution of L0 compactions (#36816) (#36985)
pr: #36816

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
2024-10-18 16:17:25 +08:00
wei liu
b88d610e42
fix: datacoord stuck at stopping progress (#36852) (#36961)
issue: #36868
pr: #36852
if datacoord is syncing segments to datanode, and stop datacoord
happens, datacoord's stop progress will stuck until syncing segment
finished.

This PR add ctx to syncing segment, which will failed if stopping
datacoord happens.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-10-18 14:43:24 +08:00
Ted Xu
22838a8413
enhance: Datacoord to support prioritization of compaction tasks (#36979)
See #36550

pr: #36547 
pr: #36956

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
2024-10-18 14:15:25 +08:00
cai.zhang
2bfd22f217
fix: [cherry-pick] Fix clustering compaction task leak (#36803)
issue: #36686
master pr: #36800 

bug reason:
- The clustering compaction tasks on the datanode were never cleaned up.
- The clustering compaction task contains a mapping from clustering key
to buffer, this caused a large memory leak.

fix:
- clean the tasks on datanode by datacoord when clustering compaction
finished.
- reset the mapping that from clustering key to buffer on datanode when
clustering finished.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-10-17 20:43:30 +08:00
cqy123456
6934e8da3a
enhance: [2.4]use growingMmapEnabled to control the behavior of interim index, not vectorField (#36391)
issue: https://github.com/milvus-io/milvus/issues/36392
related pr: https://github.com/milvus-io/milvus/pull/36500

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-10-17 20:23:25 +08:00
sre-ci-robot
4d2f44d536
[automated] Update Pytest image changes (#36900)
Update Pytest image changes
See changes:
b90cda2e5d
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-10-17 18:39:24 +08:00
cqy123456
ff662308ed
fix:[2.4]Chunk Id out of range in vector BF search, after the growing index removes the vec chunks. (#36938)
issue: https://github.com/milvus-io/milvus/issues/36871
related pr: https://github.com/milvus-io/milvus/pull/36939

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-10-17 16:51:24 +08:00
congqixia
3252d7a64c
fix: [2.4] Load original key if ts is MaxTimestamp (#36934) (#36950)
Cherry-pick from master
pr: #36934 

Related to #36933

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-17 16:05:29 +08:00
yellow-shine
a9d64d6e09
Bump milvus version to v2.4.13-hotfix (#36948)
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-10-17 14:17:28 +08:00
congqixia
dfe27ebf35
fix: [2.4] Direct forward delta exclude l0 segments (#36899) (#36914)
Cherry-pick from master
pr: #36899

Related to #36887

Forward delete to L0 segment will return error and mark l0 segment
offline causing delegator unserviceable

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-10-17 14:11:29 +08:00