wei liu
7c35c51e15
fix: Rootcoord stuck at graceful stop progress ( #36881 )
...
issue: #34553
pr: #36880
when rootcoord trigger graceful stop progress, it will block until all
rpc finished. for create collection request, rootcoord need to block
until datacoord finish to watch all channels, but datacoord need to call
`rootcoord.Alloc` during watch channel, and rootcoord doesn't respond to
new request anymore. which cause create collection stucks, and graceful
stop progress stucks.
This PR remove the func call `rootcoord.Alloc` to solve the logic dead
lock during graceful stop progress.
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-10-17 12:13:37 +08:00
yihao.dai
423ecd648e
enhance: Add build-go target ( #35844 ) ( #35845 )
...
Add a build-go target to the Makefile that only compiles Go.
issue: https://github.com/milvus-io/milvus/issues/35611
pr: https://github.com/milvus-io/milvus/pull/35844
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-09-02 10:45:02 +08:00
zhenshan.cao
1916aec67a
enhance: [skip e2e] add make run-test-cpp gtest ( #35829 ) ( #35837 )
...
pr: https://github.com/milvus-io/milvus/pull/35829
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-08-29 21:15:02 +08:00
Zhen Ye
7062e6fcbf
enhance: enable asan for milvus ( #35687 )
...
issue: #35626
pr: #35627
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-26 09:54:58 +08:00
wei liu
e2542a1bf5
enhance: Update protobuf-go to protobuf-go v2 ( #34394 ) ( #35555 )
...
issue: #34252
pr: #34394 #35072 #35084
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-21 18:50:58 +08:00
Ted Xu
ce53e79f12
fix: enable milvus.yaml check ( #34567 ) ( #35446 )
...
See #32168
pr: #34567 #35152
---------
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
2024-08-13 19:00:23 +08:00
congqixia
8991dc211e
enhance: [2.4] Fix go&cpp lint issues ( #35107 )
...
See also #34483
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-30 20:25:55 +08:00
shaoyue
0417463e90
enhance: Gin & restfulv1 handler use sonic json ( #35018 )
...
/cc @czs007 @congqixia
master pr: #35020
Signed-off-by: haorenfsa <haorenfsa@gmail.com>
2024-07-29 00:39:49 +08:00
SimFG
9cf1f03e89
fix: [2.4] the lint-fix error ( #34717 )
...
- issue: #31293
- pr: #34033
- related pr: #34699
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-07-16 17:37:39 +08:00
SimFG
13f129aa9c
enhance: [2.4] format the sdk code ( #34699 )
...
- issue: #31293
- pr: #34033
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-07-16 14:15:38 +08:00
chyezh
a1a0a56f86
enhance: async search and retrieve in cgo ( #34200 )
...
issue: #33132
pr: #33133
other pr: #33228 , #34084 , #33946
- implement future-based cgo utility
- async search and retrieve in cgo
- modify gc configuration document
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-07-04 13:02:09 +08:00
congqixia
3efb78e154
enhance: [2.4] Tag gotestsum version when install deps ( #34308 ) ( #34401 )
...
Cherry-pick from master
pr: #34308
Tagging gotestsum by ldflags to prevent reinstall gotestsum binary each
local run
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-04 10:30:09 +08:00
cai.zhang
c924b0b502
enhance: [cherry-pick] Refine index code and support analyze data ( #34311 )
...
This PR primary picks up the support analyzing functionality, including
the following commits:
- main functionality: https://github.com/milvus-io/milvus/pull/33651
- refine indexnode code: https://github.com/milvus-io/milvus/pull/33458
- related fixes:
- https://github.com/milvus-io/milvus/pull/33832
- https://github.com/milvus-io/milvus/pull/33161
issue: #30633
master prs: #33651 , #33458 , #33832 , #33161
---------
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
Co-authored-by: chasingegg <chao.gao@zilliz.com>
Co-authored-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
2024-07-02 09:50:39 +08:00
zhenshan.cao
14a11e379c
enhance: Refactor Compaction to enable persistence( #33265 ) ( #34268 )
...
pr : #33265
issue #33586
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-07-01 19:32:07 +08:00
XuanYang-cn
a33b68678d
enhance: [cherry-pick] Move compactor into sub package ( #34098 )
...
This PR consists of the following commits:
- enhance: Tidy compactor and remove dup codes (#32198 )
- fix: Fix l0 compactor may cause DN from OOM (#33554 )
- enhance: Add deltaRowCount in l0 compaction (#33997 )
- enhance: enable stream writer in compactions (#32612 )
- fix: turn on compression on stream writers (#34067 )
- fix: adding blob memory size in binlog serde (#33324 )
See also: #32451 , #33547 , #33998 , #31679
pr: #32198 , #33554 , #33997 , #32612
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Co-authored-by: Ted Xu <ted.xu@zilliz.com>
2024-06-25 11:16:02 +08:00
wei liu
fbc8fb3cb2
enhance: Skip return data distribution if no change happen ( #32814 ) ( #33985 )
...
issue: #32813
pr: #32814
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-21 10:24:12 +08:00
shaoting-huang
b3d425f50a
enhance: Upgrade go version from 1.20 to 1.21 ( #33940 )
...
issue #32982
related pr in master:
pr: #33047 #33150 #33176 #33351 #33202 #33192
Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-06-20 14:52:00 +08:00
aoiasd
cbbfb5b6d6
enhance: Add update milvus yaml command to makefile ( #32857 )
...
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-05-10 14:31:37 +08:00
yiwangdr
b1eacb2ae8
feat: datacoord/node watch based on rpc ( #32036 )
...
issue: https://github.com/milvus-io/milvus/issues/25309
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2024-05-07 15:49:30 +08:00
SimFG
2944971507
enhance: fix the dev docker yaml and use go install
to install the gotestsum ( #32197 )
...
/kind improvement
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-04-12 19:17:18 +08:00
SimFG
c012e6786f
feat: support rate limiter based on db and partition levels ( #31070 )
...
issue: https://github.com/milvus-io/milvus/issues/30577
co-author: @jaime0815
---------
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
Signed-off-by: SimFG <bang.fu@zilliz.com>
Co-authored-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
2024-04-12 16:01:19 +08:00
congqixia
f399416b92
enhance: Use gotestsum to run go unit test ( #31622 )
...
See also #31490
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-03-27 15:29:10 +08:00
Bingyi Sun
0ac9bb4a9c
enhance: add mmap migration tool ( #30909 )
...
issue: #30908
---------
Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-03-25 15:51:09 +08:00
congqixia
4da8b6607d
enhance: Add scripts to use gotestsum
to execute integration test ( #31490 )
...
See also #31489
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-03-22 10:29:06 +08:00
Jiquan Long
375190e76e
fix: cpp format check not work ( #30767 )
...
fix : #30765
---------
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-02-22 19:40:53 +08:00
zhagnlu
976b6fc0e4
enhance: change opendal as compile configurable ( #30384 )
...
#30373
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-02-20 19:16:52 +08:00
congqixia
a68b32134a
fix: Verify sync task target segment and retry if not match ( #30500 )
...
See also #27675 #30469
For a sync task, the segment could be compacted during sync task. In
previous implementation, this sync task will hold only the old segment
id as KeyLock, in which case compaction on compacted to segment may run
in parallel with delta sync of this sync task.
This PR introduces sync target segment verification logic. It shall
check target segment lock it's holding beforing actually syncing logic.
If this check failed, sync task shall return`errTargetSegementNotMatch`
error and make manager re-fetch the current target segment id.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-02-05 11:33:43 +08:00
congqixia
5be909982d
enhance: add MockSerializer generation command into Makefile ( #29713 )
...
See also #27675
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-01-05 21:42:47 +08:00
XuanYang-cn
632d8b3743
enhance: Change DN channelmanger into interface ( #29307 )
...
See also: #28854
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-27 16:00:48 +08:00
congqixia
277849a915
enhance: separate serializer logic from sync task ( #29413 )
...
See also #27675
Since serialization segment buffer does not related to sync manager can
shall be done before submit into sync manager. So that the pk statistic
file could be more accurate and reduce complex logic inside sync
manager.
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-26 10:40:47 +08:00
XuanYang-cn
ae180d1628
enhance: Change ChannelManager to interface ( #29300 )
...
Rewrite cluster test
issue: #28854
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-25 19:24:46 +08:00
SimFG
67ab0e424b
fix: Clean the compaction plan info to avoid the object leak ( #29365 )
...
issue: #29296
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-22 12:00:43 +08:00
wei liu
e41fd6fbde
enhance: Move proxy client manager to util package ( #28955 )
...
issue: #28898
This PR move the `ProxyClientManager` to util package, in case of
reusing it's implementation in querycoord
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-20 19:22:42 +08:00
zhagnlu
a602171d06
enhance: Refactor runtime and expr framework ( #28166 )
...
#28165
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-12-18 12:04:42 +08:00
wei liu
fe1eeae2aa
enhance: Use mockery to replace manual mock code ( #29074 )
...
issue: #29043
This PR remove mannul mock code for proxy and data coord
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-13 10:46:44 +08:00
aoiasd
3c32ba2407
enhance: pack datacoord Cluster and SessionManager with interface and mock them ( #28869 )
...
relate: https://github.com/milvus-io/milvus/issues/28861
https://github.com/milvus-io/milvus/issues/28854
---------
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-11 17:52:37 +08:00
XuanYang-cn
5bac7f7897
fix: Fix L0 compaction in datacoord ( #28814 )
...
See also: #27606
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-05 18:44:37 +08:00
XuanYang-cn
e62edb991a
enhance: Add FlowgraphManager interface ( #28852 )
...
- Change flowgraphManager to fgManagerImpl
- Change close to stop
- change execute to controlMemWaterLevel
- Change method name of fgManager for readability
- Add mockery for fgmanager
Issue: #28853
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-30 18:42:32 +08:00
XuanYang-cn
aae7e62729
feat: Add levelzero compaction in DN ( #28470 )
...
See also: #27606
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-30 14:30:28 +08:00
cai.zhang
f5f4f0872e
enhance: Support importing data with parquet file ( #28608 )
...
issue: #28272
Numpy does not support array type import.
Array type data is imported through parquet.
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-29 20:52:27 +08:00
XuanYang-cn
9b371067d2
feat: Add Compaction views and triggers ( #27906 )
...
- Add Compaction l0 views
- Add Compaction scheduler
- Add Compaction triggerv2
- Add Compaction view manager
See also: #27606
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-23 17:30:25 +08:00
Bingyi Sun
d7145e2c06
enhance: Update golangci_lint version ( #28535 )
...
Update golangci lint and fix some warnings
Signed-off-by: sunby <sunbingyi1992@gmail.com>
2023-11-21 10:04:21 +08:00
Enwei Jiao
7445d3711c
feat: trigger compaction to handle index version ( #28442 )
...
issue: https://github.com/milvus-io/milvus/issues/28441
---------
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-11-21 09:26:22 +08:00
congqixia
bed7467f20
enhance: Remove commented code and fix naming issue ( #28450 )
...
This PR removes all the commented code and files from PR #28320
For naming issue:
- Renaming `MinCheckpoint` to `EarliestPosition`, see #28320 comment
- Renaming `writebuffer.Mananger` to `BufferMananger`, see #27874
comment
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-16 00:22:20 +08:00
congqixia
0b905078e7
Use writebuffer, sync manager refactory in datanode ( #28320 )
...
See also #27675
This PR make previously merged refactory of datanode go online
- Use write node to replace insert/delete node
- Use write buffer manager to control all buffers
- Use sync manager to control sync tasks instead of flush manager
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-15 15:24:18 +08:00
wei liu
5b45a138b1
disable auto balance when old node exists ( #28191 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-11-07 14:02:20 +08:00
congqixia
bf2f62c1e7
Add WriteBuffer
to provide abstraction for delta policy ( #27874 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-04 12:10:17 +08:00
wei liu
ecec5dfcfd
fix retry on offline node ( #28079 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-11-03 10:14:16 +08:00
congqixia
233bf90c55
Add SyncManager to replace flush manager ( #27873 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-10-31 02:30:16 +08:00
xige-16
bf46ffd6c4
Fix build with diskann failed ( #27672 )
...
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-10-12 19:25:35 +08:00