aoiasd
233b8486ec
fix: generate gin logs failed cause access logs panic ( #34142 )
...
relate: https://github.com/milvus-io/milvus/issues/34141
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-07-05 16:30:10 +08:00
zhagnlu
18f2458385
fix: fix bitmap supported type ( #34350 )
...
#34314
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-07-05 15:50:10 +08:00
jaime
21fc5f5d46
enhance: Remove datanode reporting TT based on MQ implementation ( #34421 )
...
issue: #34420
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-07-05 15:48:09 +08:00
SimFG
0817802db8
enhance: use the key lock and concurrent map in the msg dispatcher client ( #34278 )
...
/kind improvement
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-07-05 15:11:31 +08:00
Dan Dascalescu
7cac20f836
doc: Update # of GitHub stars in README.md ( #33577 )
...
The # of stars for https://github.com/milvus-io/milvus/ is over 27k now,
though https://zilliz.com/what-is-milvus links to
https://github.com/zilliztech , and [the fork
there](https://github.com/zilliztech/milvus ) has only 23 stars.
2024-07-05 14:40:10 +08:00
chyezh
ba04981a43
enhance: implement wal managerment on streaming node ( #34153 )
...
issue: #33285
- add lifetime control for wal.
- implement distributed-safe wal manager on streaming node.
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-07-05 14:29:42 +08:00
ThreadDao
67747245f4
test: add test cases for gosdk v2 index ( #34431 )
...
issue: #33419
- Add test cases for gosdk v2 index
- Add sparse index for go client
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
2024-07-05 09:10:09 +08:00
sre-ci-robot
d65b6895d7
[automated] Update Knowhere Commit ( #34432 )
...
Update Knowhere Commit
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-05 01:18:09 +08:00
PowderLi
c16a704934
fix: [restful v2] count(*) & hook ( #34369 )
...
issue: #31224 #34374
for query api:
1. param filter is not requried
2. param limit is useless while outputFields = [count(*)]
add hook about grpc call
---------
Signed-off-by: PowderLi <min.li@zilliz.com>
2024-07-04 19:38:09 +08:00
congqixia
439fb24b32
fix: Skip l0 segments when syncing segments to datanodes ( #34388 )
...
See also #34387
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-04 18:02:14 +08:00
Chun Han
fcafdb6d5f
enhance: reconstruct scalar part's code for segment-pruner( #30376 ) ( #34346 )
...
related: #30376
1. support more complex expr
2. add more ut test for unrelated fields
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
2024-07-04 16:36:09 +08:00
yihao.dai
0b404bff22
fix: Correct the update logic of timerecorder ( #34339 )
...
Correct the update logic of timerecorder in the flowgraph to avoid false
failure: "some node(s) haven't received input".
issue: https://github.com/milvus-io/milvus/issues/34337
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-04 16:34:17 +08:00
chyezh
7611128e57
enhance: wal adaptor implementation ( #34122 )
...
issue: #33285
- add adaptor to implement walimpls into wal interface.
- implement timetick sorted and filtering scanner.
- add test for wal.
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-07-04 15:23:08 +08:00
ThreadDao
e4cece8de8
test: add cases for gosdk v2 upsert ( #34400 )
...
- test: add cases for gosdk v2 upsert
- test: update clientv2 to client reference
issue: #33419
Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
2024-07-04 14:26:09 +08:00
Chun Han
10b3ce24ba
enhance: use configed max topk for iterator when input topk exceeds ( #34290 )
...
related: #34290
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
2024-07-04 14:24:19 +08:00
congqixia
d51d0954bd
enhance: Continue loop when reassign channel fails ( #34331 )
...
Log will be confusing when `Reassign` channel operation failed for both
success & failure log will be printed in row. This PR continue the loop
to avoid this output.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-04 14:20:10 +08:00
SimFG
c6e2900cfc
enhance: add the tick log for the tt msgstream seek method ( #34397 )
...
/kind improvement
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-07-04 10:18:09 +08:00
XuanYang-cn
8a2be8a457
fix: DataNode might OOM by estimating based on MemorySize ( #34201 )
...
See also: #34136
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-07-04 10:16:17 +08:00
wei liu
9db897985b
enhance: refine misleading param name for bloom filter parallel factor ( #34334 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-04 10:06:10 +08:00
cai.zhang
23e2a0e78b
fix: Remove unused code to fix compiling ( #34406 )
...
issue: #34407
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-07-04 08:48:08 +08:00
jaime
d1f57aa4ba
enhance: remove deprecated code within channel manager ( #34340 )
...
issue: https://github.com/milvus-io/milvus/issues/33994
only remove deprecated code, no additional changes.
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-07-03 19:46:09 +08:00
congqixia
0fd0fcfe1d
enhance: Fix lint issues & sdk testcase ( #34399 )
...
Some lint issue is not detect due to recent static check pipeline issue.
This PR fixes these problem and Go milvusclient testcases.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-03 19:42:10 +08:00
wayblink
da56880d0f
fix: Avoid datarace in clustering compaction ( #34288 )
...
#34289
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-07-03 19:08:09 +08:00
pingliu
8c42f1341d
doc: [skip e2e] add extraConfig to embed milvus ( #34395 )
...
Signed-off-by: ping.liu <ping.liu@zilliz.com>
2024-07-03 18:20:17 +08:00
wayblink
a501fa11c0
fix: remove isFull check in compaction.enqueue ( #34338 )
...
#30633
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-07-03 18:10:10 +08:00
cai.zhang
2e434e4453
fix: Only load or release Flushed segment in datanode meta ( #34390 )
...
issue: #34376 , #34379 , #34375
---------
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-07-03 17:52:09 +08:00
congqixia
94fb5805d5
fix: Use raw parameter value to perform CAS ( #34343 )
...
See also #34342
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-03 16:00:08 +08:00
cai.zhang
feb13cdf07
enhance: Skip pick worker when task doesn't need to execute actually ( #34348 )
...
issue: #34347
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-07-03 15:52:09 +08:00
cai.zhang
8165961223
enhance: Optimeize clustering compaction ( #34313 )
...
issue: #30633
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-07-03 15:14:08 +08:00
congqixia
776ffee840
enhance: Tag gotestsum version when install deps ( #34308 )
...
Tagging gotestsum by ldflags to prevent reinstall gotestsum binary each
local run
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-03 14:44:13 +08:00
Patrick Weizhi Xu
32c943f1bc
enhance: [skip e2e] update the version of MV ( #34378 )
...
issue: #29892
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
2024-07-03 14:28:16 +08:00
wayblink
fb61344dc9
fix: Revert a optimize in clustering compaction ( #34299 )
...
#30633
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-07-03 10:32:08 +08:00
Chun Han
34bec2ea5e
enhance: add metrics for segment prune latnecy( #30376 ) ( #34094 )
...
related: #30376
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
2024-07-03 10:04:07 +08:00
Buqian Zheng
fa8d641ce6
fix: update check for sparse hnsw index ( #33713 )
...
issue: #29419
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2024-07-02 21:56:09 +08:00
Gao
ec5db7a57d
enhance: update knowhere version ( #34361 )
...
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-07-02 19:18:24 +08:00
chyezh
3563136c2a
enhance: timetick interceptor implementation ( #34238 )
...
issue: #33285
- optimize the message package
- add interceptor package to achieve append operation intercepting.
- add timetick interceptor to attach timetick properties for message.
- add timetick background task to send timetick message.
Signed-off-by: chyezh <chyezh@outlook.com>
2024-07-02 14:42:08 +08:00
cai.zhang
a5be322ab2
enhance: Don't set the timeout for SyncSegments ( #34226 )
...
issue: #32809
---------
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-07-02 14:28:07 +08:00
congqixia
87bccb1a6b
enhance: [GoSDK] Sync IndexType supported from v1 ( #34310 )
...
See also #31293
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-01 23:54:06 +08:00
cai.zhang
4cf1a358ba
fix: Sync the sealed and flushed segments to datanode ( #34301 )
...
issue: #33696
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-07-01 22:42:08 +08:00
congqixia
b32dae1883
enhance: Refine max length exceeded error message ( #34300 )
...
This PR make varchar & string array field max length exceeded error
message clearer. Also fixed a minor issue that error string format and
argument number not match.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-01 21:16:07 +08:00
congqixia
e083d99dd9
enhance: Use channel name map finding channel watcher ( #34294 )
...
See also #33235
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-01 18:46:07 +08:00
yihao.dai
734415b8a2
fix: Reduce duplicate PKs in segcore ( #34267 )
...
issue: https://github.com/milvus-io/milvus/issues/34247
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-01 17:42:06 +08:00
congqixia
b284b81a47
fix: Check partition in current target when observing partition load status ( #34282 )
...
See also #34234
`LoadPartitions` does not guarantee the current target has loading
partitions if there are some partitions already loaded before.
This PR check current target contains the partition to load when
advancing loading percentage to 100.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-01 17:40:07 +08:00
smellthemoon
ef3ced8138
fix: descriptor event in previous version not has nullable to parse error ( #34235 )
...
#34176
---------
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-07-01 16:38:06 +08:00
yihao.dai
ff51c7e628
fix: Fix panic due to failed to seek ( #34229 )
...
Converting the same msgposition's vchannel to a pchannel multiple times
would result in an invalid pchannel, leading to seek failure and panic.
This PR:
1. Make a copy of msgposition in msgdispatcher.
2. Check if channel is already a pchannel, no further channel conversion
is performed.
issue: https://github.com/milvus-io/milvus/issues/34221
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-01 16:08:12 +08:00
wei liu
b49862d4f3
enhance: Optimize grow slice cost during query ( #34253 )
...
issue: #32252
This PR try to pre-allocate FieldData for Reduce operations in the Query
chain using typeutil.PrepareResultFieldData to avoid the overhead of
dynamically growing the slice during appendFieldData process.
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-01 15:18:11 +08:00
aoiasd
186757e622
enhance: support mark error as user error ( #33498 )
...
relate: https://github.com/milvus-io/milvus/issues/33492
---------
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-07-01 14:56:12 +08:00
jaime
d6afb31b94
enhance: make subfunctions of datanode component modular ( #33992 )
...
issue: #33994
also remove deprecated channel manager based on the etcd implementation
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-07-01 14:46:07 +08:00
congqixia
14e827dc6c
fix: Implement singleflight for segcore ChunkCache ( #34250 )
...
See also #34249
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-01 11:46:06 +08:00
wei liu
f7ecafe77d
enhance: Skip update index for L0 segment ( #34099 )
...
try to update index for l0 segment, will failed by `index not found`
This PR skip update index for l0 segment
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-01 10:26:06 +08:00