Commit Graph

20468 Commits

Author SHA1 Message Date
jaime
b92daa1532
fix: iaccurate size estimation for encoded array data (#36379)
issue: #36029
pr: #36373

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-09-23 21:17:13 +08:00
yanliang567
7218a58477
test: [Cherry Pick]Add partial load tests (#36432)
related issue: #36037
pr: #36427

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2024-09-23 17:11:13 +08:00
SimFG
a35d99eabf
fix: [2.4] long buffering causes mq to be unable to receive messages. (#36425)
- issue: #36397
- pr: #36420

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-09-23 16:33:17 +08:00
congqixia
2b796b180b
enhance: Bump milvus & proto version to v2.4.12 (#36376)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-23 14:51:13 +08:00
congqixia
e083bf39f8
fix: [2.4] Return all compactTo segments after support split (#36361) (#36429)
Cherry-pick from master
pr: #36361
Related to #36360

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-23 14:39:12 +08:00
foxspy
7ac3ef9acb
enhance: Update Knowhere version (#36402)
/kind branch-feature

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-09-20 19:25:11 +08:00
yellow-shine
e8e40a0000
enhance: use pull request number as image tag in ci (#36285)
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-09-20 16:15:30 +08:00
congqixia
210adbaffc
fix: [2.4] Wait check node id goroutine in case of data race (#36302) (#36377)
Cherry-pick from master
pr: #36302
Resolves: #36301

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-20 13:03:12 +08:00
congqixia
eb1602a374
enhance: [2.4] Graceful stop flowgraph manager when stopping datanode (#36229) (#36358)
Cherry pick from master
pr: #36229

Flowgraph manager is not stopped during datanode stopping procedure
which may lead to unexpect flowgraph behavior during/after datanode stop
progress.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-19 17:39:12 +08:00
Bingyi Sun
e2f1beb543
fix: remove element type check (#35828) (#36324)
https://github.com/milvus-io/milvus/issues/36275
Array's element type is not same with schema's. It is INT32 for INT16
and INT8

related pr: #35828

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-09-19 11:55:13 +08:00
congqixia
e66beb7ace
enhance: [2.4] Ignore index check for non-loaded vector field (#36170) (#36280)
Cherry-pick from master
pr: #36170
Related to #35996

For `Field Partial Load` feature, Milvus shall ignore index check for
non-loaded vector field.

Also, this PR unifies the logic of index check for load collection and
load partitions tasks.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-19 10:07:12 +08:00
congqixia
4a47b1272d
enhance: [2.4] Filter out non-hit delete records during load delta (#36207) (#36272)
Cherry-pick from master
pr: #36207
Related to #35303

This PR utilizes pk index in segment to exclude non-hit delete record
during load delete records. This ability is crucial when l0/delete
forward policy only replies on segment itself(without BF filtering).

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-19 10:05:20 +08:00
wei liu
d421effb03
fix: fix search/query/count may access same growing and sealed segment (#36258) (#36288)
issue: #36257
pr: #36258
during syncTargetVersion, sealed segment should be excluded, to avoid
it's growing segment be conusmed from stream again.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-09-18 22:21:12 +08:00
Zhen Ye
d1440867b7
fix: add future stateful lock (#36333)
issue: #36323
pr: #36332

Signed-off-by: chyezh <chyezh@outlook.com>
2024-09-18 20:09:12 +08:00
zhagnlu
d1730b8853
fix: fix rewrite output field because of merge error (#36338)
issue: #36340

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-09-18 20:01:12 +08:00
yellow-shine
a097d4e122
enhance: fix standalone kafka pipeline of e2e (#36119)
https://github.com/milvus-io/milvus/pull/36117

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-09-18 19:33:17 +08:00
sre-ci-robot
a63badab5d
[automated] Update Pytest image changes (#36298)
Update Pytest image changes
See changes:
2df9309b4a
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-18 19:31:12 +08:00
SimFG
95e47bfcf8
fix: force to set the metric type in the search request (#36279)
- issue: #35960
- pr: #35962

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-09-18 19:21:11 +08:00
jaime
817fe486d6
enhance: catch std::stoi exception and improve error msg (#36296)
issue: #36255
pr: #36267

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-09-18 17:29:11 +08:00
cai.zhang
72f182384b
enhance: [cherry-pick]Refine the code for returning error (#36104)
issue: #36023 

master pr: #36103

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-09-15 15:23:14 +08:00
cai.zhang
eb47150f66
enhance: [cherry-pick]Disallow the keywords as a field name or dynamic field name (#36108)
issue: #35873

master pr: #36101

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-09-15 15:19:14 +08:00
zhenshan.cao
2bc454bf40
fix: keep inner topK to avoid exceeding efSearch (#36287)
issue :https://github.com/milvus-io/milvus/issues/36243
pr : https://github.com/milvus-io/milvus/pull/36284

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-09-15 15:12:38 +08:00
nico
2df9309b4a
test: update pymilvus version and skip some cases (#36283)
pr: #36281

Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-09-14 17:57:14 +08:00
wei liu
efed3d3ed0
fix: [skip e2e] Fix unstable ut TestCollectionObserver (#36231) (#36260)
issue: #36237
pr: #36231

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-09-14 15:43:08 +08:00
wei liu
38b307e230
fix: Clean dirty segment/channel on querynode (#36202) (#36259)
issue: #36201
pr: #36202
after querynode has been remove from replica, all dirty segment/channel
on it should be released.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-09-14 14:41:09 +08:00
congqixia
f7e4db943c
fix: [2.4] overwrite correct selection when pk duplicated (#35826) (#36274)
Cherry-pick from master
pr: #35826
Related to #35505

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-14 14:27:07 +08:00
XuanYang-cn
c1dab50fed
enhance: [cp]Add metrics for Delete entries num of L0seg (#36227)
- Add metrics *DataCoordL0DeleteEntriesNum*
- Remove metrics *DataCoordRateStoredL0Segment*

See also: #36147
pr: #36175

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-09-14 10:37:08 +08:00
yellow-shine
d094ec26c1
enhance: git clone with retry mechanism (#36263)
https://github.com/milvus-io/milvus/pull/36256

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-09-14 09:44:50 +08:00
zhenshan.cao
34e5f99bd6
fix: Fix improper use of offset in HybridSearch (#36253)
pr : https://github.com/milvus-io/milvus/pull/36244
issue : https://github.com/milvus-io/milvus/issues/36243

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-09-13 22:05:14 +08:00
jaime
faf5be2e72
fix: metrics stored_index_files_size is never cleared (#36161)
issue: ##36159
pr: #36160

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-09-13 20:09:15 +08:00
wei liu
5cd860652d
enhance: Enable dynamic update replica selection policy (#35824)
issue: #35859
pr: #35860

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-09-13 17:05:15 +08:00
wei liu
16daf9177f
fix: fix ReadWrite privilege group deny all global API (#36145)
issue: #35471
pr: #36144

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-09-13 10:31:07 +08:00
congqixia
13d443eb2e
enhance: [2.4] Add L0 forward policy to support remote load (#36189) (#36208)
Cherry-pick from master
pr: #36189
Related to #35303

This PR add a param item to support change l0 forward behavior from bf
filtering and forward to remote load.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-12 19:09:08 +08:00
sre-ci-robot
97ddf1e29d
[automated] Update Pytest image changes (#36136)
Update Pytest image changes
See changes:
33054d5723
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-12 17:29:12 +08:00
congqixia
ab31728b2c
enhance: [2.4] Check ANN field loaded in proxy (#36172) (#36194)
Cherry-pick from master
pr: #36172
Related to #35415

Currently ANN field is loaded in Parital load is not performed in proxy,
this cause error message not clear and no error returned when collection
is empty

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-12 16:05:08 +08:00
Buqian Zheng
089790a459
enhance: [2.4]Allow empty sparse row (#36061)
pr: #34700

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2024-09-12 10:13:09 +08:00
yellow-shine
134422eeaf
enhance: delete streaming-service pipeline in nightly (#36137)
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-09-11 09:53:07 +08:00
yellow-shine
00a55abfa6
enhance: [pipeline] list all status before uninstall helm release (#36042)
https://github.com/milvus-io/milvus/pull/36040

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-09-10 20:09:07 +08:00
yellow-shine
6b10a0ff96
enhance: fix a security vulnerability (#36156)
https://github.com/milvus-io/milvus/pull/36154

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-09-10 19:09:27 +08:00
congqixia
1cd8d1bd80
enhance: [2.4] Use stats Handler to record request/response size metrics (#36107) (#36118)
Cherry-pick from master
pr: #36107 
Related to #36102

This PR use newly added `grpcSizeStatsHandler` to reduce calling
`proto.Size` since the request & response size info is recorded by grpc
framework.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-10 17:13:08 +08:00
yellow-shine
780cd801eb
enhance: add a env (#36143)
[#36142](https://github.com/milvus-io/milvus/pull/36142)

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-09-10 15:19:13 +08:00
sre-ci-robot
e066347194
[automated] Bump milvus version to v2.4.11 (#36141)
Bump milvus version to v2.4.11
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-10 14:31:08 +08:00
nico
33054d5723
test: update pymilvus version and test cases (#36032)
pr: #35867

Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-09-10 10:39:09 +08:00
congqixia
c166253540
fix: [2.4] Make legacy non-lexicographic branch break swtich (#36126)
Cherry-pick from master
pr: #36125
Related to #35941
Previous PR: #36034

This patch makes the switch branching logic correct and make the unit
test work for cases which does not select the whole dataset.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-09 22:49:06 +08:00
wei liu
14fe3213b1
fix: Revert "enhance: avoid the coexistence of the old coordinator and the new node/proxy (#35760)" (#36114)
issue: #36100
pr: #36113
This reverts commit 50ec3dd4db.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-09-09 17:57:06 +08:00
zhenshan.cao
9fe846c9e3
fix: binary arith expression on inverted index (#35945) (#36097)
issue: https://github.com/milvus-io/milvus/issues/35946
pr : https://github.com/milvus-io/milvus/pull/35945

---------

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
Co-authored-by: Jiquan Long <jiquan.long@zilliz.com>
2024-09-09 12:51:06 +08:00
SimFG
d3bf7a2d27
fix: [2.4] delay to start the metric server port (#36085)
- issue: #36083
- pr: #36080
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-09-09 10:11:06 +08:00
jaime
256d4e209f
fix: memory leak in proxy meta cache (#36076)
issue: #36074
pr: #36075

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-09-08 17:49:06 +08:00
zhagnlu
08b9db424b
fix:rename mmap file path to avoid directory conflict (#35810) (#35975)
pr: #35810

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-09-08 16:57:06 +08:00
XuanYang-cn
835c9d5c65
fix: Change l0SegmentsRowCount limits to a reasonable value (#36015)
pr: #36014
See also: #36028

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-09-08 16:55:05 +08:00