congqixia
58c4d061d3
fix: [2.4] Implement singleflight for segcore ChunkCache ( #34250 ) ( #34283 )
...
Cherry-pick from master
pr: #34250
See also #34249
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-02 10:24:08 +08:00
yihao.dai
1b95ee7ae8
enhance: [cherry-pick] Batch pick PRs related to compaction ( #34315 )
...
This PR cherry-picks the following commits related to compaction:
- Use a pool for CompactionExecutor.
https://github.com/milvus-io/milvus/pull/33558
- Move compaction executor to compaction pacakge.
https://github.com/milvus-io/milvus/pull/33778
- Ensure the idempotency of compaction tasks.
https://github.com/milvus-io/milvus/pull/33872
- Add comment for channel cp updater.
https://github.com/milvus-io/milvus/pull/33759
issue: https://github.com/milvus-io/milvus/issues/33182 ,
https://github.com/milvus-io/milvus/issues/32451
pr: https://github.com/milvus-io/milvus/pull/33558 ,
https://github.com/milvus-io/milvus/pull/33778 ,
https://github.com/milvus-io/milvus/pull/33872 ,
https://github.com/milvus-io/milvus/pull/33759
---------
Signed-off-by: coldWater <254244460@qq.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Co-authored-by: coldWater <254244460@qq.com>
2024-07-02 09:54:07 +08:00
cai.zhang
c924b0b502
enhance: [cherry-pick] Refine index code and support analyze data ( #34311 )
...
This PR primary picks up the support analyzing functionality, including
the following commits:
- main functionality: https://github.com/milvus-io/milvus/pull/33651
- refine indexnode code: https://github.com/milvus-io/milvus/pull/33458
- related fixes:
- https://github.com/milvus-io/milvus/pull/33832
- https://github.com/milvus-io/milvus/pull/33161
issue: #30633
master prs: #33651 , #33458 , #33832 , #33161
---------
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
Co-authored-by: chasingegg <chao.gao@zilliz.com>
Co-authored-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
2024-07-02 09:50:39 +08:00
yihao.dai
3c5ad4999e
fix: Reduce duplicate PKs in segcore ( #34267 ) ( #34302 )
...
issue: issue: https://github.com/milvus-io/milvus/issues/34247
pr: https://github.com/milvus-io/milvus/pull/34267
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-01 21:08:07 +08:00
zhenshan.cao
14a11e379c
enhance: Refactor Compaction to enable persistence( #33265 ) ( #34268 )
...
pr : #33265
issue #33586
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-07-01 19:32:07 +08:00
XuanYang-cn
4ebdccd160
fix: LegacyVersionWithoutRPCWatch default value to 2.4.1 ( #34185 )
...
See also: #31933
pr: #34184
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-07-01 18:22:08 +08:00
smellthemoon
a3fdd02586
enhance: do check when add not empty logpath( #33640 ) ( #34212 )
...
pr: #33640
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-07-01 18:10:08 +08:00
smellthemoon
af442b936c
enhance:change wrong log( #33447 ) ( #34213 )
...
pr: #33447
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-07-01 18:02:07 +08:00
smellthemoon
064afc9dcb
enhance: use the only MaxEtcdTxnNum( #33070 ) ( #34215 )
...
pr: #33070
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-07-01 18:00:07 +08:00
wei liu
92b7eebb53
enhance: Skip update index for L0 segment ( #34099 ) ( #34280 )
...
pr: #34280
try to update index for l0 segment, will failed by `index not found`
This PR skip update index for l0 segment
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-01 16:32:07 +08:00
yihao.dai
3af0d91f80
fix: Fix panic due to failed to seek ( #34229 ) ( #34230 )
...
Converting the same msgposition's vchannel to a pchannel multiple times
would result in an invalid pchannel, leading to seek failure and panic.
This PR:
1. Make a copy of msgposition in msgdispatcher.
2. Check if channel is already a pchannel, no further channel conversion
is performed.
issue: https://github.com/milvus-io/milvus/issues/34221
pr: https://github.com/milvus-io/milvus/pull/34229
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-01 16:08:12 +08:00
wei liu
c344083f22
enhance: Optimize grow slice cost during query ( #34254 )
...
issue: #32252
pr: #34253
This PR try to pre-allocate FieldData for Reduce operations in the Query
chain using typeutil.PrepareResultFieldData to avoid the overhead of
dynamically growing the slice during appendFieldData process.
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-01 15:18:11 +08:00
xige-16
06d9d258c4
fix: [cherry-pick]Fix datacoord's properties overwriten ( #34240 )
...
issue: https://github.com/milvus-io/milvus/issues/34144
pr: https://github.com/milvus-io/milvus/pull/34146
/kind bug
Signed-off-by: xige-16 <xige2016@gmail.com>
2024-07-01 13:08:07 +08:00
wei liu
b18de95817
enhance: Avoid assign too much segment/channels to new querynode ( #34096 ) ( #34245 )
...
issue: #34095
pr: #34096
When a new query node comes online, the segment_checker,
channel_checker, and balance_checker simultaneously attempt to allocate
segments to it. If this occurs during the execution of a load task and
the distribution of the new query node hasn't been updated, the query
coordinator may mistakenly view the new query node as empty. As a
result, it assigns segments or channels to it, potentially overloading
the new query node with more segments or channels than expected.
This PR measures the workload of the executing tasks on the target query
node to prevent assigning an excessive number of segments to it.
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-07-01 10:32:06 +08:00
jaime
b37d6fa0f9
enhance: decrease cpu overhead during filter segments on datacoord ( #34231 )
...
issue: https://github.com/milvus-io/milvus/issues/33129
pr: #33130
pr: #33373
---------
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-07-01 10:20:08 +08:00
jaime
0992f10694
enhance: improve check health ( #34265 )
...
issue: https://github.com/milvus-io/milvus/issues/34264
pr: #33800
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-07-01 10:18:07 +08:00
zhagnlu
fc6bd387b8
fix: expr add skip using index while index exists ( #34202 )
...
This PR cherry-pick part from commit:
- enhance: add skip using array index when some situation #33947
- fix: [ut] regex query under unsupported index #34087
pr: #33947 , #34087
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-06-30 20:03:13 +08:00
Bingyi Sun
460815ceab
fix: fix partition loaded num metric ( #33316 ) ( #34195 )
...
issue: https://github.com/milvus-io/milvus/issues/32108
related pr: #33316
Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-06-28 14:58:05 +08:00
cai.zhang
85aa929749
enhance: Set the timeout for SyncSegments based on the number of segments ( #34228 )
...
issue: #32809
master pr: #34226
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-06-28 14:18:06 +08:00
zhuwenxing
9cb3658d74
test: [cherry-pick]remove dup code ( #34243 )
...
pr: https://github.com/milvus-io/milvus/pull/34242
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-06-28 10:44:05 +08:00
sammy.huang
7b4c1a0a96
enhance: [skip e2e] use disk ann when os is ubuntu, rocky or amazon ( #34244 )
...
pr: https://github.com/milvus-io/milvus/pull/34236
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-06-27 20:50:13 +08:00
cai.zhang
1c6e850f73
enhance: [cherry-pick] Periodically synchronize segments to datanode watcher ( #33420 ) ( #34186 )
...
This PR primary picks up the SyncSegments functionality, including the
following commits:
- main functionality: https://github.com/milvus-io/milvus/pull/33420
- related fixes:
- https://github.com/milvus-io/milvus/pull/33664
- https://github.com/milvus-io/milvus/pull/33829
- https://github.com/milvus-io/milvus/pull/34056
- https://github.com/milvus-io/milvus/pull/34156
issue: #32809
master pr: #33420 , #33664 , #33829 , #34056 , #34156
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-06-27 11:24:05 +08:00
cai.zhang
42096a2337
enhance: [cherry-pick] Reduce the frequency of index ralted logs ( #33050 ) ( #34198 )
...
issue: #33001
pr: #33050 , #33212 , #33321
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-06-27 11:08:05 +08:00
congqixia
88766bb714
fix: [2.4] Pass otlpSecure
config when setup segcore tracing ( #34193 ) ( #34210 )
...
Cherry-pick from master
pr: #34193
See also #34192
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-27 10:22:06 +08:00
congqixia
f741bb7526
enhance: [2.4] Avoid merging insert data when buffering insert msgs ( #34205 )
...
Cherry-pick from master
pr: #33526 #33817
See also #33561
This PR:
- Use zero copy when buffering insert messages
- Make `storage.InsertCodec` support serialize multiple insert data
chunk into same batch binlog files
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-27 10:14:05 +08:00
congqixia
aae94d7c40
enhance: [2.4] Unify DeleteLog parsing code ( #34188 )
...
Cherry-pick from master
pr: #34009
See also #33787
The parsing delete log is distributed in lots of places, which is not
recommended and hard to maintain.
This PR abstract common parsing logic into DeleteLog.Parse method to
unify implementation and make it easier to replace json parsing lib.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-27 10:12:13 +08:00
cqy123456
0bd93de627
enhance: [cherry-pick]remove CheckVecIndexWithDataTypeExist function in pkg ( #34104 )
...
issue: https://github.com/milvus-io/milvus/issues/22837
related pr: https://github.com/milvus-io/milvus/pull/34102
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-06-26 21:14:26 +08:00
jaime
7f636dbdf6
enhance: refine error message for invalid limit parameter ( #34179 )
...
pr: #34178
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-06-26 20:46:06 +08:00
congqixia
07a05db51b
fix: [2.4] Wrap init segcore tracing with golang timeout ( #33494 ) ( #34191 )
...
Cherry-pick from master
pr: #33494
See also #33483
Wrap `C.InitTrace` & `C.SetTrace` with timeout preventing otlp
initializtion hangs forever when endpoint is not set correctly
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-26 19:44:05 +08:00
wei liu
18a0efe737
enhance: Avoid search querynode return nil status in response ( #34100 ) ( #34189 )
...
pr: #34100
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-26 18:52:04 +08:00
sre-ci-robot
a9a0981157
[automated] Update cpu Builder image changes ( #34167 )
...
Update cpu Builder image changes
See changes:
2ecfe1599c
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-06-26 17:56:05 +08:00
jaime
6423b6c718
enhance: move rocksmq from internal to pkg ( #34165 )
...
pr: https://github.com/milvus-io/milvus/pull/33881
issue: https://github.com/milvus-io/milvus/issues/33956
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-06-26 13:36:05 +08:00
congqixia
3cf526e0cc
fix: [2.4] Deep copy ImportTask.segmentsInfo to prevent data race ( #34090 ) ( #34126 )
...
Cherry-pick from master
pr: #34090
See also #34089
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-26 11:50:11 +08:00
congqixia
26b2e1d43c
fix: [2.4] Make querycoord panick when rg metastore sync fail ( #34106 ) ( #34127 )
...
Cherry-pick from master
pr: #34106
See also #34047
When `unassignNode` sync resource group with node removed failed
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-26 10:04:03 +08:00
cqy123456
3e51256fb4
enhance: [cherry-pick]update new mmap config parmeters version ( #34145 )
...
issue: https://github.com/milvus-io/milvus/issues/32984
related pr: https://github.com/milvus-io/milvus/pull/34143
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-06-25 21:24:05 +08:00
yihao.dai
b1e74dc7cb
enhance: [cherry-pick] Decouple compaction from shard ( #34157 )
...
This PR cherry-picks the following commits:
- Implement task limit control logic in datanode.
https://github.com/milvus-io/milvus/pull/32881
- Load bf from storage instead of memory during L0 compaction.
https://github.com/milvus-io/milvus/pull/32913
- Remove dependencies on shards (e.g. SyncSegments, injection).
https://github.com/milvus-io/milvus/pull/33138
- Rename Compaction interface to CompactionV2.
https://github.com/milvus-io/milvus/pull/33858
- Remove the unused residual compaction logic.
https://github.com/milvus-io/milvus/pull/33932
issue: https://github.com/milvus-io/milvus/issues/32809
pr: https://github.com/milvus-io/milvus/pull/32881 ,
https://github.com/milvus-io/milvus/pull/32913 ,
https://github.com/milvus-io/milvus/pull/33138 ,
https://github.com/milvus-io/milvus/pull/33858 ,
https://github.com/milvus-io/milvus/pull/33932
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-06-25 20:22:03 +08:00
sammy.huang
2ecfe1599c
[automated] Update cpu Builder image changes ( #34079 )
...
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-06-25 19:02:03 +08:00
yihao.dai
3ae1865ffb
fix: Prevent import from generating orphaned files ( #34070 ) ( #34071 )
...
When import failed, mark the import segment as dropped instead of drop
it directly to prevent generating orphaned files.
issue: https://github.com/milvus-io/milvus/issues/34068
pr: https://github.com/milvus-io/milvus/pull/34070
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-06-25 17:00:04 +08:00
cai.zhang
65050b3117
fix: [pick] Fallback field type when it isn't in request ( #33832 ) ( #34133 )
...
issue: #33432
pr: #33832
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-06-25 14:56:04 +08:00
cqy123456
f5344abdaf
enhance: [cherry-pick]growing segment support mmap ( #34110 )
...
issue: issue: https://github.com/milvus-io/milvus/issues/32984
related pr: https://github.com/milvus-io/milvus/pull/32633 ,
https://github.com/milvus-io/milvus/pull/33951 ,
https://github.com/milvus-io/milvus/pull/33993
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-06-25 14:52:07 +08:00
sammy.huang
bd8ad106b9
enhance: revert dead try on uploading codecov ( #34131 )
...
This reverts commit 5a14f65ee4
.
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-06-25 11:51:35 +08:00
XuanYang-cn
a33b68678d
enhance: [cherry-pick] Move compactor into sub package ( #34098 )
...
This PR consists of the following commits:
- enhance: Tidy compactor and remove dup codes (#32198 )
- fix: Fix l0 compactor may cause DN from OOM (#33554 )
- enhance: Add deltaRowCount in l0 compaction (#33997 )
- enhance: enable stream writer in compactions (#32612 )
- fix: turn on compression on stream writers (#34067 )
- fix: adding blob memory size in binlog serde (#33324 )
See also: #32451 , #33547 , #33998 , #31679
pr: #32198 , #33554 , #33997 , #32612
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Co-authored-by: Ted Xu <ted.xu@zilliz.com>
2024-06-25 11:16:02 +08:00
Patrick Weizhi Xu
1168e8c107
enhance: [2.4] support integral type for MV and skip MV if there is only one category ( #34005 )
...
pr: #33161
issue: #29892
---------
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
2024-06-24 19:12:02 +08:00
GenkenWei
059aaad3bb
fix: update ubuntu base image version ( #33927 )
...
related to #33945
FIX CVEs of milvus base image: LOW: 32, MEDIUM: 50, **Total FIX: 82**
![image](https://github.com/milvus-io/milvus/assets/27683687/020fbb73-9a1f-42cb-8224-a595179b3533 )
![image](https://github.com/milvus-io/milvus/assets/27683687/fef403a5-c658-4ee6-baf4-ace3a0387799 )
Signed-off-by: weizhenkun <zhenkun.wei@qq.com>
Co-authored-by: weizhenkun <zhenkun.wei@qq.com>
2024-06-24 14:16:02 +08:00
yanliang567
59d910320d
test:[cherry-pick]Update tests for range search and add test for query with dup ids ( #34069 )
...
related issue: https://github.com/milvus-io/milvus/issues/33883
pr: #34057
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2024-06-24 11:34:03 +08:00
Jiquan Long
22e6807e9a
feat: support inverted index for array ( #33452 ) ( #34053 )
...
pr: https://github.com/milvus-io/milvus/pull/33184
pr: https://github.com/milvus-io/milvus/pull/33452
pr: https://github.com/milvus-io/milvus/pull/33633
issue: https://github.com/milvus-io/milvus/issues/27704
Co-authored-by: xiaocai2333 <cai.zhang@zilliz.com>
---------
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Co-authored-by: cai.zhang <cai.zhang@zilliz.com>
2024-06-24 10:50:03 +08:00
zhuwenxing
630a726f35
test: refine restful testcases trace ( #34065 )
...
pr: https://github.com/milvus-io/milvus/pull/34066
---------
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-06-24 10:40:03 +08:00
sre-ci-robot
f4debe5e5e
[automated] Update gpu Builder image changes ( #34031 )
...
Update gpu Builder image changes
See changes:
b3d425f50a
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-06-24 10:38:13 +08:00
sre-ci-robot
63c9e6e023
[automated] Update cpu Builder image changes ( #34030 )
...
Update cpu Builder image changes
See changes:
b3d425f50a
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-06-24 10:36:25 +08:00
sammy.huang
9ea4aa9bc0
enhance: get environment variable from .env ( #34080 )
...
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-06-23 09:34:14 +08:00