Commit Graph

272 Commits

Author SHA1 Message Date
Ji Bin
3cd28420f1
Support compile under windows (#15786)
This patch makes compile milvus under windows(MSYS), including:
- some cpp adaptation for compile under msys/gcc-10.3
- install toolchain scripts for setup from MinGW/MSYS `scripts/install_deps_msys.sh`
- adaptation for POSIX API use in golang
  * using gofrs/flock instead of syscall.Flock
  * using x/exp/mmap instead of syscall.Mmap
- introducing github actions for build milvus.exe under windows/MSYS
- rocksdb's patch for MSYS
- adaptation for compile knowhere under windows
- a windows package script for pack zip file, `scripts/package_windows.sh`

issue #7706

Signed-off-by: Ji Bin <matrixji@live.com>
2022-03-17 17:17:22 +08:00
zhenshan.cao
f3eeecf146
Reduce the number of metrics (#16030)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-03-15 21:51:21 +08:00
Xiaofan
c51c8c0a74
Fix get flused segment errror handling (#15155)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-03-15 18:51:21 +08:00
jaime
97b1ed7bca
Remove reader API from Mqstream and replace it with consumer API (#15971)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-03-15 14:45:22 +08:00
jaime
29975a7a26
Remove Consume() API from mqstream interface (#15886)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-03-11 20:09:59 +08:00
groot
89356ebcb9
Modify import rpc interfaces (#16006)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2022-03-11 17:13:59 +08:00
Cai Yudong
3e862ecdfb
Merge msgChannelConfig and knowhereConfig into commonConfig (#15843)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-04 11:17:56 +08:00
jaime
7a3a721380
Reconstruct mqstream module (#15784)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-03-03 21:57:56 +08:00
cai.zhang
9f4c59e621
Add prometheus metrics for RootCoord (#15684)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-03-02 21:11:57 +08:00
guoxiangzhou
f43d96b58d
[skip e2e] Modify code comments according to the naming conventions (#15173)
Signed-off-by: guoxiangzhou <xiangzhou.guo@zilliz.com>
2022-02-09 10:19:56 +08:00
Cai Yudong
1f337891e1
Rename base_param to service_param, rename global_param to component_param (#15463)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-02-08 20:57:47 +08:00
Cai Yudong
f1ea9613ae
Add EtcdConfig and move PulsarConfig/RocksdbConfig/MinioConfig into BaseParamTable (#15434)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-02-07 10:09:45 +08:00
Cai Yudong
4bccc85534
Use MsgChannelConfig in GlobalParams for all components (#15163)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-02-02 00:35:43 +08:00
XuanYang-cn
eef295465a
Fix timetick inconsistency in drop collection (#15408)
When rootcoord drops a collection, it'll produce a `drop-collection DDL` msg
and one last timetick into DML channels of this collection.
So that when DataNode receives this msg, DN can release the resources for the specific collection.

Before this PR, RootCoord produced these two msgs with an older timestamp, generated
before many time-consuming RPCs.

Once these RPCs spend more time than timetick producing interval, the timetick of these 2 msgs are
older to the channel current timestamp, causing in-consistency in time, thus
making msgstream fail to consume the last `drop-collection DDL` msg.

This PR generates a new timestamp for `drop-collection DDL` msg and timetick msg after those time-consuming
RPCs

Fixes: #15406

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-01-28 20:49:41 +08:00
Filipe Caixeta
dee1961b4d
Make SearchResults and QueryResults return collectionID (#15377)
* Make SearchResults and QueryResults return collectionID

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>

* add return collection name from QueryRequest and SearchRequest

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>

* remove comment

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>
2022-01-27 22:55:41 +08:00
Xiaofan
885ecaf222
Refine time sync logic log (#15251)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-01-27 11:25:41 +08:00
xige-16
3a024307f4
Release collection first when drop collection (#15370)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-01-24 21:51:22 +08:00
Cai Yudong
356efee492
Rename timetickSync APIs and variables for better readability (#15264)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-18 14:47:36 +08:00
cai.zhang
f564ea7fc7
RootCoord set healthy state after registered service (#15261)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-01-18 12:09:37 +08:00
Cai Yudong
1b1d4e502b
Remove session from timetickSync (#15255)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-18 00:07:37 +08:00
Xiaofan
f36e02dfbb
Add more log when tt failed (#15227)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-01-15 18:53:34 +08:00
Xiaofan
f617c8887b
Time Tick Failed need log (#15225)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-01-14 23:55:34 +08:00
Cai Yudong
6323907566
Use CommonConfig in GlobalParams for all components (#15106)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-10 19:03:35 +08:00
Cai Yudong
7efb02a4c5
Use PulsarConfig in GlobalParams for all components (#15046)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-09 23:45:33 +08:00
Cai Yudong
f8f61fb116
Use BaseParams etcd configuration for all components (#15012)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-07 16:15:26 +08:00
shaoyue
18d36d78d2
[skip e2e] Add comment for rootCood.Core (#14665)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-12-31 14:23:55 +08:00
cai.zhang
e7e40c2328
RootCoord should get all binlog paths for vector field (#14621)
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2021-12-30 19:39:21 +08:00
Jiquan Long
d5e6adf381
Add log for timetickSync (#14517)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-30 10:32:03 +08:00
Xiaofan
69087ff8dd
Support embedded etcd (#14333)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-12-29 14:35:21 +08:00
Xiaofan
1408926cd9
Remove logs without enough info (#14440)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-12-29 10:06:47 +08:00
edward.zeng
2faf35707e
[skip e2e] Refine rootcoord comment (#14447)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-12-28 19:47:21 +08:00
cxytz01
8b7af673a8
[skip e2e] Grammar correction (#14417)
Signed-off-by: cxytz01 <xueyou.chen@zilliz.com>
2021-12-28 19:24:17 +08:00
cxytz01
7ff9ed33ad
[skip e2e] Grammar correction (#14416)
Signed-off-by: cxytz01 <xueyou.chen@zilliz.com>
2021-12-28 19:21:18 +08:00
cxytz01
0759538855
[skip e2e] Grammar correction (#14415)
Signed-off-by: cxytz01 <xueyou.chen@zilliz.com>
2021-12-28 19:18:20 +08:00
Cai Yudong
30382d8bf9
Let rootcoord share proxy.TimeTickInterval (#14326)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-27 21:38:45 +08:00
Cai Yudong
891c202b73
Use GlobalParamTable for all components (#13885)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-23 18:39:11 +08:00
edward.zeng
f2d25ce338
[skip e2e] Refine rootcoord comment (#14045)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-12-23 14:34:13 +08:00
jaime
9e9475b4fe
[skip e2e] Fix grammar mistake in meta_table (#14017)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Co-authored-by: yun.zhang <yun.zhang@zilliz.com>
2021-12-22 21:31:15 +08:00
Jiquan Long
8a63dba149
Add consistency level field in collection meta (#13766)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-21 19:49:02 +08:00
XuanYang-cn
3c2605f174
[skip e2e]Update license for rc util (#13889)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-21 19:19:21 +08:00
XuanYang-cn
83df76d7af
[skip e2e]Update license for rc timetick (#13888)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-21 18:50:59 +08:00
XuanYang-cn
9fa2d757a2
[skip e2e]Update license for rc timestamp (#13748)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-20 19:01:12 +08:00
XuanYang-cn
907f554a0b
[skip e2e]Update license for rc suffix (#13747)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-20 18:49:06 +08:00
XuanYang-cn
33f326d576
[skip e2e]Update license for rc root_coord (#13746)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-20 17:45:37 +08:00
XuanYang-cn
8f8021eeb8
[skip e2e]Update license for rc proxyclient manager (#13572)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-17 14:23:29 +08:00
XuanYang-cn
67d99490ed
[skip e2e]Update license for rc paramtable (#13571)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-17 14:21:31 +08:00
XuanYang-cn
fc67e4bc93
[skip e2e]Update license for rc proxymanager (#13570)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-17 14:19:36 +08:00
Cai Yudong
dea0e0277c
[skip e2e] Update root_coord imports (#13593)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-17 14:13:16 +08:00
Cai Yudong
807aab3dd8
[skip e2e] Update metrics_info imports (#13591)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-17 14:11:26 +08:00
XuanYang-cn
12173f94f0
[skip ci]Update license for rc meta table (#13498)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-16 10:07:10 +08:00
XuanYang-cn
c544bb21ac
[skip ci]Update license for rc dml channels (#13497)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-16 10:03:23 +08:00
XuanYang-cn
12766540bd
[skip ci]Update license for rc meta snapshot (#13496)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-16 10:01:35 +08:00
xige-16
42ac5f76ed
Add constraints to the combination of load and release (#13110)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-12-15 22:11:09 +08:00
jaime
769b05682a
[skip ci] Fix grammar mistake in suffix_snapshot (#13420)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Co-authored-by: yun.zhang <yun.zhang@zilliz.com>
2021-12-15 12:07:44 +08:00
cai.zhang
9f23fc7f2a
Register the service when the component state is healthy (#13248)
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2021-12-15 11:47:10 +08:00
Cai Yudong
829077ad0c
Optimize reSentDdMsg logic (#13378)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-15 08:59:08 +08:00
Cai Yudong
30e18cb5a7
Optimize rootcoord reSendDdMsg (#13363)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-14 19:15:06 +08:00
Xiangyu Wang
405b3cd932
Use the same lint rules with golint in revive (#13324)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-14 15:31:07 +08:00
Cai Yudong
2b59e15ef4
Use typeutil.RootCoordRole instead of Params.RoleName in rootcoord (#13215)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-13 09:59:27 +08:00
JackLCL
2905182282
[skip ci]Fix error log output format in task.go (#13131)
Signed-off-by: JackLCL <chenglong.li@zilliz.com>
2021-12-10 10:19:10 +08:00
JackLCL
3ddcec79b4
[skip ci]Fix error log output format in root_coord_test.go (#13130)
Signed-off-by: JackLCL <chenglong.li@zilliz.com>
2021-12-10 10:17:30 +08:00
cai.zhang
342200ce13
Estimate the memory size of the index before building the index (#12973)
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2021-12-09 14:19:40 +08:00
XuanYang-cn
a9a332dbcf
Fix empty segment compact and load (#12710)
1. Fix compaction save empty segment bug
2. Fix load empty segment bug
3. Add UT for dmlchannels to 100%

Resolves: #12450

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-12-09 11:03:08 +08:00
congqixia
c289a19fb8
Remove log string concat in root_coord.go (#12932)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-08 14:23:05 +08:00
congqixia
e4de86ba42
Update rootcoord state to unhealthy before stopping (#12845)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-07 18:39:03 +08:00
Bingyi Sun
92eff1565c
Fix unlocked mutex in rootcoord (#12772)
issue: #12297
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2021-12-06 17:25:35 +08:00
Cai Yudong
1a806a174a
Support load collection with multiple vector column (#12630)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-03 11:29:33 +08:00
congqixia
9af7e179f2
Fix zero length slice declaration in timeticksync.go (#12372)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-29 20:21:41 +08:00
Bingyi Sun
a05a74fca2
Improve proxy manager in rootcoord (#12303)
issue: #11275
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
2021-11-29 17:33:41 +08:00
Cai Yudong
cbbeb2a383
Add debug log when proxy idle for a long time (#12319)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-27 13:57:16 +08:00
Cai Yudong
6188ac280b
Fix drop alias error (#12281)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-25 18:03:17 +08:00
Cai Yudong
858e95f377
Move dmlChannel and deltaChannel into timeticksync (#12254)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-25 10:07:15 +08:00
dragondriver
6c4c0ef6b5
Add more deploy metrics (#12248)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-24 15:43:15 +08:00
Cai Yudong
1f27eb604e
Remove all index when drop collection (#12227)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-23 23:01:15 +08:00
congqixia
4121e31df1
Send SIGINT to runner goroutine after etcd disconnects (#12163)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-22 16:23:17 +08:00
Cai Yudong
99b3c56b3e
Update rootcoord debug log (#12160)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-22 16:01:14 +08:00
Cai Yudong
d4c297b1a8
Enhance dml channel operations (#12143)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-21 21:33:13 +08:00
dragondriver
ee0f753f7a
Fix datarace between GetComponentStates and Register (#11935)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-19 13:57:12 +08:00
Cai Yudong
074687e32e
Unify rootcoord debug log (#12080)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-19 12:11:12 +08:00
congqixia
27715c15f4
Fix 0 len slice declaration for dml_channels.go (#12094)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-18 22:33:26 +08:00
congqixia
5edbb82610
Add session revoke (#11908)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-11-16 22:31:14 +08:00
Cai Yudong
b0f268e087
Add more debug log for proxy registry in rootcoord (#11899)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-16 19:21:49 +08:00
Xiangyu Wang
12f50cb22c
[skip ci]Update OWNERS files (#11898)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-16 15:41:11 +08:00
Cai Yudong
29e9adc7be
Fix golint warnings for rootcoord (#11872)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-16 14:27:11 +08:00
Cai Yudong
173e7b3808
Fix golint warnings for rootcoord/root_coord.go (#11871)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-16 14:25:17 +08:00
Cai Yudong
959d8c2ce1
Fix golint warnings for rootcoord/meta_table.go (#11870)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-16 14:19:20 +08:00
jaime
3a9d6ee070
[skip ci] Add a log (#11729)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Co-authored-by: yun.zhang <yun.zhang@zilliz.com>
2021-11-15 19:26:49 +08:00
Xiaofan
3cd47cd89e
Remove common.yaml and component.yaml (#11662)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-11-12 18:53:11 +08:00
godchen
5357e301f4
Fix retrieve search error (#11501)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-11 00:54:45 +08:00
Xiaofan
5f08b67156
Move node.yaml to component.yaml (#11363)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-11-10 14:27:37 +08:00
godchen
639800241d
Make flow graph for delta channel (#11379)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-09 09:27:04 +08:00
zhenshan.cao
0699176d24
[skip ci]Fix golint error in rootcoord (#11352)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-11-05 23:06:58 +08:00
Cai Yudong
a2ad88237d
Add deltaChannels in rootcoord core (#11097)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-03 21:04:14 +08:00
Cai Yudong
628a3274bf
Use lazy mode to set dml msgstream as producer (#10993)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-03 20:18:48 +08:00
Xiangyu Wang
54be3c15bf
Improve error message in rootcoord (#11071)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-02 16:18:36 +08:00
Xiangyu Wang
260c0597cb
Improve error message in rootcoord (#11070)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-02 16:16:43 +08:00
Xiangyu Wang
394e8ad634
Improve error message in rootcoord (#11072)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-02 16:14:36 +08:00
Cai Yudong
66b9684fe5
Update ListCollectionPhysicalChannels and ListCollectionVirtualChannels (#11007)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-02 15:50:30 +08:00
Xiangyu Wang
53b6b8d0fb
Improve error message in rootcoord (#10876)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-01 16:40:10 +08:00
Xiangyu Wang
07818ec26a
Improve error message in rootcoord (#10875)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-01 16:38:06 +08:00