congqixia
8d3685fadf
enhance: [2.4] Print log only when rate limit updates ( #35806 ) ( #35816 )
...
Cherry-pick from master
pr: #35806
The debug log for "RateLimiter register for rateType" is too frequent
and in e2e cases, the may print 18M times in one run.
This PR make the log be printed only when rate limit is updated.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-29 19:09:01 +08:00
yihao.dai
a1d39326b8
fix: Fix arrow go client ( #35819 ) ( #35820 )
...
issue: https://github.com/milvus-io/milvus/issues/35662
pr: https://github.com/milvus-io/milvus/pull/35819
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-08-29 17:13:00 +08:00
congqixia
fedf3a7fe1
enhance: Bump milvus & proto version to v2.4.10 ( #35798 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-29 14:55:01 +08:00
Zhen Ye
00202b0d7e
enhance: add skip 3rdparty env var ( #35748 )
...
issue: #35611
pr: #35736
- call `conan install` is too slow for developer, add option to skip it.
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-29 14:23:01 +08:00
Patrick Weizhi Xu
5da64f6d5a
feat: [2.4] support range search pagination retains order ( #35739 )
...
issue: https://github.com/milvus-io/milvus/issues/35464
pr: https://github.com/milvus-io/milvus/pull/35738
2024-08-29 14:07:01 +08:00
wei liu
50ec3dd4db
enhance: avoid the coexistence of the old coordinator and the new node/proxy ( #35760 )
...
issue: #35719
pr: #35720
In standalone mode, block the start process until the new coordinator is
active to avoid the coexistence of the old coordinator and the new
node/proxy
1. In the start/restart process, the new coordinator will become active
immediately and will not be blocked
2. In the rolling upgrade process, the new coordinator will not be
active until the old coordinator is down, and it will be blocked
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-08-29 12:33:01 +08:00
congqixia
8928c9d570
enhance: [2.4] Change frequent balancer debug log to rated one ( #35749 ) ( #35796 )
...
Cherry-pick from master
pr: #35749
"skip balance" log is too frequent in debug level. This PR changes it
into rated on.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-29 12:31:00 +08:00
jaime
2fc111eb10
enhance: set database properties to restrict read access ( #35754 )
...
issue: #35744
pr: #35745
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-08-29 11:41:01 +08:00
yellow-shine
46a8b07bc4
enhance: show pod status and delete pvc during pipeline dear down stage ( #35785 )
...
https://github.com/milvus-io/milvus/pull/35783
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-29 09:59:00 +08:00
yellow-shine
2794ebdc45
enhance: [2.4] fix new nightly pipeline ( #35750 )
...
https://github.com/milvus-io/milvus/pull/35747
https://github.com/milvus-io/milvus/issues/35704
---------
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-28 21:43:00 +08:00
congqixia
21454163bb
fix: [2.4] Check response size before add to counter ( #35779 )
...
Cherry-pick from master
pr: #35778
Related to #35767
prometheus counter cannot add negative value
when response is not written(say timeout/network broken) panicking may
happen if not check
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-28 20:01:01 +08:00
nico
498c9470de
test: update test cases ( #35718 )
...
pr: #35640
Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-08-28 19:23:01 +08:00
Zhen Ye
e25d1ef63c
fix: wrong construction in evalctx ( #35773 )
...
issue: #35771
pr: #35772
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-28 18:37:01 +08:00
congqixia
12575885d3
enhance: [2.4] Add skip load validation for create collection task ( #35761 )
...
Cherry-pick from master
pr: #35737
Related to #35415
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-28 18:25:00 +08:00
yellow-shine
e331288b78
enhance: [skip e2e] Fix test script always skip pip install ( #35775 )
...
https://github.com/milvus-io/milvus/pull/35766
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-28 17:05:06 +08:00
foxspy
93b118946c
feat: [2.4] Encode traceID and spanID as hex string & upgrade knowhere version ( #35568 )
...
Cherry-pick and upgrade knowhere version
issue: https://github.com/zilliztech/knowhere/issues/714
pr: #34807
knowhere release notes:
https://github.com/zilliztech/knowhere/releases/tag/v2.3.8
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
Co-authored-by: Cai Yudong <yudong.cai@zilliz.com>
2024-08-28 17:03:00 +08:00
jaime
c75f556769
fix: inconsistent meta view causes rate limit invalid ( #35664 )
...
issue: #35663
pr: #35665
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-08-28 11:21:04 +08:00
yihao.dai
8e6ec58652
fix: Fix rate wasn't limited to the expected value ( #35699 ) ( #35700 )
...
Each time the rate is reset, the token bucket is fully refilled, causing
the rate wasn't limited to the expected value. This PR addresses the
issue by preventing the token reset.
issue: https://github.com/milvus-io/milvus/issues/35675 ,
https://github.com/milvus-io/milvus/issues/35702
pr: https://github.com/milvus-io/milvus/pull/35699
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-08-28 10:29:00 +08:00
jaime
eecc598786
fix: mistaken deletions may occur during GC channel checkpoints ( #35708 )
...
issue: #35706
pr: #35707
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-08-28 10:11:05 +08:00
Zhen Ye
a4533f1b8a
enhance: optimize milvus core building ( #35660 )
...
issue: #35549,#35611,#35633
pr: #35610
- remove milvus_segcore milvus_indexbuilder..., add libmilvus_core
- core building only link once
- move opendal compilation into cmake
- fix odr
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-27 18:55:00 +08:00
yihao.dai
be17cf6ff1
fix: Fix panic due to empty candidate import segments ( #35673 ) ( #35674 )
...
issue: https://github.com/milvus-io/milvus/issues/35662
pr: https://github.com/milvus-io/milvus/pull/35673
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-08-27 17:34:59 +08:00
Zhen Ye
69e8d5ef46
fix: munmap deallocate too much memory ( #35726 )
...
issue: #35693
pr: #35725
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-27 17:22:59 +08:00
SimFG
fc324b4254
feat: [2.4] add the rbac msg and send them to the replicate channel ( #35562 )
...
- issue: #35391
- pr: #35392
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-08-27 14:45:00 +08:00
yellow-shine
03627150d3
enhance new jenkinsfile for nightly and e2e ( #35715 )
...
https://github.com/milvus-io/milvus/pull/35672
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-27 14:23:05 +08:00
congqixia
ab261d0f8b
feat: [2.4] Support field partial load collection ( #35416 ) ( #35696 )
...
Cherry-pick from master
pr: #35416
Related to #35415
---------
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-27 14:07:00 +08:00
yellow-shine
33fbc1fb96
enhance: turnoff USE_ASAN in ci ( #35723 )
...
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-27 14:01:11 +08:00
XuanYang-cn
f2caecc577
fix: [cp]Fill nil schema so that Milvus can watch channel for those upgraded from 2.2 to 2.4 ( #35695 )
...
See also: #35701
pr: #35694
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-08-27 10:38:59 +08:00
XuanYang-cn
ff68eb53d7
fix: [skip e2e]unstable l0 it ( #35613 )
...
See also: #35617
pr: #35612
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-08-26 18:53:04 +08:00
Zhen Ye
7062e6fcbf
enhance: enable asan for milvus ( #35687 )
...
issue: #35626
pr: #35627
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-26 09:54:58 +08:00
Xiaofan
7269d5eda2
enhance: [2.4] reduce the log level of frequent log ( #35653 )
...
pr: #35651
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
2024-08-25 17:48:57 +08:00
jaime
5c1a380d9d
fix: the incorrect number of partitions in rootcoord meta ( #35601 )
...
pr: #35600
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-08-25 16:30:59 +08:00
Patrick Weizhi Xu
4b5bd07971
enhance: [2.4] enable MV on binary vectors ( #35669 )
...
pr: #35668
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
(cherry picked from commit 5404228fca58d4ad4a788ec6d58d2693019132b6)
2024-08-25 16:27:08 +08:00
wei liu
35d2f9b210
fix: Fix index memory estimation ( #35225 ) ( #35670 )
...
issue: https://github.com/milvus-io/milvus/issues/35229
pr: #32525
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: Bingyi Sun <sunbingyi1992@gmail.com>
2024-08-24 10:28:57 +08:00
XuanYang-cn
81c4cae2c1
enhance: Enable to write multiple segments in mix compactor ( #35648 )
...
Prevent segments to be written larger than maxSize * expansionRate
See also: #35584
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-08-24 10:00:58 +08:00
XuanYang-cn
eb18e114a1
fix: Clear channelcp meta and metrics ASAP ( #35659 )
...
See also: #35588
pr: #35658
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-08-24 09:28:58 +08:00
nish112022
79d093257c
fix: Added check for validating varchar,array max length ( #35499 ) ( #35581 )
...
issue : https://github.com/milvus-io/milvus/issues/34150
pr: https://github.com/milvus-io/milvus/pull/35499
This is for numpy,parquet,json readers.
cherry-picked from master branch
Signed-off-by: Nischay Yadav <nischay.yadav@ibm.com>
2024-08-23 17:14:58 +08:00
congqixia
f3fb37655b
fix: [2.4] Use correct release func when datanode unwatch a channel ( #35657 )
...
Cherry-pick from master
pr: #35655
See also #35654
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-23 14:09:03 +08:00
Gao
1687d64c46
enhance: [2.4] add hit segment num metrics for queryHook ( #35619 )
...
issue: #35576
pr: #35577
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-08-23 12:49:02 +08:00
SimFG
5b5119a51f
feat: [2.4] provide more general configuration to control mmap behavior ( #35609 )
...
- issue: #35273
- pr: #35359
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-08-23 12:35:02 +08:00
zhagnlu
90a5bafe17
fix:fix bitmap log error ( #35644 )
...
pr: #32902
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-08-23 08:56:58 +08:00
sre-ci-robot
216f33c529
[automated] Update Pytest image changes ( #35639 )
...
Update Pytest image changes
See changes:
d7d4525c2esre-ci-robot@users.noreply.github.com
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-22 19:18:58 +08:00
wei liu
421a00bfe8
enhance: Refresh proxy cache after restore rbac meta ( #35636 )
...
issue: #35443
pr: #35635
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-08-22 19:09:01 +08:00
congqixia
9c67965d6c
fix: [2.4] Re-read value after once initialization ( #35643 )
...
Cherry-pick from master
pr: #35642
Related to #35641
See also #35271
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-22 16:30:57 +08:00
wei liu
e014ad9280
fix: fix dynamic update config doesn't works for some param ( #35572 ) ( #35637 )
...
issue: #35570
pr: #35572
milvus support config cache to spped up config access, but only evict
param's cache when param has been updated. but milvus's param may rely
on other param's value, let's say ParamsA relys on paramsB, when paramsB
updated, it will evict paramB's cache, but the paramA's cache still keep
the old value.
This PR evict all config cache to solve the above issue, cause dynamic
update config won't be much frequetly.
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-08-22 16:00:58 +08:00
zhagnlu
946881e123
enhance: optimize retrieve on dynamic field ( #35602 )
...
pr: #35580
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
Co-authored-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-08-22 14:18:57 +08:00
yanliang567
d7d4525c2e
test:[cherry-pick] Add upsert with autoid and update init collection method ( #35624 )
...
Related issue: https://github.com/milvus-io/milvus/issues/32653
pr: #35596
---------
Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2024-08-22 14:00:57 +08:00
wei liu
e2542a1bf5
enhance: Update protobuf-go to protobuf-go v2 ( #34394 ) ( #35555 )
...
issue: #34252
pr: #34394 #35072 #35084
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-21 18:50:58 +08:00
yellow-shine
bfd8758152
feat: [skip e2e] effective way to use cache ( #35620 )
...
issue: https://github.com/milvus-io/milvus/issues/34876
https://github.com/milvus-io/milvus/pull/35598
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-21 18:44:57 +08:00
congqixia
f108ce0fc5
fix: [2.4] Match int8_t and int16_t in Array::get_data ( #35579 ) ( #35597 )
...
Cherry-pick from master
pr: #35579
Related to #35578
Previously int16/int8 bitmap index may read int32 array as int16, which
may cause build index with half of the data(if array is full) and half
zeros. This causes BITMAP index lost information.
This PR matches int8_t & int16_t while `get_data` when building index.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-21 17:47:01 +08:00
wei liu
4bf4cbad85
enhance: Mark query node as read only after suspend ( #35492 ) ( #35586 )
...
issue: #34985 #35493
pr: #35492
after querynode has been suspended, it's not allow to load
segment/channel on it, which means the node is read only. to be
compatible with resource group design, after query node has been
suspend, we remove it from it's original resource group, make it a read
only query node in replica. then two things will happens:
1. it's original resource group will be lacking of query nodes, query
coord will assign new node to it.
2. querycoord will try to move out all segments/channels after querynode
has been suspended
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-08-20 19:00:56 +08:00
