Commit Graph

1394 Commits

Author SHA1 Message Date
yukun
671b2737d2
Remove RetrieveRequest and RetrieveTask (#6848)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-08-16 17:06:10 +08:00
xige-16
b035ec5c7b
Enable search when querynode only load segment (#7104)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-16 12:24:09 +08:00
sunby
9551dc3b7e
Fix segment auto flush bug (#7085)
issue: #7084
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-16 11:00:09 +08:00
Cai Yudong
e771bda92f
optimize retrieve output vector code structure (#7102)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-14 11:18:10 +08:00
cai.zhang
382fa6f274
IndexNode dose not need to wait for IndexCoord to start to comlete (#7074)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-08-13 18:12:08 +08:00
XuanYang-cn
86ca96a02e
Fix master branch unittest error (#7083)
Resolves: #7080

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 14:00:14 +08:00
XuanYang-cn
6c5be83ea1
Refactor NewEtcdKV API (#7075)
This PR mainly did the following 3 things:

- Refactor NewEtcdKV API
- Add unittests for `kv/etcd/`, raise the coverage
up to 94%
- Correct some APIs from version to revision

The old NewEtcdKV() API took `clientv3.Client` as
one of the input, making everyone who using this API
had to create a new `clientv3.Client`. So there're a lot
of repeated codes everywhere.

Meanwhile, someplace didn't even check whether the
`clientv3.New()` returned error or not, and the old API
also didn't check whether the clientv3.Client was Nil.
This caused issue#6955.

Ectd's version and revision have nothing alike, they
represent different concepts, but our APIs kind of
mixed them all up. So I correct those APIs' names.

Resolves: #6955

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 11:04:09 +08:00
congqixia
e1b3273d1c
Add Datanode watch etcd channel (#6965)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-13 10:50:09 +08:00
sunby
5c383d1d02
Add a checker to listen for the timetick. (#7061)
issue: #7060
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-12 19:58:08 +08:00
Xiangyu Wang
5e78fd6a97
[skip ci]Update approvers (#7063)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-08-12 19:36:09 +08:00
Cai Yudong
6c75301c70
optimize search reduce logic (#7066)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-12 18:00:11 +08:00
dragondriver
b3f10ae5cc
Fix 6990, enhance the log when parsing grpc recv/send parameters (#6993)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-12 16:16:09 +08:00
congqixia
3f21e3d062
Fix querynode tt producer leak (#7059)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-12 14:16:08 +08:00
bigsheeper
b9d3897deb
Return error when any failed detected in loadSegment (#7005)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-12 14:14:08 +08:00
Cai Yudong
85ea051ddc
change growing segment default value to -1 (#7054)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-12 12:32:07 +08:00
sunby
31182e52a9
Fix expire allocation bug (#7053)
issue: #7052
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-12 10:48:08 +08:00
godchen
7fc7623b92
Add vector data memroy existence check (#7044)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-11 19:50:09 +08:00
XuanYang-cn
9d81a90402
Fix mem leak of flush cache in DataNode (#6862)
Resolves: #6858

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-11 14:24:09 +08:00
groot
bdb8396e74
Fix CalcDistance wrong result when fetting vectors from collection (#6976)
* Fix CalcDistance wrong result when fetting vectors from collection

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* Fix CalcDistance wrong result when fetting vectors from collection

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* preset capacity

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* typo

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* error check

Signed-off-by: yhmo <yihua.mo@zilliz.com>

* code lint

Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-08-10 11:59:28 +08:00
godchen
7557616fea
Change client timeout (#6982)
* Change client timeout

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change timeout

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change timeout time

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix conflicts

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix ut

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove ut

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-08-06 14:09:26 +08:00
congqixia
9eb35996b5
Fix pulsar consumer goroutine leakage (#7004)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-06 09:45:24 +08:00
sunby
454620dfaa
Add unit test in datacoord (#6985)
issue: #6984
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-08-04 16:59:25 +08:00
dragondriver
ad77a6e0d4
Fix #6859, increase the MaxCallRecvMsgSize and MaxCallSendMsgSize of grpc client (#6861)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-04 13:03:24 +08:00
bigsheeper
07cc449fbf
Fix data race in flow graph (#6946)
* Fix data race in flow graph

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* add cancel func to flowgraph

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-03 22:43:25 +08:00
xige-16
c8a1f780c1
Use proto marshal instead of MarshalTextString in querycoord (#6958)
* use proto marshal instead of marshalToText

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* log error

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* don't retry after init meta/cluster/scheduler failed

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix return err

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* log inconsistent task info

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-03 22:03:25 +08:00
bigsheeper
4123deef9e
Return error message in grpc.LoadSegment in query node (#6908)
* return load error

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* init streaming meta in loadSegment

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* fix excluded init

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* improve impl

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-08-03 22:01:27 +08:00
xige-16
09199170a4
sync call querycoord releaseXXXX (#6978)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-03 21:47:24 +08:00
Xiaofan
aba234fa3f
Fix Msgstream exponential retry (#6807)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-08-03 10:39:24 +08:00
dragondriver
d2767f920c
Fix index parameters check of RHNSWPQ (#6950)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-03 10:25:25 +08:00
XuanYang-cn
47df4a2e57
Fix DataNode BackGroudGC problem (#6551)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-03 09:59:24 +08:00
xige-16
87c5a49d9a
Refactor showCollection/showPartition to get load state in memory (#6935)
* refactor showCollection/showPartition to get load state in memory

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update milvus.proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* add show result log to debug

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix wrong err message

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update pymilvus-orm version

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix repeated load error

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* update proto

Signed-off-by: xige-16 <xi.ge@zilliz.com>

* fix status nil error

Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-02 22:39:25 +08:00
congqixia
4d5eeb2890
Fix minio object leaking goroutine (#6944)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-02 15:25:24 +08:00
Cai Yudong
fe50f97726
Use id to tell search result validation in proxy reduce stage (#6905)
* use id to tell search result validation

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* enable test_search_binary_hamming_flat_index

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* code optimize

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix merge retrieve result issue

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-02 10:25:49 +08:00
bigsheeper
e8ea8b51d5
improve query node log (#6897)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-31 10:47:22 +08:00
bigsheeper
7307332fab
Add nil check (#6832)
* add nil check

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* use grpc functions

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* use grpc functions

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

* fix indexCoord crash

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-29 20:11:23 +08:00
bigsheeper
eee0f1e077
Add mutex for segment of segCore in querynode (#6870)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-29 16:03:22 +08:00
cai.zhang
d51fec6678
Enhance log when create index failed (#6871)
* Enhance log when create index failed

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Fix bug for repeatedly drop index

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-29 14:47:22 +08:00
godchen
61786f769c
Add file exist check (#6840)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-07-28 16:31:22 +08:00
sunby
23bffe399d
Enhance log print in data coordinator (#6681)
issue: #6680
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-28 11:43:22 +08:00
zhenshan.cao
8a1a841011
FixBug: Incorrect handling of time synchronization (#6814)
* FixBug: proxy send wrong sync timetick and DataCoord did not filter channel

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-27 14:34:48 +08:00
dragondriver
3cc8ee298e
Filter NaN when reducing search results (#6806)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-27 10:19:21 +08:00
xaxys
e43b43e7d8
Refactor RangeExpr & CompareExpr (#6786)
* Changed `RangeExpr` proto to `UnaryRangeExpr` & `BinaryRangeExpr`
Several unit test unpassed.

Signed-off-by: xaxys <tpnnghd@163.com>

* Fix bugs to pass unit test. Fix format.

Signed-off-by: xaxys <tpnnghd@163.com>

* Remove debug information.

Signed-off-by: xaxys <tpnnghd@163.com>

* Fix format.
Remove debug information.
Unify variable name.
Add error information.
Remove `CompareExpr` test in `test_c_api.cpp`.

Signed-off-by: xaxys <tpnnghd@163.com>

* Fix code format.

Signed-off-by: xaxys <tpnnghd@163.com>

* Update `Plan.cpp`.

Signed-off-by: xaxys <tpnnghd@163.com>
2021-07-25 10:23:19 +08:00
zhenshan.cao
2962d31a5f
Fixbug: segment allocate but return value incorrect (#6788)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-07-24 20:49:20 +08:00
godchen
db94d7771f
Read vector from disk (#6707)
* Read vector from disk

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* go fmt

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix git action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix test error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix caculate error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change var name

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix len error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* remove unused code

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change bytes to float method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* change float to bytes method

Signed-off-by: godchen <qingxiang.chen@zilliz.com>

* fix action error

Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-07-24 09:25:22 +08:00
sunby
aa20d88f6f
Fix datacoord stop bug (#6642)
issue: #6641
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-24 09:25:14 +08:00
sunby
fc74a0f578
Auto create new segments when allocating rows more than (#6665)
max number of rows per segment

If user insert too much rows in a request. Now we will return a failed
response. Maybe auto creating new segments to hold that much rows is a
better way.

issue: #6664
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-23 21:58:33 +08:00
sunby
63387c83ef
Remove collection check when saving binlog (#6658)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-07-23 21:23:22 +08:00
dragondriver
2821c08560
Add unittests for metric_type: tanimoto (#6773)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-23 20:59:33 +08:00
dragondriver
cf8e9d52b1
Reduce the log of proxy (#6766)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-23 20:33:34 +08:00
bigsheeper
21bc5810c0
remove redundant log of query node (#6768)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-07-23 20:09:33 +08:00