congqixia
6b348e4e91
enhance: [2.4] Add go-deadlock as unittest only dependency ( #33063 ) ( #34322 )
...
Cherry-pick from master
pr: #33063
See also #33062
This PR:
- Add lock.RWMutex & lock.Mutex alias to switch implementation based on
build flags
- When build flags has test in it, use go-deadlock to detect possible
deadlocks
- Replace all sync.RWMutex & sync.Mutex in datacoord pkg
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-07-02 18:48:10 +08:00
wayblink
99586066f5
feat: [cherry-pick] Major compaction ( #34326 )
...
This PR cherry-picks the following commits:
fix: speed up segment lookup via channel name in datacoord (#33530 )
needed by the next commit
feat: Major compaction (#33620 )
issue: #30633
pr: #33620
---------
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: yiwangdr <80064917+yiwangdr@users.noreply.github.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>
2024-07-02 18:29:01 +08:00
aoiasd
bc8ca593bd
enhance: [Cherry-Pick] Update access log ( #34295 )
...
Support restful api,print with consistency level and add new write
cache.
relate: https://github.com/milvus-io/milvus/issues/31823
pr: https://github.com/milvus-io/milvus/pull/33155
https://github.com/milvus-io/milvus/pull/33503
https://github.com/milvus-io/milvus/pull/32213
---------
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-07-02 15:30:15 +08:00
cai.zhang
c924b0b502
enhance: [cherry-pick] Refine index code and support analyze data ( #34311 )
...
This PR primary picks up the support analyzing functionality, including
the following commits:
- main functionality: https://github.com/milvus-io/milvus/pull/33651
- refine indexnode code: https://github.com/milvus-io/milvus/pull/33458
- related fixes:
- https://github.com/milvus-io/milvus/pull/33832
- https://github.com/milvus-io/milvus/pull/33161
issue: #30633
master prs: #33651 , #33458 , #33832 , #33161
---------
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
Co-authored-by: chasingegg <chao.gao@zilliz.com>
Co-authored-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
2024-07-02 09:50:39 +08:00
zhenshan.cao
14a11e379c
enhance: Refactor Compaction to enable persistence( #33265 ) ( #34268 )
...
pr : #33265
issue #33586
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-07-01 19:32:07 +08:00
XuanYang-cn
4ebdccd160
fix: LegacyVersionWithoutRPCWatch default value to 2.4.1 ( #34185 )
...
See also: #31933
pr: #34184
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-07-01 18:22:08 +08:00
smellthemoon
064afc9dcb
enhance: use the only MaxEtcdTxnNum( #33070 ) ( #34215 )
...
pr: #33070
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-07-01 18:00:07 +08:00
yihao.dai
3af0d91f80
fix: Fix panic due to failed to seek ( #34229 ) ( #34230 )
...
Converting the same msgposition's vchannel to a pchannel multiple times
would result in an invalid pchannel, leading to seek failure and panic.
This PR:
1. Make a copy of msgposition in msgdispatcher.
2. Check if channel is already a pchannel, no further channel conversion
is performed.
issue: https://github.com/milvus-io/milvus/issues/34221
pr: https://github.com/milvus-io/milvus/pull/34229
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-01 16:08:12 +08:00
jaime
0992f10694
enhance: improve check health ( #34265 )
...
issue: https://github.com/milvus-io/milvus/issues/34264
pr: #33800
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-07-01 10:18:07 +08:00
cai.zhang
85aa929749
enhance: Set the timeout for SyncSegments based on the number of segments ( #34228 )
...
issue: #32809
master pr: #34226
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-06-28 14:18:06 +08:00
cai.zhang
1c6e850f73
enhance: [cherry-pick] Periodically synchronize segments to datanode watcher ( #33420 ) ( #34186 )
...
This PR primary picks up the SyncSegments functionality, including the
following commits:
- main functionality: https://github.com/milvus-io/milvus/pull/33420
- related fixes:
- https://github.com/milvus-io/milvus/pull/33664
- https://github.com/milvus-io/milvus/pull/33829
- https://github.com/milvus-io/milvus/pull/34056
- https://github.com/milvus-io/milvus/pull/34156
issue: #32809
master pr: #33420 , #33664 , #33829 , #34056 , #34156
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-06-27 11:24:05 +08:00
cqy123456
0bd93de627
enhance: [cherry-pick]remove CheckVecIndexWithDataTypeExist function in pkg ( #34104 )
...
issue: https://github.com/milvus-io/milvus/issues/22837
related pr: https://github.com/milvus-io/milvus/pull/34102
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-06-26 21:14:26 +08:00
congqixia
07a05db51b
fix: [2.4] Wrap init segcore tracing with golang timeout ( #33494 ) ( #34191 )
...
Cherry-pick from master
pr: #33494
See also #33483
Wrap `C.InitTrace` & `C.SetTrace` with timeout preventing otlp
initializtion hangs forever when endpoint is not set correctly
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-26 19:44:05 +08:00
jaime
6423b6c718
enhance: move rocksmq from internal to pkg ( #34165 )
...
pr: https://github.com/milvus-io/milvus/pull/33881
issue: https://github.com/milvus-io/milvus/issues/33956
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-06-26 13:36:05 +08:00
cqy123456
3e51256fb4
enhance: [cherry-pick]update new mmap config parmeters version ( #34145 )
...
issue: https://github.com/milvus-io/milvus/issues/32984
related pr: https://github.com/milvus-io/milvus/pull/34143
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-06-25 21:24:05 +08:00
yihao.dai
b1e74dc7cb
enhance: [cherry-pick] Decouple compaction from shard ( #34157 )
...
This PR cherry-picks the following commits:
- Implement task limit control logic in datanode.
https://github.com/milvus-io/milvus/pull/32881
- Load bf from storage instead of memory during L0 compaction.
https://github.com/milvus-io/milvus/pull/32913
- Remove dependencies on shards (e.g. SyncSegments, injection).
https://github.com/milvus-io/milvus/pull/33138
- Rename Compaction interface to CompactionV2.
https://github.com/milvus-io/milvus/pull/33858
- Remove the unused residual compaction logic.
https://github.com/milvus-io/milvus/pull/33932
issue: https://github.com/milvus-io/milvus/issues/32809
pr: https://github.com/milvus-io/milvus/pull/32881 ,
https://github.com/milvus-io/milvus/pull/32913 ,
https://github.com/milvus-io/milvus/pull/33138 ,
https://github.com/milvus-io/milvus/pull/33858 ,
https://github.com/milvus-io/milvus/pull/33932
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-06-25 20:22:03 +08:00
cqy123456
f5344abdaf
enhance: [cherry-pick]growing segment support mmap ( #34110 )
...
issue: issue: https://github.com/milvus-io/milvus/issues/32984
related pr: https://github.com/milvus-io/milvus/pull/32633 ,
https://github.com/milvus-io/milvus/pull/33951 ,
https://github.com/milvus-io/milvus/pull/33993
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-06-25 14:52:07 +08:00
Patrick Weizhi Xu
1168e8c107
enhance: [2.4] support integral type for MV and skip MV if there is only one category ( #34005 )
...
pr: #33161
issue: #29892
---------
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
2024-06-24 19:12:02 +08:00
Jiquan Long
22e6807e9a
feat: support inverted index for array ( #33452 ) ( #34053 )
...
pr: https://github.com/milvus-io/milvus/pull/33184
pr: https://github.com/milvus-io/milvus/pull/33452
pr: https://github.com/milvus-io/milvus/pull/33633
issue: https://github.com/milvus-io/milvus/issues/27704
Co-authored-by: xiaocai2333 <cai.zhang@zilliz.com>
---------
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Co-authored-by: cai.zhang <cai.zhang@zilliz.com>
2024-06-24 10:50:03 +08:00
wei liu
061a00c58f
enhance: Enable database level replica num and resource groups for loading collection ( #33052 ) ( #33981 )
...
pr: #33052
issue: #30040
This PR introduce two database level props:
1. database.replica.number
2. database.resource_groups
User can set those two database props by AlterDatabase API, then can
load collection without specified replica_num and resource groups. then
it will use database level load param when try to load collections.
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-21 16:56:02 +08:00
congqixia
e02a95e3c2
fix: [2.4] Return record with largest timestamp for entires with same PK ( #33936 ) ( #34024 )
...
Cherry-pick from master
pr: #33936
See also #33883
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-21 14:14:01 +08:00
shaoting-huang
b3d425f50a
enhance: Upgrade go version from 1.20 to 1.21 ( #33940 )
...
issue #32982
related pr in master:
pr: #33047 #33150 #33176 #33351 #33202 #33192
Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2024-06-20 14:52:00 +08:00
congqixia
60695bdb44
enhance: [2.4] Set maxPartitionNum default value to 1024 ( #33950 )
...
Cherry-pick from master
pr: #33949
See also #30059
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-18 18:42:00 +08:00
Gao
5fc1370f6f
enhance: [2.4] autoindex for multi data type ( #33867 )
...
issue: #22837
pr: https://github.com/milvus-io/milvus/pull/33868
- opensource autoindex support
- metric type check for different data types
- autoindex data type for search param
Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-06-14 23:26:00 +08:00
congqixia
59144d8246
enhance: Bump milvus & proto version to v2.4.5 ( #33852 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-14 22:27:59 +08:00
cqy123456
562369627d
enhance: [cherry-pick]check index with data type in knowhere api ( #33878 )
...
issue: https://github.com/milvus-io/milvus/issues/22837
related: https://github.com/milvus-io/milvus/pull/33880
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-06-14 19:45:58 +08:00
jaime
fd1c7b1a1c
enhance: enable flush rate limiter of collection level ( #33864 )
...
pr: #33837
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-06-14 16:27:57 +08:00
congqixia
62bd51ec6d
fix: [2.4] Compare config value then swap when caching param value ( #33785 ) ( #33797 )
...
Cherry-pick from master
pr: #33785
See also #33784
This PR change the behavior of `SetCacheValue` of config manager:
- Use mutex and map instead of concurrent map for `configCache`
- Compare config raw value before set cache value
With this implementation, concurrent caching & eviction shall always
have current output:
|time|caching |eviction|config |cached |
|----|--------|------- |---------|---------|
|t0 |get | |old value|null |
|t1 |CAS OK | |old value|old value|
|t2 | |update |new value|old value|
|t3 | |eviction|new value|null |
|time|caching |eviction|config |cached |
|----|--------|------- |---------|---------|
|t0 |get | |old value|null |
|t1 | |update |new value|null |
|t2 |CAS fail| |old value|null |
|t3 | |eviction|new value|null |
|time|caching |eviction|config |cached |
|----|--------|------- |---------|---------|
|t0 | |update |new value|null |
|t1 |get | |new value|null |
|t2 |CAS OK | |new value|new value|
|t3 | |eviction|new value|null |
|time|caching |eviction|config |cached |
|----|--------|------- |---------|---------|
|t0 | |update |new value|null |
|t1 |get | |new value|null |
|t2 | |eviction|new value|null |
|t3 |CAS OK | |new value|new value|
|time|caching |eviction|config |cached |
|----|--------|------- |---------|---------|
|t0 | |update |new value|null |
|t1 | |eviction|new value|null |
|t2 |get | |new value|null |
|t3 |CAS OK | |new value|new value|
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-13 17:51:57 +08:00
wei liu
c9fa167a38
enhance: Add rbac support on describe/alter database api ( #33804 )
...
issue: #32707
pr: #33803
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-13 14:15:56 +08:00
wei liu
25d8b74f71
enhance: Execute bloom filter apply in parallel to speed up segment predict ( #33793 )
...
issue: #33610
pr: #33792
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-13 14:14:04 +08:00
wei liu
54feef30e7
enhance: Use BatchPkExist to reduce bloom filter func call cost ( #33752 )
...
issue: #33610
pr: #33611
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-06-12 17:45:58 +08:00
Aldrin
ff9bb17cc5
fix: Masked kafka credentials getting printed in logs ( #33747 )
...
Cherry-pick from master
pr: #33730
issue: https://github.com/milvus-io/milvus/issues/33727
Signed-off-by: Aldrin <imagesai32@gmail.com>
2024-06-11 15:59:54 +08:00
SimFG
f664b51ebe
enhance: [2.4] try to speed up the loading of small collections ( #33746 )
...
- issue: #33569
- pr: #33570
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-06-11 15:07:55 +08:00
SimFG
c331aa4ad3
enhance: [2.4] add the includeCurrentMsg param for the Seek method ( #33743 )
...
/kind improvement
- issue: #33325
- pr: #33326
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-06-11 15:01:55 +08:00
Buqian Zheng
39e341e83a
fix: [2.4] update check for sparse hnsw index ( #33714 )
...
issue: #29419
pr: #33713
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2024-06-07 18:36:07 +08:00
XuanYang-cn
26db471968
enhance: [2.4]Add consts of MsgDispatcher to configs ( #33680 )
...
See also: #33676
pr: #33679
---------
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-06-07 14:21:58 +08:00
cqy123456
3562ef83b2
enhance:[cherry-pick]Allow hnsw to build sparse ( #33653 )
...
issue:https://github.com/milvus-io/milvus/issues/22837
related:https://github.com/milvus-io/milvus/pull/33675
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-06-06 19:15:51 +08:00
foxspy
58a7111599
enhance: [cherry-pick] add autoindex mapping for binary/sparse datatype ( #33625 )
...
issue: #22837
pr: #33624
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-06-06 10:33:52 +08:00
Chun Han
627b787aed
fix: query iterator lack results( #33137 ) ( #33422 ) ( #33506 )
...
related: #33137
pr: https://github.com/milvus-io/milvus/pull/33422
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2024-06-05 18:51:52 +08:00
aoiasd
aaf6c85095
fix: paramtable cache cause dynamic config non-dynamic ( #33473 ) ( #33590 )
...
relate: https://github.com/milvus-io/milvus/issues/33461
pr: https://github.com/milvus-io/milvus/pull/33473
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-06-05 10:15:51 +08:00
jaime
0ad55c6c44
fix: fix loaded entity num is inaccurate ( #33522 )
...
issue: #33520
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-06-04 20:09:54 +08:00
Buqian Zheng
d6a994038c
enhance: [2.4] add sparse float vector support to restful v2 ( #33555 )
...
issue: https://github.com/milvus-io/milvus/issues/29419
pr: #33231
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2024-06-03 19:31:46 +08:00
congqixia
b9b76ee9a4
fix: [2.4]Use localStorage path to check disk cap for indexnode ( #33450 ) ( #33505 )
...
Cherry-pick from master
pr: #33450
See also #30943 #30944
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-06-03 10:21:47 +08:00
congqixia
8e7f36d928
enhance: Bump milvus version v2.4.4 ( #33504 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-31 14:55:44 +08:00
Cai Yudong
68e2d532d8
enhance: Cherry-pick following SparseFloatVector bulk insert PRs to Milvus2.4 ( #33391 )
...
Cherry pick from master
pr: #33064 #33101 #33187 #33259 #33224
#33064 Support readable JSON file import for
Float16/BFloat16/SparseFloat
#33101 Store SparseFloatVector into parquet as JSON string
#33187 Fix SparseFloatVector data parse error for parquet
#33259 Fix SparseFloatVector data parse error for json
#33224 Optimize bulk insert unittest
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2024-05-30 10:31:45 +08:00
yihao.dai
7384bfe3f8
fix: use seperate warmup pool and disable warmup by default ( #33348 ) ( #33349 )
...
1. use a small warmup pool to reduce the impact of warmup
2. change the warmup pool to nonblocking mode
3. disable warmup by default
4. remove the maximum size limit of 16 for the load pool
issue: https://github.com/milvus-io/milvus/issues/32772
pr: https://github.com/milvus-io/milvus/pull/33348
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Co-authored-by: xiaofanluan <xiaofan.luan@zilliz.com>
2024-05-28 19:27:43 +08:00
congqixia
ef9c1191ae
enhance: Bump milvus version to v2.4.3 ( #33408 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-28 10:11:43 +08:00
wei liu
36172492f7
enhance: Decrease bloom filter fp rate to reduce delete impact ( #33301 ) ( #33329 )
...
pr: #33301
when milvus process delete record, it need to find record's corresponded
segment by bloom filter, and higher bloom filter fp rate will cause
delete record forwards to wrong segments.
This PR Decrease bloom filter's default fp to 0.001.
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-05-24 10:27:41 +08:00
jaime
8990b8b051
fix: correct error of metrics stats ( #33305 )
...
issue: #32980
cherry pick from master
pr: #33075 #33255
---------
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-05-24 09:15:41 +08:00
SimFG
37b2f90c90
enhance: [2.4] the panic when db isn't existed in the rate limit interceptor ( #33308 )
...
issue: #33243
pr: #33244
1. fix: the panic when db isn't existed in the rate limit interceptor
#33244
2. enhance: check the auth in some rest v2 api #33256
---------
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-05-23 17:25:41 +08:00