congqixia
8dfa832fa0
Use same mergify rule for branch 2.3.0 ( #26896 )
...
Since branch 2.3.0 share same action setup,
rules applied to master shall apply to branch 2.3.0 as well
For now, only branch 2.2.0 uses diferent set of rules
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-07 12:03:15 +08:00
congqixia
af5c01082b
Refine delegator lifetime control ( #26881 )
...
- Add SafeChan interface in lifetime package
- Embed SafeChan into interface
- Replace private lifetime struct in delegator package with
- Refine delegator on-going task lifetime control and wait all accepted task done
- Fix potential goroutine leakage from if delegator closed concurrently
/kind improvement
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-07 10:11:15 +08:00
sre-ci-robot
69bac68f8c
Update Pytest image changes ( #26796 )
...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-07 09:47:16 +08:00
nico
5e4ae757f5
update test cases ( #26872 )
...
Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-09-07 09:45:15 +08:00
sre-ci-robot
56a6559fe7
Update knowhere commit ( #26888 )
...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-07 09:19:16 +08:00
yiwangdr
337edc321b
tikv integration ( #26246 )
...
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-09-07 07:25:14 +08:00
cai.zhang
8b5b137207
Should set index task retry not failed when task canceled ( #26878 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-09-06 19:01:14 +08:00
congqixia
0844e19505
Fix mergify rules for unit test file changed under pkg folder ( #26882 )
...
See #26865
for only unit test file changed
removed due to exclude rule only apply to _test.go under internal/
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-06 18:33:14 +08:00
yah01
4a2377e669
Fix retrieving may return more result than limit ( #26670 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-06 17:47:15 +08:00
SimFG
28681276e2
Improve the retry of the rpc client ( #26795 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-06 17:43:14 +08:00
Jiquan Long
61c7b0990d
Workaround fix ChannelManager holding mutex too long ( #26870 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-09-06 14:29:40 +08:00
zhagnlu
9b3e744b24
Fix embedded milvus log bug ( #26864 )
...
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-09-06 14:27:14 +08:00
zhuwenxing
bd4b842153
[test]Update chaos apply and chaos scope ( #26873 )
...
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-09-06 14:03:14 +08:00
MrPresent-Han
528948559f
fix false load failure for long unserviable period( #26813 ) ( #26818 )
...
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-09-06 12:57:15 +08:00
congqixia
7e2fa55440
Fix misuse of waitgroup in metrics mutex ut ( #26865 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-06 12:39:14 +08:00
zhuwenxing
2f32623d16
[test]Fix occasional FileExistsError triggered when concurrently executing pytest ( #26867 )
...
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-09-06 12:07:14 +08:00
wei liu
0e2085b77f
fix dc standby to active ( #26810 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-09-06 10:41:49 +08:00
wayblink
d7b6f3a9e8
Enhance FlushAll/GetFlushAllState API ( #26802 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-09-06 10:35:48 +08:00
sre-ci-robot
78a2638fd4
Update knowhere commit ( #26861 )
...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-06 09:21:49 +08:00
sre-ci-robot
f14dfde338
Update all contributors
...
Signed-off-by: sre-ci-robot <sre-ci-robot@zilliz.com>
2023-09-06 00:01:27 +00:00
bjzhjing
548c82eca5
Refactor storage.MergeInsertData() to optimize the merging process ( #26839 )
...
Benchmark Milvus with https://github.com/qdrant/vector-db-benchmark and
specify the datasets as 'deep-image-96-angular'. Meanwhile, do perf
profiling during 'upload + index' stage of vector-db-benchmark and see
the following hot spots.
39.59%--github.com/milvus-io/milvus/internal/storage.MergeInsertData
|
|--21.43%--github.com/milvus-io/milvus/internal/storage.MergeFieldData
| |
| |--17.22%--runtime.memmove
| |
| |--1.53%--asm_exc_page_fault
| ......
|
|--18.16%--runtime.memmove
|
|--1.66%--asm_exc_page_fault
......
The hot code path is in storage.MergeInsertData() which updates
buffer.buffer by creating a new 'InsertData' instance and merging both
the old buffer.buffer and addedBuffer into it. When it calls golang
runtime.memmove to move buffer.buffer which is with big size (>1M), the
hot spots appear.
To avoid the above overhead, update storage.MergeInsertData() by
appending addedBuffer to buffer.buffer, instead of moving buffer.buffer
and addedBuffer to a new 'InsertData'. This change removes the hot spots
'runtime.memmove' from perf profiling output. Additionally, the 'upload
+ index' time, which is one performance metric of vector-db-benchmark,
is reduced around 60% with this change.
Signed-off-by: Cathy Zhang <cathy.zhang@intel.com>
2023-09-05 21:41:48 +08:00
congqixia
9ed5841730
Use specified mockery & golangci-lint version ( #26845 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-05 17:39:48 +08:00
Enwei Jiao
73f4347ac6
Fix code checker error ( #26844 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-09-05 15:51:48 +08:00
zhuwenxing
1a80380a6a
[skip e2e]Add wait time when verifying the chaos is deleted ( #26847 )
...
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-09-05 14:33:49 +08:00
congqixia
fe7f7ea237
Add cpp-build and setenv for querynode mockery regen command ( #26843 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-05 14:13:49 +08:00
congqixia
901e98a868
Update CONTRIBUTING.md for mockery generation ( #26842 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-05 14:11:54 +08:00
Enwei Jiao
fb0705df1b
Decouple basetable and componentparam ( #26725 )
...
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-09-05 10:31:48 +08:00
nico
f0c911afc2
add case about diskann and binary index ( #26804 )
...
Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-09-05 10:23:48 +08:00
zhuwenxing
68a2940b66
[test]Refine chaos apply ( #26823 )
...
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-09-05 10:17:48 +08:00
congqixia
4b58c71908
Add ctx parameter for organizeTask and GetWorker method ( #26835 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-05 10:05:48 +08:00
sre-ci-robot
c132c53b1a
Update knowhere commit ( #26840 )
...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-09-05 09:05:49 +08:00
congqixia
1a8cf5c415
Organize all mockery generation commands in Makefile ( #26826 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-04 21:19:48 +08:00
wei liu
1097776477
stop heartbeat if reach heartbeat limit ( #26728 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-09-04 17:51:48 +08:00
cai.zhang
622077f9ad
Refine error message for json length exceed max length ( #26676 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-09-04 17:47:48 +08:00
XuanYang-cn
b2e7cbdf4b
Remove TimeTravel in compactor ( #26785 )
...
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-09-04 17:41:48 +08:00
cai.zhang
d7cd1f2a6d
Fix bug for get index state with compaction segment ( #26822 )
...
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-09-04 17:29:48 +08:00
zhagnlu
7056e9c0f7
Increase minio log level to avoid unnecessary log ( #26776 )
...
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2023-09-04 17:25:48 +08:00
yihao.dai
4340cbfba2
Merge syncCPLagTooBehind policy into syncPeriodically policy ( #26713 )
...
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-09-04 14:37:47 +08:00
chyezh
0530fd80c9
[Fixup] remove nats from default ( #26791 )
...
Signed-off-by: chyezh <ye.zhen@zilliz.com>
2023-09-04 10:01:04 +08:00
yihao.dai
7624c2b949
Improve rated log in insertBufferNode ( #26788 )
...
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-09-04 09:59:10 +08:00
yah01
3349db4aa7
Refine errors to remove changes breaking design ( #26521 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-04 09:57:09 +08:00
yihao.dai
c6024a32f5
Add rate limit ratio monitoring ( #26709 )
...
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-09-03 20:47:02 +08:00
MrPresent-Han
a34a9d606c
fix panic due to empty traceID( #26754 ) ( #26808 )
...
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-09-02 16:13:01 +08:00
yah01
941a383019
Fix failed to load collection with more than 128 partitions ( #26763 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-02 00:09:01 +08:00
yihao.dai
64cf5eab18
Accelerate flush in flushAll ( #26769 )
...
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-09-01 15:23:01 +08:00
congqixia
e8f1b1736e
Remove log.Error(err.error())-style log ( #26783 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-01 13:09:01 +08:00
wei liu
5602b22531
refine checker code style ( #26759 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-09-01 11:57:01 +08:00
wei liu
949c320185
remove pull target from qc recover ( #26775 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-09-01 11:17:01 +08:00
smellthemoon
e56b0018e4
Remove merr mask logic to make it ok to compare resp.status with origin error ( #26773 )
...
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-09-01 11:09:00 +08:00
XuanYang-cn
ef75784715
Fix LoadSegmentLatency metric p99 ( #26761 )
...
See also: #26743
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-09-01 11:07:07 +08:00