Commit Graph

20147 Commits

Author SHA1 Message Date
nico
ecdaeda6a8
enhance: update nightly groovy (#33362)
Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-05-24 18:43:41 +08:00
zhuwenxing
512f57e65a
test: [cherry-pick]add check for partition key for import test (#33323)
pr:https://github.com/milvus-io/milvus/pull/33253

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2024-05-24 10:57:40 +08:00
wei liu
36172492f7
enhance: Decrease bloom filter fp rate to reduce delete impact (#33301) (#33329)
pr: #33301
when milvus process delete record, it need to find record's corresponded
segment by bloom filter, and higher bloom filter fp rate will cause
delete record forwards to wrong segments.

This PR Decrease bloom filter's default fp to 0.001.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-05-24 10:27:41 +08:00
jaime
8990b8b051
fix: correct error of metrics stats (#33305)
issue: #32980
cherry pick from master
pr:  #33075 #33255

---------

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-05-24 09:15:41 +08:00
Bingyi Sun
d4a146ef1a
enhance: mmap load raw data if scalar index does not have raw data (#… (#33317)
pr: #33175

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-05-24 09:09:42 +08:00
congqixia
78f8075ff1
enhance: [2.4] Sync deleteBufBytes config value to default config (#33322)
Cherry-pick from master
pr: #33320
The delete buffer size is set to 64MB in milvus.yaml but the default set
up shall be 16MB

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-24 09:07:54 +08:00
Bingyi Sun
e3f1331c47
fix: check array field data is nil before getting the type (#33114) (#33311)
issue: https://github.com/milvus-io/milvus/issues/33074
pr: #33114

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2024-05-24 09:07:11 +08:00
yihao.dai
e8c9bdfa5c
fix: Fix global rate limit is not working (#33335) (#33336)
If the request is limited by rate limiter, limiter should not "Cancel".
This is because, if limited, tokens are not deducted; instead, "Cancel"
operation would increase the token count.

issue: https://github.com/milvus-io/milvus/issues/31705

pr: https://github.com/milvus-io/milvus/pull/33335

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-05-24 09:05:47 +08:00
yihao.dai
62663ac2e2
fix: Fix printing type of request (#33289) (#33319)
issue: https://github.com/milvus-io/milvus/issues/31705

pr: https://github.com/milvus-io/milvus/pull/33289

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-05-23 21:14:31 +08:00
cai.zhang
ef10d15658
fix: [2.4]Throw an exception after all the threads in thread pool finished (#32810) (#33314)
issue: #32487
master pr: #32810

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-05-23 17:55:40 +08:00
Buqian Zheng
ec33024637
fix: [2.4] in segcore validate search sparse vector to make sure it is legal (#33312)
pr: #32856

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2024-05-23 17:35:40 +08:00
SimFG
37b2f90c90
enhance: [2.4] the panic when db isn't existed in the rate limit interceptor (#33308)
issue: #33243
pr: #33244

1. fix: the panic when db isn't existed in the rate limit interceptor
#33244
2. enhance: check the auth in some rest v2 api #33256

---------

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-05-23 17:25:41 +08:00
yanliang567
8c9afd5f07
test: [cherry pick] Add index name tests for multiple vectors (#33315)
Related issue: https://github.com/milvus-io/milvus/issues/32653
Related pr: #33250

---------

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2024-05-23 17:17:41 +08:00
foxspy
2b62324d7b
enhance: Update Knowhere version (#33310)
/kind branch-feature

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
2024-05-23 16:53:40 +08:00
Jiquan Long
d98e1f6ff5
fix: two-phase retrieval on lru-segment (#32945) (#33313)
Cherry-pick from master
pr: #32945 
issue: #31822

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-05-23 16:25:40 +08:00
wei liu
32bfd9befa
enhance: Enable to dynamic update balancer policy in querycoord (#33037) (#33272)
issue: #33036
pr: #33037
This PR enable to dynamic update balancer policy without restart
querycoord.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-05-23 15:43:41 +08:00
congqixia
d6bc95de55
enhance: [2.4] Add param item to ignore bad message id in checkpoint (#33123) (#33249)
Cherry-pick from master
pr: #33123 #33158
See also  #33122

This pr add param item `mq.ignoreBadPosition` to control behavior when
mq failed to parse message id from checkpoint

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-23 15:27:41 +08:00
congqixia
3bd8137062
enhance: [2.4] Use pre-built logger for write buffer frequent ops (#33273) (#33304)
Cherry-pick from master
pr: #33273
See also #33266

Each `WriteBuffer` shall have same channel/collection id attribute, so
use same logger will do and reduce logger allocation & frequent name
composition

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-23 15:19:41 +08:00
congqixia
2f3b377479
fix: [2.4] Remove task from syncmgr after task done (#33303)
Cherry-pick from master
pr: #33302
See also #33247
Introduced in PR #32865

Remove task after task done to keep checkpoint sound and safe

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-23 14:51:39 +08:00
yihao.dai
ad4c1975bd
fix: Fix filtering by partition key fails for importing data (#33274) (#33277)
Before executing the import, partition IDs should be reordered according
to partition names. Otherwise, the data might be hashed to the wrong
partition during import. This PR corrects this error.

issue: https://github.com/milvus-io/milvus/issues/33237

pr: https://github.com/milvus-io/milvus/pull/33274

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-05-23 11:25:40 +08:00
PowderLi
f10ffb9230
fix: [cherry-pick][restful v2]role operations need dbName (#33291)
issue: #33220
master pr: #33283

use dbName as part of privilege entity, so
1. grant / revoke a privilege need dbName
2. we can describe the privileges of the role which belong to one
special database

Signed-off-by: PowderLi <min.li@zilliz.com>
2024-05-23 09:51:45 +08:00
wei liu
a988e7cabc
enhance: Reduce bloom filter lock contention between insert and delete in query coord (#32643) (#33284)
issue: #32530
pr: #32643 

cause ProcessDelete need to check whether pk exist in bloom filter, and
ProcessInsert need to update pk to bloom filter, when execute
ProcessInsert and ProcessDelete in parallel, it will cause race
condition in segment's bloom filter

This PR execute ProcessInsert and ProcessDelete in serial to avoid block
each other

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-05-22 20:53:40 +08:00
congqixia
3c31499bbc
enhance: [2.4]Assert insert data length not overflow int (#33248) (#33271)
Cherry-pick from master
pr: #33248 
When InsertData is too large for cpp proto unmarshalling, the error
message is confusing since the length is overflowed

This PR adds assertion for insert data length.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-22 19:07:40 +08:00
sammy.huang
64d0a71ba0
fix: arm-based gpu image (#33276)
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-05-22 17:08:46 +08:00
XuanYang-cn
e5ca1f7c45
fix: Return error when startup Delete/AddNode fail (#33193) (#33258)
See also: #33151, #33149
pr: #33193

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-05-22 14:49:40 +08:00
wei liu
4b8680894f
fix: Clean offline node from resource group after qc restart (#33233)
issue: #33200 #33207
pr: #33232
pr#33104 causes the offline node will be kept in resource group after qc
recover, and offline node will be assign to new replica as rwNode, then
request send to those node will fail by NodeNotFound.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-05-22 14:07:39 +08:00
aoiasd
1f23c39700
fix:[Cherry-Pick] can't generate traceID when use noop exporter (#33191) (#33208)
relate: https://github.com/milvus-io/milvus/issues/33190
pr: https://github.com/milvus-io/milvus/pull/33191

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-05-22 11:13:39 +08:00
SimFG
2a38f5b598
enhance: [2.4] add config to control whether to init public role permissions (#33174)
issue: #33164
pr: #33165

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-05-21 22:39:46 +08:00
XuanYang-cn
00b05fcc02
fix: Remove L0 compactor in completedCompactor (#33169) (#33216)
See also: #33168
pr: #33169

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-05-21 19:07:39 +08:00
sammy.huang
7013d2f906
feat: support arm-based image build and pull request (#33225)
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
2024-05-21 16:54:43 +08:00
congqixia
e5db2f7e77
fix: [2.4] Check schema without vector field in proxy (#33211) (#33218)
Cherry-pick from master
pr: #33211
Related to #33199

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-21 16:37:44 +08:00
XuanYang-cn
b2f7d7ba4e
fix: [2.4]channel manager's goroutine run order (#33121)
See also: #33117
pr: #33118

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-05-21 14:31:39 +08:00
Jiquan Long
a27a2e8021
fix: try best to get enough query results (#33178) (#33179)
issue: https://github.com/milvus-io/milvus/issues/33137
pr: #33178

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-05-21 14:07:45 +08:00
congqixia
5370c39a23
fix: [2.4] Mark channel checkpoint dropped prevent cp lag metrics leakage (#32454) (#33201)
Cherry-pick from master
pr: #33198
See also #31506 #31508

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-21 11:57:51 +08:00
smellthemoon
2f260cd33b
enhance: reduce memory when read field(#33195) (#33196)
pr:https://github.com/milvus-io/milvus/pull/33195

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-05-20 21:17:39 +08:00
congqixia
cf7765915c
enhance: [2.4]Refine channel mgr v2 implementation (#33156) (#33172)
Cherry-pick from master
pr: #33156
Related to #25309

- Remove ctx from struct
- Add ctx parameters for internal check logic methods
- Add Waitgroup to make sure worker goroutine quit before close returns

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-20 18:25:38 +08:00
SimFG
6b02c085f6
fix: [2.4] reset the quota value when init the limiter (#33152)
issue: #33107
pr: #33111
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-05-20 15:17:38 +08:00
wei liu
9ae4945df2
fix: query node may stuck at stopping progress (#33104) (#33154)
issue: #33103 
pr: #33104
when try to do stopping balance for stopping query node, balancer will
try to get node list from replica.GetNodes, then check whether node is
stopping, if so, stopping balance will be triggered for this replica.

after the replica refactor, replica.GetNodes only return rwNodes, and
the stopping node maintains in roNodes, so balancer couldn't find
replica which contains stopping node, and stopping balance for replica
won't be triggered, then query node will stuck forever due to
segment/channel doesn't move out.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-05-20 15:01:43 +08:00
sre-ci-robot
780f3137f3
[automated] Update Pytest image changes (#33091)
Update Pytest image changes
See changes:
9536e79363
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-05-17 15:09:36 +08:00
binbin
9536e79363
test: update pymilvus version (#33077)
issue: #17614 
pr: #33079

Signed-off-by: binbin lv <binbin.lv@zilliz.com>
2024-05-16 14:51:34 +08:00
congqixia
b2d83d3354
enhance: Bump milvus version to v2.4.2 (#33048)
Bumping version to v2.4.2. Also bump milvus-proto version to v2.4.3.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-15 13:57:35 +08:00
wayblink
259bc97a2b
fix: Fix segments lost in flush response (#33061)
#33055

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-05-15 13:49:34 +08:00
cai.zhang
6ea7633bd5
enhance: Add memory size for binlog (#33025)
issue: #33005
1. add `MemorySize` field for insert binlog.
2. `LogSize` means the file size in the storage object.
3. `MemorySize` means the size of the data in the memory.

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2024-05-15 12:59:34 +08:00
XuanYang-cn
d4837307b3
fix: Make submit idempotent (#33053)
issue: #33054

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-05-14 22:09:34 +08:00
yihao.dai
6fc00e42d7
fix: Fix binlog import (#33027)
binlog import should only import into one partition.

issue: https://github.com/milvus-io/milvus/issues/32807

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-05-14 21:45:32 +08:00
Gao
3777eb2f68
enhance: update knowhere new version (#33043)
for milvus new release, knowhere update to latest release version

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2024-05-14 20:45:32 +08:00
jaime
f48a7ff8ff
enhance: use Delete instead of DeletePartialMatch to remove metrics (#33029)
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-05-14 18:49:33 +08:00
smellthemoon
89a7c34c7a
fix: exceed etcd limit (#33041)
#32974

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-05-14 18:45:32 +08:00
congqixia
dea7faf394
fix: Remove RLock re-entry in GetNumRowsOfPartition (#33045)
Resolves #33044

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-05-14 17:51:32 +08:00
Jiquan Long
3d85e6e028
fix: etcd txn exceeds limit due to too many fields (#33040)
fix: #33038

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2024-05-14 17:05:33 +08:00