chyezh
0c7474d7e8
enhance: add graceful stop timeout to avoid node stop hang under extreme cases ( #30317 )
...
1. add coordinator graceful stop timeout to 5s
2. change the order of datacoord component while stop
3. change querynode grace stop timeout to 900s, and we should
potentially change this to 600s when graceful stop is smooth
issue: #30310
also see pr: #30306
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-02-29 17:01:50 +08:00
congqixia
af315539d4
fix: Remove time tick delay metrics when nodes go offline ( #30833 )
...
See also #30832
This PR removes time tick delay metrics when rootcoord GetMetrics
response does not have previously existed querynode/datanode
Also add unit tests for this case
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi.Xia <congqi.xia@zilliz.com>
2024-02-28 10:10:56 +08:00
zhenshan.cao
bb93b22c84
fix: should return collectionName in response of ListAliases ( #30532 )
...
issue : https://github.com/milvus-io/milvus/issues/30369
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-02-12 08:30:55 +08:00
cai.zhang
f619d792c0
enhance: Break down the granularity of collection info cache expired ( #29977 )
...
issue: #29772
1. `DropPartition` only invalidates the cache related to the partition.
2. `CreateAlias` does not invalidate the cache.
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-01-30 16:45:02 +08:00
MrPresent-Han
2a0eb1d2e6
feat: support general capacity restrict for cloud-side resoure contro… ( #29845 )
...
related: #29844
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2024-01-16 16:32:53 +08:00
wayblink
1df3f90696
feat: Implement DescribeAlias and ListAliases interfaces ( #29641 )
...
#22882
/kind feature
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-01-11 19:12:51 +08:00
yah01
e8496d4d49
enhance: filter out the not needed collections while listing ( #29690 )
...
this improves performance while many collections exist
resolve #29631
Signed-off-by: yah01 <yang.cen@zilliz.com>
2024-01-10 15:18:48 +08:00
smellthemoon
1c1f2a1371
enhance:change some logs ( #29579 )
...
related #29588
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-01-05 16:12:48 +08:00
yah01
99e0f1e65a
enhance: unable to compile C++ tests ( #29616 )
...
The tests need to call a private method, Milvus uses `#define` to
replace private with public, the hack trick works but would be broken if
the including order changed.
This uses friend to make all things work well
Signed-off-by: yah01 <yang.cen@zilliz.com>
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2024-01-04 13:20:46 +08:00
SimFG
dd9c61831d
enhance: Support to get the param value in the runtime ( #29297 )
...
/kind improvement
issue: #29299
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-22 18:36:44 +08:00
wei liu
fcba1c0d9e
fix: Rename invalid parameterutil package path ( #29334 )
...
This PR renames the invalid parameterutil package path
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-21 11:40:42 +08:00
wei liu
e41fd6fbde
enhance: Move proxy client manager to util package ( #28955 )
...
issue: #28898
This PR move the `ProxyClientManager` to util package, in case of
reusing it's implementation in querycoord
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-20 19:22:42 +08:00
PowderLi
bcd6865b29
enhance: add 3 builtin roles ( #28961 )
...
issue: #28960 [milvus-proto
#212 ](https://github.com/milvus-io/milvus-proto/issues/212 )
add new configuration: builtinRoles
user can define roles in config file: `milvus.yaml`
there is an example:
1. db_ro, only have read privileges, include load
2. db_rw, read and write privileges, include create/drop/rename
collection
3. db_admin, not only read and write privileges, but also user
administration
Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-18 14:28:41 +08:00
yah01
b8674811cf
fix: data race in ProxyClientManager ( #29206 )
...
this PR changed the ProxyClientManager to thread-safe
fix #29205
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-14 18:22:39 +08:00
SimFG
5a7fb97e07
fix: missing the grant info when using the SelectGrant api with the default db ( #29173 )
...
issue: #29172
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-14 16:20:43 +08:00
wei liu
fe1eeae2aa
enhance: Use mockery to replace manual mock code ( #29074 )
...
issue: #29043
This PR remove mannul mock code for proxy and data coord
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-13 10:46:44 +08:00
cai.zhang
49b8657f95
enhance: Support implicit type conversion for parquet ( #29046 )
...
issue: #29019
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-12 16:14:44 +08:00
wayblink
994b239161
fix: fix datarace in root_coord proxy_client_manager ( #28796 )
...
bug: #28797
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-12-12 10:18:39 +08:00
xige-16
89b965e2b1
fix: clean snapshots meta ( #28502 )
...
issue: https://github.com/milvus-io/milvus/issues/28496
/kind bug
The input parameters collection.partitions and collection.Field are both
nil, so these two metas have not been cleared.
Signed-off-by: xige-16 <xi.ge@zilliz.com>
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-12-05 16:04:36 +08:00
wei liu
6718986a5b
enhance: Remove too frequency read ddl log from rootcoord ( #28891 )
...
This PR removed too frequency log for such
`DescribeCollection/ShowPartition` operation from root coord
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-04 09:42:33 +08:00
congqixia
881a166b5a
fix: data race on rootcoord.proxyClientManager.proxyClient ( #28787 )
...
Fix #28786
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-28 15:52:26 +08:00
cai.zhang
1b7a503f89
enhance: Revert import support csv format ( #28760 )
...
Revert import support csv format.
issue: #28778
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-11-28 14:32:27 +08:00
jaime
b1e0a27f31
enhance: Add logs for each step during service initialization ( #28624 )
...
/kind improvement
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-11-27 16:30:26 +08:00
smellthemoon
79c0edb1d8
enhance:Remove msgbase unnecessary assignments ( #28511 )
...
remove some unnecessary assignments, for the reason that
commonpbutil.NewMsgBase has default value.
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-24 15:02:39 +08:00
wayblink
53646032d0
fix: rootcoord_collection_num metric is twice the real value ( #28666 )
...
#28665
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-11-23 20:42:23 +08:00
congqixia
a2fe9dad49
enhance: Make etcd kv request timeout configurable ( #28661 )
...
See also #28660
This pr add request timeout config item for etcd kv request timeout
Sync the default timeout value to same value for etcdKV & tikv config
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-23 19:34:23 +08:00
smellthemoon
73f2bab454
enhance:add some log when create client and get component states ( #28160 )
...
/kind improvement
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-22 09:12:22 +08:00
yah01
bfccfcd0ca
enhance: refine error messages ( #28424 )
...
- Split the simple reason and full detail
- Refine existing error messages
related: #28422
---------
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-11-21 17:02:24 +08:00
yihao.dai
c16fc854d1
Fix confusing quota log ( #28262 )
...
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-11-13 15:38:18 +08:00
wei liu
bce1054f92
Fix retry when proxy stopped ( #28264 )
...
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-11-09 18:58:21 +08:00
KumaJie
e88212ba4b
Add CSV file import function ( #27149 )
...
Signed-off-by: kuma <675613722@qq.com>
Co-authored-by: kuma <675613722@qq.com>
2023-10-31 22:47:23 +08:00
groot
e6d4cde397
Fix duplicated segment id in bulkinsert task state ( #27915 )
...
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2023-10-27 15:14:13 +08:00
Filip Haltmayer
6b1a106a31
Moving etcd client into session ( #27069 )
...
Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
2023-10-27 07:36:12 +08:00
SimFG
9b0ecbdca7
Support to replicate the mq message ( #27240 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-10-20 14:26:09 +08:00
zhenshan.cao
020ad9a6bc
Rectify wrong exception messages associated with Array datatype ( #27769 )
...
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2023-10-19 17:24:07 +08:00
wayblink
e3f2122618
Expose metrics of stanby coordinators ( #27698 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-10-16 15:04:09 +08:00
jaime
ec1fe3549e
Add a stop hook to clean session ( #27564 )
...
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-10-16 10:24:10 +08:00
yah01
15746b5b5f
Refine KV errors ( #27588 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-10-13 17:15:34 +08:00
yah01
be980fbc38
Refine state check ( #27541 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-10-11 21:01:35 +08:00
smellthemoon
a9982aa7c6
Remove topic empty restriction when preCreated topic ( #27351 )
...
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-10-10 18:53:32 +08:00
yah01
8394b3a1ec
Block creating new error from status reason ( #27426 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-10-07 11:29:32 +08:00
Jiquan Long
0f14d18201
Optimize the codec code of session ( #27360 )
...
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-10-01 10:33:30 +08:00
yah01
63ac43a3b8
Refine errors for import ( #27379 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-30 10:31:28 +08:00
SimFG
9fb4c27a90
Fix rootcoord failure to start when reaching the limit of role num ( #27361 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-27 11:03:26 +08:00
yah01
6539a5ae2c
Refine DataCoord status ( #27262 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-26 17:15:27 +08:00
wayblink
7dd0be1b2c
Enable bulkinsert binlog data with partitionkey ( #27241 )
...
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-09-26 10:25:25 +08:00
jaime
7f7c71ea7d
Decoupling client and server API in types interface ( #27186 )
...
Co-authored-by:: aoiasd <zhicheng.yue@zilliz.com>
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-09-26 09:57:25 +08:00
SimFG
26f06dd732
Format the code ( #27275 )
...
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-21 09:45:27 +08:00
yah01
b4f86ea55e
Construct all success status with merr ( #27226 )
...
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-20 10:57:23 +08:00
congqixia
cc9974979f
Add staticcheck linter and fix existing problems ( #27174 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-19 10:05:22 +08:00