Commit Graph

296 Commits

Author SHA1 Message Date
xige-16
99984b88e1
Support delete varChar value (#16229)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-04-02 17:43:29 +08:00
XuanYang-cn
e9090a62ab
Rearrange search/queryTask for readability (#16325)
`searchTask` has 683 lines of code, `queryTask` has 485 lines of code.
`task.go` contains 4k+ codes including `searchTask` and `queryTask`.

It was so much pain navigating codes of searchTask and queryTask though task.go,
task.go and task_test.go are literaly unreadable.

This PR moves
1. 650+ lines of code of `searchTask` from `task.go` to `task_search.go`.
2. 1.4k+ lines of test code of `searchTask` from `task_test.go` to
   `task_search_test.go`.
3. 450+ lines of code of `queryTask` from `task.go` to `task_query.go`.
4. 200+ lines of test code of `queryTask from `task_test.go to
   `task_query_test.go`.

This PR also rearrange methods positions of `searchTask` and
`queryTask`:
-  Putting the most important methods `PreExecute`, `Execute`, and
   `PosExecute` at the beginning of the file.
-  Moves interface methods `ID`, `SetID`, `Type`, `BeginTs`, etc.
   that nobody cares about to the bottom of the file.

See also: #16298

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-04-01 18:59:29 +08:00
XuanYang-cn
a0bb758be5
Refine log in proxy searchTask (#16263)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-03-30 22:09:28 +08:00
zhenshan.cao
11cea5aad0
Refine proxy log (#16246)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-03-29 02:29:27 +08:00
congqixia
2c03287e79
Improve log level in proxy QueryTask (#16234)
Use warn instead of debug in error case

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-28 23:11:26 +08:00
Ten Thousand Leaves
40c703dacd
Support check index state in root coord, for bulk load feature. (#16198)
issue: #15604

/kind feature

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-03-28 16:41:28 +08:00
xige-16
205c92e54b
Support insert string data (#15993)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2022-03-25 14:27:25 +08:00
Jiquan Long
f8d9bc919d
Unify interface of vector index & scalar index. (#15959)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-21 14:23:24 +08:00
zhenshan.cao
f3eeecf146
Reduce the number of metrics (#16030)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-03-15 21:51:21 +08:00
cai.zhang
2512dff261
Fix misuse of timerecord (#15868)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-03-04 15:45:56 +08:00
Jiquan Long
f71651e294
Support column-based insert data in message stream (#15802)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-03-04 15:09:56 +08:00
Cai Yudong
57b97ccb9c
Let search fail as if one query_node return error result (#15855)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-03-04 10:43:56 +08:00
jaime
7a3a721380
Reconstruct mqstream module (#15784)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-03-03 21:57:56 +08:00
congqixia
3f34bc1ab7
Ban DataType_String in CreateCollection (#15838)
Fix #15836
/kind enhancement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-03 16:57:56 +08:00
朱亚光
27a7875a15
add array hashKeys empty check (#15796)
fix #15791 https://github.com/milvus-io/milvus/issues/15791
Signed-off-by: zhuyaguang <zhuyaguang1368@163.com>
2022-03-03 00:33:56 +08:00
cai.zhang
d183748484
Add some prometheus metrics for proxy (#15582)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2022-03-02 16:23:55 +08:00
Filipe Caixeta
dee1961b4d
Make SearchResults and QueryResults return collectionID (#15377)
* Make SearchResults and QueryResults return collectionID

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>

* add return collection name from QueryRequest and SearchRequest

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>

* remove comment

Signed-off-by: Filipe Caixeta <filipecaixeta@gmail.com>
2022-01-27 22:55:41 +08:00
Cai Yudong
6323907566
Use CommonConfig in GlobalParams for all components (#15106)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-10 19:03:35 +08:00
shaoyue
2e8dd74c7e
[skip e2e] Add comment for proxy task (#15089)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2022-01-10 18:33:46 +08:00
Cai Yudong
7efb02a4c5
Use PulsarConfig in GlobalParams for all components (#15046)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-01-09 23:45:33 +08:00
guoxiangzhou
1807ba534d
[skip e2e] Modify log text according to the naming conventions (#14969)
Signed-off-by: guoxiangzhou <xiangzhou.guo@zilliz.com>
2022-01-07 18:41:23 +08:00
guoxiangzhou
8ec3c69447
[skip e2e] Modify log text according to the naming conventions (#14970)
Signed-off-by: guoxiangzhou <xiangzhou.guo@zilliz.com>
2022-01-07 18:39:22 +08:00
congqixia
6400263f3c
[skip e2e] Improve SearchTask log format (#14753)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-01-04 14:15:39 +08:00
Jiquan Long
77ef791b6e
[skip e2e] Add comment for minFloat32 (#14752)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2022-01-04 14:13:44 +08:00
Xiaofan
98e4ff33a8
Fix RocksDB Slow (#14614) 2021-12-30 20:08:15 +08:00
congqixia
7bb1d6267d
[skip e2e] Add comment for CreateAliasTask methods (#14539)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-29 22:40:27 +08:00
zhenshan.cao
32a5126705
Add the limitation of the traceable interval to timeTravel (#14498)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-12-29 21:29:45 +08:00
congqixia
ffe44ae1ea
[skip e2e] Add comment for CreateAliasTask (#14463)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-28 22:22:46 +08:00
congqixia
307b07363b
[skip e2e] Add comment for IDs2Expr (#14352)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-12-28 09:48:15 +08:00
shaoyue
26ed17a905
[skip e2e] Add comment for AlterAliasTask (#14140)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-12-24 13:33:45 +08:00
Xiaofan
24e2faf110
Fix has collection err (#14089)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-12-23 21:46:10 +08:00
Cai Yudong
891c202b73
Use GlobalParamTable for all components (#13885)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-23 18:39:11 +08:00
shaoyue
e8ebd926e0
[skip e2e] Add comment for internal/proxy/task.go (#14031)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-12-23 11:05:09 +08:00
edward.zeng
8eb4d9a2b4
[skip e2e] Add comment to proxy task (#14003)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-12-22 20:29:29 +08:00
Jiquan Long
bdb001b20d
Add log of query to record time spent in mq (#13526)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-22 10:11:02 +08:00
Jiquan Long
8a63dba149
Add consistency level field in collection meta (#13766)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-21 19:49:02 +08:00
xige-16
dc7fb594af
[skip e2e]Improve log for QueryNode spell (#13809)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-12-20 23:10:51 +08:00
shaoyue
22e0fc8701
[skip e2e] Add comment for DropAliasTask (#13626)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-12-17 18:46:38 +08:00
zhenshan.cao
bfdf6eb402
[skip e2e]Fix datarace in proxy (#13607)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-12-17 16:32:52 +08:00
Jiquan Long
00c9797d91
Add log of insert to record time spent in mq (#13527)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-16 22:27:42 +08:00
Jiquan Long
cb51df5985
Add log of search to record time spent in mq (#13525)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-16 22:22:06 +08:00
Xiangyu Wang
405b3cd932
Use the same lint rules with golint in revive (#13324)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-14 15:31:07 +08:00
Cai Yudong
b5d639a1ab
Use typeutil.ProxyRole instead of Params.RoleName in proxy (#13217)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-13 10:01:18 +08:00
bigsheeper
214f40b209
Add timeout ts for search and query (#12890)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-12-08 14:15:03 +08:00
dragondriver
a2a1f9d08c
Disable multiple vector fields (#12691)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-06 10:03:34 +08:00
Cai Yudong
147fc41a67
Update proxy debug log (#12591)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-12-02 12:41:32 +08:00
dragondriver
1db1cf2104
Fix similarity correlation (#12511)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-12-01 15:26:02 +08:00
dragondriver
6d92b8499c
Revert #11901, Fix wrong jaccard distance (#12487)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-30 20:31:35 +08:00
Cai Yudong
74a4a4e15b
Fix golint warnings for proxy (#11895)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-29 12:25:17 +08:00
godchen
927f72d588
Add delete task channel stats interface (#12250)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-24 16:01:17 +08:00
shaoyue
b231965e15
[skip ci] Add comments for exported funcs in internal/proxy/task.go (#11980)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-11-17 16:13:17 +08:00
dragondriver
8c951217ee
Fix wrong distances caused by metric type (#11901)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-11-16 19:11:10 +08:00
yukun
27d711e5d2
Insert task hash by primarykeys (#11819)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-11-16 14:21:27 +08:00
XuanYang-cn
99894e451d
[skip ci]Update license for proxy task (#11611)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-11-10 23:55:48 +08:00
Cai Yudong
e27283abbf
Update query reduce log (#11402)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-08 16:07:34 +08:00
Cai Yudong
d32c77e99b
Update search reduce log (#11400)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-08 16:03:30 +08:00
godchen
88c9067873
Add hashvalue warning (#10668)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-05 14:20:55 +08:00
bigsheeper
c99d1a56bf
Refactor proxy ticker to fix guarantee_time not work (#11248)
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2021-11-05 09:14:02 +08:00
Cai Yudong
0fac38000c
Correct empty retrieve result handling (#11219)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-04 18:08:32 +08:00
godchen
a0a3a889e7
Add common endian for global use (#11092)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-11-02 18:16:32 +08:00
Cai Yudong
70188990dc
Remove primary key duplicated query result on proxy (#10967)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-01 10:27:56 +08:00
Cai Yudong
da0cb4a702
Use primary key only to check search result duplicate (#10949)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-01 10:06:03 +08:00
Cai Yudong
0049837dc4
Add utils API AppendFieldData (#10910)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-29 18:06:43 +08:00
Cai Yudong
5ad4cdda25
Clean search result duplicates removal debug log (#10769)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-27 20:02:26 +08:00
Cai Yudong
24f9411249
Optimize queryTask PostExecute (#10739)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-27 17:34:35 +08:00
Cai Yudong
c51155a542
Optimize decodeSearchResults (#10728)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-27 14:10:27 +08:00
cai.zhang
3734ff49ac
Add default value for the parameter roundDeciaml (#9626)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-26 18:24:23 +08:00
zhenshan.cao
bb08df28f3
Fix golint error in proxy (#10620)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-26 10:38:41 +08:00
zhenshan.cao
4b0fd28de7
Fix golint error in proxy (#10621)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-25 23:42:29 +08:00
godchen
daaa9428ea
Fix delete msg hash error (#10599)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-25 22:20:20 +08:00
godchen
d2e0943f21
Fix delete node flush error (#10549)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-25 18:49:20 +08:00
cai.zhang
c3cce20413
Reset the msgstream threshold to PulsarMaxMessageSize (#10186)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-10-25 17:57:14 +08:00
Cai Yudong
880e375b00
[skip ci] Remove comments (#10541)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-25 15:25:12 +08:00
Cai Yudong
f6802589eb
Optimize proxy reduce code readability (#10537)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-25 14:29:12 +08:00
zhenshan.cao
3af852eafb
Fix golint error in proxy (#10488)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-23 23:17:11 +08:00
zhenshan.cao
51d82fc71d
Fix golint error in proxy (#10487)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-23 18:25:37 +08:00
zhenshan.cao
169359448f
Fix golint error in proxy (#10486)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-23 18:23:44 +08:00
zhenshan.cao
43ef5d5eb9
Fix golint error in proxy (#10485)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-23 10:53:12 +08:00
Cai Yudong
824005115a
Remove duplicated search results in proxy (#10355)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-21 19:52:28 +08:00
Cai Yudong
b099179ac0
Optimize proxy reduce search result data (#10327)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-21 10:46:36 +08:00
Cai Yudong
b40513b211
Use timerecord to calculate time span (#10287)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-20 17:56:38 +08:00
godchen
24a6fc096b
Update query node bloom filter (#10109)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-18 20:08:42 +08:00
Cai Yudong
dc0269cf4c
Optimize proxy getChannels (#9964)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-15 20:37:04 +08:00
yukun
92815f4542
Change timestamp to timestamps in internalproto.DeleteRequest (#9802)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-10-14 14:48:34 +08:00
dragondriver
8f5bf46705
Fix golint warning of plan_parser.go (#9827)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-10-13 20:30:32 +08:00
Cai Yudong
84e568ee32
Support Delete in datanode (#8505)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-11 16:31:44 +08:00
Cai Yudong
bd3a8ed3cf
Support delete in proxy (#9588)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-11 07:48:55 +08:00
Xiangyu Wang
75716e0deb
Update partition name validation in DeleteTask (#9560)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-10-09 22:50:39 +08:00
dragondriver
302ca04d6c
Describe collection by collection ID (#9471)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-10-09 16:10:56 +08:00
elfisworking
d4232f88a2
For search funtion adding a round_decimal paramter to precision control (#8574)
Signed-off-by: elfisworking <zymustb@126.com>
2021-10-08 17:39:55 +08:00
congqixia
827a18a7c1
Fix Assigner typo (#9075)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-02 18:43:56 +08:00
godchen
4bfa85eda3
Fix searchTask result nil (#8844)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-29 15:48:00 +08:00
zhenshan.cao
a662c62880
Fix golint error of segment.go in proxy package (#8629)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-28 23:06:15 +08:00
dragondriver
6065bb50c4
Fix golint warning of funcutil (#8652)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-27 23:18:02 +08:00
zhenshan.cao
b71bffe26f
Replace ChannelID with ShardName in DML Request (#8539)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-27 10:01:59 +08:00
Cai Yudong
3938d68034
Optimize proxy query execute (#8479)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-25 00:21:57 +08:00
Cai Yudong
ee3eaa2966
Rename CreateQueryExprPlan to CreateExprPlan (#8438)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-24 10:27:54 +08:00
XuanYang-cn
4ee8275b88
Fix master compile error (#8333)
Resolves: #8336

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-09-22 20:31:54 +08:00
cai.zhang
729d409a32
Add trace log for search (#8302)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-22 19:36:00 +08:00
cai.zhang
79b7dcc75a
Add trace log for insert (#8301)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-22 19:33:54 +08:00