Commit Graph

131 Commits

Author SHA1 Message Date
wei liu
d51a808851
fix: Rootcoord stuck at graceful stop progress (#36880)
issue: #34553
when rootcoord trigger graceful stop progress, it will block until all
rpc finished. for create collection request, rootcoord need to block
until datacoord finish to watch all channels, but datacoord need to call
`rootcoord.Alloc` during watch channel, and rootcoord doesn't respond to
new request anymore. which cause create collection stucks, and graceful
stop progress stucks.

This PR remove the func call `rootcoord.Alloc` to solve the logic dead
lock during graceful stop progress.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-10-17 12:15:25 +08:00
yihao.dai
4e5f1d5f75
enhance: Pre-allocate ids for import (#33958)
The import is dependent on syncTask, which in turn relies on the
allocator. This PR pre-allocate the necessary IDs for import syncTask.

issue: https://github.com/milvus-io/milvus/issues/33957

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-07 21:26:14 +08:00
jaime
9630974fbb
enhance: move rocksmq from internal to pkg module (#33881)
issue: #33956

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-06-25 21:18:15 +08:00
smellthemoon
1c1f2a1371
enhance:change some logs (#29579)
related #29588

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-01-05 16:12:48 +08:00
aoiasd
a76e3b2813
Refine delete by expression for forbid proxy dml task scheduler hang (#29340)
relate: https://github.com/milvus-io/milvus/issues/29146

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 19:52:48 +08:00
smellthemoon
79c0edb1d8
enhance:Remove msgbase unnecessary assignments (#28511)
remove some unnecessary assignments, for the reason that
commonpbutil.NewMsgBase has default value.

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2023-11-24 15:02:39 +08:00
congqixia
2f201c25e2
Remove deprecated io/ioutil usage (#27747)
`io/ioutil` package is deprecated, use `io`,`os` package replacement
also added golangci-lint rule to block future reference

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: guoguangwu <guoguangwu@magic-shield.com>
2023-10-17 20:32:09 +08:00
yah01
be980fbc38
Refine state check (#27541)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-10-11 21:01:35 +08:00
jaime
7f7c71ea7d
Decoupling client and server API in types interface (#27186)
Co-authored-by:: aoiasd <zhicheng.yue@zilliz.com>

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-09-26 09:57:25 +08:00
SimFG
26f06dd732
Format the code (#27275)
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-21 09:45:27 +08:00
yah01
b4f86ea55e
Construct all success status with merr (#27226)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-09-20 10:57:23 +08:00
congqixia
41af0a98fa
Use go-api/v2 for milvus-proto (#24770)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-09 01:28:37 +08:00
yah01
ebd0279d3f
Check error by Error() and NoError() for better report message (#24736)
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-06-08 15:36:36 +08:00
jaime
c9d0c157ec
Move some modules from internal to public package (#22572)
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-04-06 19:14:32 +08:00
XuanYang-cn
93bc805933
Enhance ID allocator in DataNode (#22905)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-03-23 19:43:57 +08:00
Enwei Jiao
697dedac7e
Use cockroachdb/errors to replace other error pkg (#22390)
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-02-26 11:31:49 +08:00
congqixia
e35b523a99
Use embed etcd for allocator ut (#20749)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-11-22 09:47:16 +08:00
smellthemoon
a7ba416b5a
Remove invalid timestamp (#20557)
Signed-off-by: lixinguo <xinguo.li@zilliz.com>

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2022-11-14 16:21:07 +08:00
smellthemoon
581e1d8c35
Fill MsgBase ALL (#19912)
Signed-off-by: lixinguo <xinguo.li@zilliz.com>

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2022-10-21 15:57:28 +08:00
SimFG
a55f739608
Separate public proto files (#19782)
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
2022-10-16 20:49:27 +08:00
Xiaofan
6826964e60
Rename some interface and files in id allocator (#19605)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-10-09 10:06:58 +08:00
zhenshan.cao
c15b880f0e
Remove redundant logs (#19412)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2022-09-26 15:40:53 +08:00
SimFG
d7f38a803d
Separate some proto files (#19218)
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
2022-09-16 16:56:49 +08:00
Jiquan Long
a5e2d6b6fb
Refactor RootCoord (#18930)
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Co-authored-by: xaxys <tpnnghd@163.com>

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Co-authored-by: xaxys <tpnnghd@163.com>
2022-09-05 13:29:11 +08:00
Xiaofan
bd7d294c6d
Refine log level in data (#15821)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-03-02 15:35:55 +08:00
Cai Yudong
1f337891e1
Rename base_param to service_param, rename global_param to component_param (#15463)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-02-08 20:57:47 +08:00
Cai Yudong
f1ea9613ae
Add EtcdConfig and move PulsarConfig/RocksdbConfig/MinioConfig into BaseParamTable (#15434)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2022-02-07 10:09:45 +08:00
congqixia
e96a851c00
[skip e2e] Improve log in allocator/id.go (#14826)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-01-05 14:31:30 +08:00
godchen
88da7cb89d
[skip e2e]Sort imports (#14818)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2022-01-05 14:21:58 +08:00
Xiaofan
69087ff8dd
Support embedded etcd (#14333)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-12-29 14:35:21 +08:00
godchen
65fec36715
[skip ci]Fix allocator comment typo (#13634)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2021-12-21 09:18:48 +08:00
godchen
cb570a5a3a
[skip e2e]Fix allocator variable typo (#13632)
Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
2021-12-17 19:44:46 +08:00
xiangzhou.guo
4e2de564ce
modify 'Root Coord' to 'RootCoord' (#13492)
Signed-off-by: xiangzhou.guo <xiangzhou.guo@zilliz.com>
2021-12-16 20:25:28 +08:00
Xiangyu Wang
12f50cb22c
[skip ci]Update OWNERS files (#11898)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-16 15:41:11 +08:00
shaoyue
f8583bb582
[skip ci] Add comment for exported struct Allocator (#11795)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-11-15 19:18:14 +08:00
zhenshan.cao
84a538f4d6
[skip ci]Fix golint error in allocator (#11045)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-11-02 21:14:40 +08:00
godchen
6d54bb20a7
[skip ci]Fix allocator typo (#10878)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-29 13:02:08 +08:00
godchen
f7d6fce513
[skip ci]Fix id typo error (#10500)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-24 10:45:10 +08:00
godchen
3b8c17abf8
[skip ci]Fix global id typo error (#10499)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-23 16:55:44 +08:00
godchen
c1c3f47cc1
[skip ci]Fix allocator close comment typo (#10369)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-21 20:47:11 +08:00
godchen
f7a7f41706
[skip ci]Fix allocator init comment typo (#10370)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-21 19:46:13 +08:00
godchen
c1ae837231
[skip ci]Fix allocator reset comment typo (#10368)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-21 19:25:11 +08:00
godchen
3610fe89c0
[skip ci ]Fix allocator comments (#10276)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-20 20:30:37 +08:00
godchen
42a85f6d9d
[skip ci]Fix allocator typo error (#10275)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-20 15:48:38 +08:00
godchen
d9010e684b
[skip ci]Fix allocator typo (#10274)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-10-20 15:42:45 +08:00
zhenshan.cao
39f043b08a
[skip ci]Fix golint error in allocator (#10134)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-18 21:30:56 +08:00
zhenshan.cao
cfc9ba1e13
[skip ci]Fix golint error in allocator (#10130)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-10-18 21:29:00 +08:00
XuanYang-cn
83272a8b2d
[skip ci]Update license for global_id.go (#9897)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-14 19:27:11 +08:00
XuanYang-cn
268b4ff85d
[skip ci]Fix license of allocator.go (#9896)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-14 19:24:49 +08:00
XuanYang-cn
81f9c0b695
[skip ci]Update license for id.go (#9895)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-14 19:22:43 +08:00