wei liu
ceca666e2a
fix: Fix privilege group hasn't been register for validate ( #35938 )
...
issue: #35471
pr: #35937
---------
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-09-05 18:09:11 +08:00
cqy123456
9de431991f
enhance: [2.4]reduce mmap-rss after warmup ( #35965 )
...
related pr: https://github.com/milvus-io/milvus/pull/35974
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2024-09-05 17:41:04 +08:00
yihao.dai
b578064869
fix: Fix DB limiter nodes are mistakenly cleaned up ( #35991 ) ( #35992 )
...
This issue only occurs for a short time right after a table is created.
To avoid this, we simply reduce the frequency of cleaning up invalid
limiter nodes.
issue: https://github.com/milvus-io/milvus/issues/35933
pr: https://github.com/milvus-io/milvus/pull/35991
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-09-05 17:31:05 +08:00
congqixia
abf3f68ae9
enhance: [2.4] Fix typo of clustering key not loaded msg ( #35948 ) ( #36000 )
...
Cherry-pick from master
pr: #35948
Related to #35415
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-05 16:59:07 +08:00
congqixia
ffa7755136
fix: [2.4] Check all values for trie.predictive_search ( #35943 ) ( #35999 )
...
Cherry-pick from master
pr: #35943
Related to #35941
For marisa trie `predictive_search` default behavior, it value iterated
is not in lexicographic order.
This PR is a brute force fix to make range operator returns correct
values.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-05 16:49:04 +08:00
congqixia
da0bc22a5f
enhance: [2.4] Add delete buffer related quota logic ( #35918 ) ( #35997 )
...
Cherry pick from master
pr: #35128 #35918
See also #35303
---------
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: aoiasd <45024769+aoiasd@users.noreply.github.com>
2024-09-05 16:43:06 +08:00
congqixia
6158ad37f9
enhance: [2.4] fix cpp-lint issue for recent change ( #35989 )
...
fix lint issue in:
internal/core/src/query/SearchOnSealed.cpp
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-05 10:57:05 +08:00
wei liu
c87711d903
fix: Fix some replicas don't participate in the query after the failure recovery ( #35850 ) ( #35925 )
...
issue: #35846
pr: #35850
querycoord will notify proxy to update shard leader cache after
delegator location changes, but during querynode's failure recovery,
some delegator may become unserviceable due to lacking of segments, and
back to serviceable after segment loaded, so we also need to notify
proxy to invalidate shard leader cache when delegator serviceable state
changes.
This PR will maintain querynode's serviceable state during heartbeat,
and notify proxy to invalidate shard leader cache if serviceable state
changes.
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-09-05 10:09:04 +08:00
cai.zhang
b7a0e08dd3
fix: [cherry-pick]Fix data race for clustering compaction writer ( #35958 )
...
issue: #35950
master pr: #35957
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2024-09-05 04:07:10 +08:00
SimFG
084b3efaa1
fix: [2.4] fill the metric type field in the LoadMetaInfo object ( #35963 )
...
- issue: #35960
- pr: #35962
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-09-04 16:21:05 +08:00
jaime
2c1fa50412
enhance: remove cooling off in rate limiter for read requests ( #35936 )
...
issue: #35934
pr: #35935
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-09-04 14:39:10 +08:00
jaime
a044a590cc
enhance: add IT for rate limit using db properties ( #35931 )
...
issue: #35929
pr: #35930
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-09-04 14:35:05 +08:00
SimFG
4fdd4d9ec3
feat: [2.4] add static view for the expr interface ( #35954 )
...
- issue: #35886
- pr: #35887
/kind improvement
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-09-04 13:17:04 +08:00
Zhen Ye
dffbc17a37
fix: SkipIndex cause segment fault ( #35908 )
...
issue: #35882
pr: #35907
Signed-off-by: chyezh <chyezh@outlook.com>
2024-09-03 18:17:04 +08:00
zhagnlu
55df25387e
fix: Fix the reference to a variable after it has been moved ( #35875 ) ( #35904 )
...
pr: #35875
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
2024-09-03 11:49:03 +08:00
congqixia
df8d1c7ca3
enhance: [2.4] Check load fields for previous loaded collection ( #35905 ) ( #35910 )
...
Cherry-pick from master
pr: #35905
Related to #35415
This PR make querycoord report error when load request tries to update
load fields list, which is currently not supported.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-03 11:25:03 +08:00
congqixia
268c60c301
fix: [2.4] Check clustering key skip load behavior ( #35865 ) ( #35899 )
...
Cherry-pick from master
pr: #35865
feature issue: #35415
See also #35861
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-09-02 16:03:04 +08:00
Zhen Ye
90147b1339
fix: memory leak in unittest and open the USE_ASAN option when build unittest ( #35857 )
...
issue: #35854
pr: #35855
Signed-off-by: chyezh <chyezh@outlook.com>
2024-09-02 16:01:04 +08:00
yihao.dai
423ecd648e
enhance: Add build-go target ( #35844 ) ( #35845 )
...
Add a build-go target to the Makefile that only compiles Go.
issue: https://github.com/milvus-io/milvus/issues/35611
pr: https://github.com/milvus-io/milvus/pull/35844
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-09-02 10:45:02 +08:00
SimFG
8b706122a8
enhance: [2.4] support to drop the role which is related the privilege list ( #35863 )
...
- issue: #35545
- pr: #35727
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-08-31 21:57:02 +08:00
sre-ci-robot
5698d1859e
[automated] Bump milvus version to v2.4.10 ( #35869 )
...
Bump milvus version to v2.4.10
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-30 17:13:01 +08:00
wei liu
da026b1e28
enhance: Add depguard rules to ban deprecated proto lib ( #35140 ) ( #35818 )
...
See also #34394 #34252
pr: #35140
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: congqixia <congqi.xia@zilliz.com>
2024-08-30 14:13:01 +08:00
yellow-shine
8cd75d627c
enhance: [ci] organize values file in the form of milvus deployment o… ( #35839 )
...
https://github.com/milvus-io/milvus/issues/35842
https://github.com/milvus-io/milvus/pull/35832
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-30 13:07:15 +08:00
yellow-shine
41582a90ad
enhance: more friendly to docker cache ( #35792 )
...
https://github.com/milvus-io/milvus/pull/35789
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-30 13:05:34 +08:00
zhenshan.cao
1916aec67a
enhance: [skip e2e] add make run-test-cpp gtest ( #35829 ) ( #35837 )
...
pr: https://github.com/milvus-io/milvus/pull/35829
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2024-08-29 21:15:02 +08:00
congqixia
cfc99e63b1
fix: [2.4] Make sure querycoord observers started once ( #35811 ) ( #35817 )
...
Cherry-pick from master
pr: #35811
Related to #35809
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-29 19:15:01 +08:00
congqixia
8d3685fadf
enhance: [2.4] Print log only when rate limit updates ( #35806 ) ( #35816 )
...
Cherry-pick from master
pr: #35806
The debug log for "RateLimiter register for rateType" is too frequent
and in e2e cases, the may print 18M times in one run.
This PR make the log be printed only when rate limit is updated.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-29 19:09:01 +08:00
yihao.dai
a1d39326b8
fix: Fix arrow go client ( #35819 ) ( #35820 )
...
issue: https://github.com/milvus-io/milvus/issues/35662
pr: https://github.com/milvus-io/milvus/pull/35819
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-08-29 17:13:00 +08:00
congqixia
fedf3a7fe1
enhance: Bump milvus & proto version to v2.4.10 ( #35798 )
...
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-29 14:55:01 +08:00
Zhen Ye
00202b0d7e
enhance: add skip 3rdparty env var ( #35748 )
...
issue: #35611
pr: #35736
- call `conan install` is too slow for developer, add option to skip it.
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-29 14:23:01 +08:00
Patrick Weizhi Xu
5da64f6d5a
feat: [2.4] support range search pagination retains order ( #35739 )
...
issue: https://github.com/milvus-io/milvus/issues/35464
pr: https://github.com/milvus-io/milvus/pull/35738
2024-08-29 14:07:01 +08:00
wei liu
50ec3dd4db
enhance: avoid the coexistence of the old coordinator and the new node/proxy ( #35760 )
...
issue: #35719
pr: #35720
In standalone mode, block the start process until the new coordinator is
active to avoid the coexistence of the old coordinator and the new
node/proxy
1. In the start/restart process, the new coordinator will become active
immediately and will not be blocked
2. In the rolling upgrade process, the new coordinator will not be
active until the old coordinator is down, and it will be blocked
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-08-29 12:33:01 +08:00
congqixia
8928c9d570
enhance: [2.4] Change frequent balancer debug log to rated one ( #35749 ) ( #35796 )
...
Cherry-pick from master
pr: #35749
"skip balance" log is too frequent in debug level. This PR changes it
into rated on.
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-29 12:31:00 +08:00
jaime
2fc111eb10
enhance: set database properties to restrict read access ( #35754 )
...
issue: #35744
pr: #35745
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-08-29 11:41:01 +08:00
yellow-shine
46a8b07bc4
enhance: show pod status and delete pvc during pipeline dear down stage ( #35785 )
...
https://github.com/milvus-io/milvus/pull/35783
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-29 09:59:00 +08:00
yellow-shine
2794ebdc45
enhance: [2.4] fix new nightly pipeline ( #35750 )
...
https://github.com/milvus-io/milvus/pull/35747
https://github.com/milvus-io/milvus/issues/35704
---------
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-28 21:43:00 +08:00
congqixia
21454163bb
fix: [2.4] Check response size before add to counter ( #35779 )
...
Cherry-pick from master
pr: #35778
Related to #35767
prometheus counter cannot add negative value
when response is not written(say timeout/network broken) panicking may
happen if not check
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-28 20:01:01 +08:00
nico
498c9470de
test: update test cases ( #35718 )
...
pr: #35640
Signed-off-by: nico <cheng.yuan@zilliz.com>
2024-08-28 19:23:01 +08:00
Zhen Ye
e25d1ef63c
fix: wrong construction in evalctx ( #35773 )
...
issue: #35771
pr: #35772
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-28 18:37:01 +08:00
congqixia
12575885d3
enhance: [2.4] Add skip load validation for create collection task ( #35761 )
...
Cherry-pick from master
pr: #35737
Related to #35415
---------
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-08-28 18:25:00 +08:00
yellow-shine
e331288b78
enhance: [skip e2e] Fix test script always skip pip install ( #35775 )
...
https://github.com/milvus-io/milvus/pull/35766
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-28 17:05:06 +08:00
foxspy
93b118946c
feat: [2.4] Encode traceID and spanID as hex string & upgrade knowhere version ( #35568 )
...
Cherry-pick and upgrade knowhere version
issue: https://github.com/zilliztech/knowhere/issues/714
pr: #34807
knowhere release notes:
https://github.com/zilliztech/knowhere/releases/tag/v2.3.8
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
Co-authored-by: Cai Yudong <yudong.cai@zilliz.com>
2024-08-28 17:03:00 +08:00
jaime
c75f556769
fix: inconsistent meta view causes rate limit invalid ( #35664 )
...
issue: #35663
pr: #35665
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-08-28 11:21:04 +08:00
yihao.dai
8e6ec58652
fix: Fix rate wasn't limited to the expected value ( #35699 ) ( #35700 )
...
Each time the rate is reset, the token bucket is fully refilled, causing
the rate wasn't limited to the expected value. This PR addresses the
issue by preventing the token reset.
issue: https://github.com/milvus-io/milvus/issues/35675 ,
https://github.com/milvus-io/milvus/issues/35702
pr: https://github.com/milvus-io/milvus/pull/35699
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-08-28 10:29:00 +08:00
jaime
eecc598786
fix: mistaken deletions may occur during GC channel checkpoints ( #35708 )
...
issue: #35706
pr: #35707
Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-08-28 10:11:05 +08:00
Zhen Ye
a4533f1b8a
enhance: optimize milvus core building ( #35660 )
...
issue: #35549,#35611,#35633
pr: #35610
- remove milvus_segcore milvus_indexbuilder..., add libmilvus_core
- core building only link once
- move opendal compilation into cmake
- fix odr
---------
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-27 18:55:00 +08:00
yihao.dai
be17cf6ff1
fix: Fix panic due to empty candidate import segments ( #35673 ) ( #35674 )
...
issue: https://github.com/milvus-io/milvus/issues/35662
pr: https://github.com/milvus-io/milvus/pull/35673
---------
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-08-27 17:34:59 +08:00
Zhen Ye
69e8d5ef46
fix: munmap deallocate too much memory ( #35726 )
...
issue: #35693
pr: #35725
Signed-off-by: chyezh <chyezh@outlook.com>
2024-08-27 17:22:59 +08:00
SimFG
fc324b4254
feat: [2.4] add the rbac msg and send them to the replicate channel ( #35562 )
...
- issue: #35391
- pr: #35392
Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-08-27 14:45:00 +08:00
yellow-shine
03627150d3
enhance new jenkinsfile for nightly and e2e ( #35715 )
...
https://github.com/milvus-io/milvus/pull/35672
Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
2024-08-27 14:23:05 +08:00
