milvus/internal/querycoordv2/meta/segment_dist_manager_test.go
wei liu efe8cecc88
enhance: refactor segment dist manager interface (#31073)
issue: #31091
This PR add `GetByFilter` interface in segment dist manager, instead of
all kind of get func

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2024-03-08 16:29:01 +08:00

198 lines
5.5 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package meta
import (
"testing"
"github.com/stretchr/testify/suite"
"github.com/milvus-io/milvus/internal/proto/datapb"
"github.com/milvus-io/milvus/internal/proto/querypb"
"github.com/milvus-io/milvus/pkg/util/typeutil"
)
type SegmentDistManagerSuite struct {
suite.Suite
dist *SegmentDistManager
collection int64
partitions []int64
nodes []int64
segments map[int64]*Segment
}
func (suite *SegmentDistManagerSuite) SetupSuite() {
const (
shardNum = 2
)
// Replica 0: 0, 2
// Replica 1: 1
suite.collection = 10
suite.partitions = []int64{1, 2}
suite.nodes = []int64{0, 1, 2}
suite.segments = map[int64]*Segment{
1: SegmentFromInfo(&datapb.SegmentInfo{
ID: 1,
CollectionID: suite.collection,
PartitionID: suite.partitions[0],
InsertChannel: "dmc0",
}),
2: SegmentFromInfo(&datapb.SegmentInfo{
ID: 2,
CollectionID: suite.collection,
PartitionID: suite.partitions[0],
InsertChannel: "dmc1",
}),
3: SegmentFromInfo(&datapb.SegmentInfo{
ID: 3,
CollectionID: suite.collection,
PartitionID: suite.partitions[1],
InsertChannel: "dmc0",
}),
4: SegmentFromInfo(&datapb.SegmentInfo{
ID: 4,
CollectionID: suite.collection,
PartitionID: suite.partitions[1],
InsertChannel: "dmc1",
}),
}
}
func (suite *SegmentDistManagerSuite) SetupTest() {
suite.dist = NewSegmentDistManager()
// Distribution:
// node 0 contains channel segment 1, 2
// node 1 contains channel segment 1, 2, 3, 4
// node 2 contains channel segment 3, 4
suite.dist.Update(suite.nodes[0], suite.segments[1].Clone(), suite.segments[2].Clone())
suite.dist.Update(suite.nodes[1],
suite.segments[1].Clone(),
suite.segments[2].Clone(),
suite.segments[3].Clone(),
suite.segments[4].Clone())
suite.dist.Update(suite.nodes[2], suite.segments[3].Clone(), suite.segments[4].Clone())
}
func (suite *SegmentDistManagerSuite) TestGetBy() {
dist := suite.dist
// Test GetByNode
for _, node := range suite.nodes {
segments := dist.GetByFilter(WithNodeID(node))
suite.AssertNode(segments, node)
}
// Test GetByShard
for _, shard := range []string{"dmc0", "dmc1"} {
segments := dist.GetByFilter(WithChannel(shard))
suite.AssertShard(segments, shard)
}
// Test GetByCollection
segments := dist.GetByFilter(WithCollectionID(suite.collection))
suite.Len(segments, 8)
suite.AssertCollection(segments, suite.collection)
segments = dist.GetByFilter(WithCollectionID(-1))
suite.Len(segments, 0)
// Test GetByNodeAndCollection
// 1. Valid node and valid collection
for _, node := range suite.nodes {
segments := dist.GetByFilter(WithCollectionID(suite.collection), WithNodeID(node))
suite.AssertNode(segments, node)
suite.AssertCollection(segments, suite.collection)
}
// 2. Valid node and invalid collection
segments = dist.GetByFilter(WithCollectionID(-1), WithNodeID(suite.nodes[1]))
suite.Len(segments, 0)
// 3. Invalid node and valid collection
segments = dist.GetByFilter(WithCollectionID(suite.collection), WithNodeID(-1))
suite.Len(segments, 0)
// Test GetBy With Wrong Replica
replica := &Replica{
Replica: &querypb.Replica{
ID: 1,
CollectionID: suite.collection + 1,
Nodes: []int64{suite.nodes[0]},
},
nodes: typeutil.NewUniqueSet(suite.nodes[0]),
}
segments = dist.GetByFilter(WithReplica(replica))
suite.Len(segments, 0)
// Test GetBy With Correct Replica
replica = &Replica{
Replica: &querypb.Replica{
ID: 1,
CollectionID: suite.collection,
Nodes: []int64{suite.nodes[0]},
},
nodes: typeutil.NewUniqueSet(suite.nodes[0]),
}
segments = dist.GetByFilter(WithReplica(replica))
suite.Len(segments, 2)
}
func (suite *SegmentDistManagerSuite) AssertIDs(segments []*Segment, ids ...int64) bool {
for _, segment := range segments {
hasSegment := false
for _, id := range ids {
if segment.ID == id {
hasSegment = true
break
}
}
if !suite.True(hasSegment, "segment %v not in the given expected list %+v", segment.GetID(), ids) {
return false
}
}
return true
}
func (suite *SegmentDistManagerSuite) AssertNode(segments []*Segment, node int64) bool {
for _, segment := range segments {
if !suite.Equal(node, segment.Node) {
return false
}
}
return true
}
func (suite *SegmentDistManagerSuite) AssertCollection(segments []*Segment, collection int64) bool {
for _, segment := range segments {
if !suite.Equal(collection, segment.GetCollectionID()) {
return false
}
}
return true
}
func (suite *SegmentDistManagerSuite) AssertShard(segments []*Segment, shard string) bool {
for _, segment := range segments {
if !suite.Equal(shard, segment.GetInsertChannel()) {
return false
}
}
return true
}
func TestSegmentDistManager(t *testing.T) {
suite.Run(t, new(SegmentDistManagerSuite))
}