mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-11-30 02:48:45 +08:00
635 lines
21 KiB
Go
635 lines
21 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package observers
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/suite"
|
|
"go.uber.org/atomic"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus/internal/kv"
|
|
etcdkv "github.com/milvus-io/milvus/internal/kv/etcd"
|
|
"github.com/milvus-io/milvus/internal/metastore/kv/querycoord"
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
"github.com/milvus-io/milvus/internal/proto/querypb"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/meta"
|
|
. "github.com/milvus-io/milvus/internal/querycoordv2/params"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/session"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/utils"
|
|
"github.com/milvus-io/milvus/pkg/util/etcd"
|
|
"github.com/milvus-io/milvus/pkg/util/paramtable"
|
|
)
|
|
|
|
type LeaderObserverTestSuite struct {
|
|
suite.Suite
|
|
observer *LeaderObserver
|
|
kv kv.MetaKv
|
|
mockCluster *session.MockCluster
|
|
|
|
meta *meta.Meta
|
|
broker *meta.MockBroker
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) SetupSuite() {
|
|
paramtable.Init()
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) SetupTest() {
|
|
var err error
|
|
config := GenerateEtcdConfig()
|
|
cli, err := etcd.GetEtcdClient(
|
|
config.UseEmbedEtcd.GetAsBool(),
|
|
config.EtcdUseSSL.GetAsBool(),
|
|
config.Endpoints.GetAsStrings(),
|
|
config.EtcdTLSCert.GetValue(),
|
|
config.EtcdTLSKey.GetValue(),
|
|
config.EtcdTLSCACert.GetValue(),
|
|
config.EtcdTLSMinVersion.GetValue())
|
|
suite.Require().NoError(err)
|
|
suite.kv = etcdkv.NewEtcdKV(cli, config.MetaRootPath.GetValue())
|
|
|
|
// meta
|
|
store := querycoord.NewCatalog(suite.kv)
|
|
idAllocator := RandomIncrementIDAllocator()
|
|
suite.meta = meta.NewMeta(idAllocator, store, session.NewNodeManager())
|
|
suite.broker = meta.NewMockBroker(suite.T())
|
|
|
|
suite.mockCluster = session.NewMockCluster(suite.T())
|
|
// suite.mockCluster.EXPECT().SyncDistribution(mock.Anything, mock.Anything, mock.Anything).Return(&commonpb.Status{
|
|
// ErrorCode: commonpb.ErrorCode_Success,
|
|
// }, nil).Maybe()
|
|
distManager := meta.NewDistributionManager()
|
|
targetManager := meta.NewTargetManager(suite.broker, suite.meta)
|
|
suite.observer = NewLeaderObserver(distManager, suite.meta, targetManager, suite.broker, suite.mockCluster)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TearDownTest() {
|
|
suite.observer.Stop()
|
|
suite.kv.Close()
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestSyncLoadedSegments() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.CollectionManager.PutPartition(utils.CreateTestPartition(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
segments := []*datapb.SegmentInfo{
|
|
{
|
|
ID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
info := &datapb.SegmentInfo{
|
|
ID: 1,
|
|
CollectionID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
}
|
|
resp := &datapb.GetSegmentInfoResponse{
|
|
Infos: []*datapb.SegmentInfo{info},
|
|
}
|
|
schema := utils.CreateTestSchema()
|
|
suite.broker.EXPECT().GetCollectionSchema(mock.Anything, int64(1)).Return(schema, nil)
|
|
suite.broker.EXPECT().GetSegmentInfo(mock.Anything, int64(1)).Return(
|
|
&datapb.GetSegmentInfoResponse{Infos: []*datapb.SegmentInfo{info}}, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfoV2(mock.Anything, int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTarget(int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
observer.dist.SegmentDistManager.Update(1, utils.CreateTestSegment(1, 1, 1, 2, 1, "test-insert-channel"))
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
view := utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{}, map[int64]*meta.Segment{})
|
|
view.TargetVersion = observer.target.GetCollectionTargetVersion(1, meta.CurrentTarget)
|
|
observer.dist.LeaderViewManager.Update(2, view)
|
|
loadInfo := utils.PackSegmentLoadInfo(resp, nil)
|
|
|
|
expectReqeustFunc := func(version int64) *querypb.SyncDistributionRequest {
|
|
return &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
ReplicaID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Set,
|
|
PartitionID: 1,
|
|
SegmentID: 1,
|
|
NodeID: 1,
|
|
Version: 1,
|
|
Info: loadInfo,
|
|
},
|
|
},
|
|
Schema: schema,
|
|
LoadMeta: &querypb.LoadMetaInfo{
|
|
CollectionID: 1,
|
|
PartitionIDs: []int64{1},
|
|
},
|
|
Version: version,
|
|
}
|
|
}
|
|
|
|
called := atomic.NewBool(false)
|
|
suite.mockCluster.EXPECT().SyncDistribution(mock.Anything, int64(2),
|
|
mock.AnythingOfType("*querypb.SyncDistributionRequest")).
|
|
Run(func(ctx context.Context, nodeID int64, req *querypb.SyncDistributionRequest) {
|
|
assert.ElementsMatch(suite.T(), []*querypb.SyncDistributionRequest{req},
|
|
[]*querypb.SyncDistributionRequest{expectReqeustFunc(req.GetVersion())})
|
|
called.Store(true)
|
|
}).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start()
|
|
|
|
suite.Eventually(
|
|
func() bool {
|
|
return called.Load()
|
|
},
|
|
10*time.Second,
|
|
500*time.Millisecond,
|
|
)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestIgnoreSyncLoadedSegments() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.CollectionManager.PutPartition(utils.CreateTestPartition(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
segments := []*datapb.SegmentInfo{
|
|
{
|
|
ID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
schema := utils.CreateTestSchema()
|
|
suite.broker.EXPECT().GetCollectionSchema(mock.Anything, int64(1)).Return(schema, nil)
|
|
info := &datapb.SegmentInfo{
|
|
ID: 1,
|
|
CollectionID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
}
|
|
resp := &datapb.GetSegmentInfoResponse{
|
|
Infos: []*datapb.SegmentInfo{info},
|
|
}
|
|
suite.broker.EXPECT().GetSegmentInfo(mock.Anything, int64(1)).Return(
|
|
&datapb.GetSegmentInfoResponse{Infos: []*datapb.SegmentInfo{info}}, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfoV2(mock.Anything, int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTarget(int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
observer.target.UpdateCollectionNextTarget(int64(1))
|
|
observer.dist.SegmentDistManager.Update(1, utils.CreateTestSegment(1, 1, 1, 2, 1, "test-insert-channel"),
|
|
utils.CreateTestSegment(1, 1, 2, 2, 1, "test-insert-channel"))
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
view := utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{}, map[int64]*meta.Segment{})
|
|
view.TargetVersion = observer.target.GetCollectionTargetVersion(1, meta.CurrentTarget)
|
|
observer.dist.LeaderViewManager.Update(2, view)
|
|
loadInfo := utils.PackSegmentLoadInfo(resp, nil)
|
|
|
|
expectReqeustFunc := func(version int64) *querypb.SyncDistributionRequest {
|
|
return &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
ReplicaID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Set,
|
|
PartitionID: 1,
|
|
SegmentID: 1,
|
|
NodeID: 1,
|
|
Version: 1,
|
|
Info: loadInfo,
|
|
},
|
|
},
|
|
Schema: schema,
|
|
LoadMeta: &querypb.LoadMetaInfo{
|
|
CollectionID: 1,
|
|
PartitionIDs: []int64{1},
|
|
},
|
|
Version: version,
|
|
}
|
|
}
|
|
called := atomic.NewBool(false)
|
|
suite.mockCluster.EXPECT().SyncDistribution(mock.Anything, int64(2), mock.AnythingOfType("*querypb.SyncDistributionRequest")).
|
|
Run(func(ctx context.Context, nodeID int64, req *querypb.SyncDistributionRequest) {
|
|
assert.ElementsMatch(suite.T(), []*querypb.SyncDistributionRequest{req},
|
|
[]*querypb.SyncDistributionRequest{expectReqeustFunc(req.GetVersion())})
|
|
called.Store(true)
|
|
}).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start()
|
|
|
|
suite.Eventually(
|
|
func() bool {
|
|
return called.Load()
|
|
},
|
|
10*time.Second,
|
|
500*time.Millisecond,
|
|
)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestIgnoreBalancedSegment() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.CollectionManager.PutPartition(utils.CreateTestPartition(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
segments := []*datapb.SegmentInfo{
|
|
{
|
|
ID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
|
|
suite.broker.EXPECT().GetRecoveryInfoV2(mock.Anything, int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTarget(int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
observer.dist.SegmentDistManager.Update(1, utils.CreateTestSegment(1, 1, 1, 1, 1, "test-insert-channel"))
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
|
|
// The leader view saw the segment on new node,
|
|
// but another nodes not yet
|
|
leaderView := utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{}, map[int64]*meta.Segment{})
|
|
leaderView.Segments[1] = &querypb.SegmentDist{
|
|
NodeID: 2,
|
|
Version: 2,
|
|
}
|
|
leaderView.TargetVersion = observer.target.GetCollectionTargetVersion(1, meta.CurrentTarget)
|
|
observer.dist.LeaderViewManager.Update(2, leaderView)
|
|
observer.Start()
|
|
|
|
// Nothing should happen
|
|
time.Sleep(2 * time.Second)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestSyncLoadedSegmentsWithReplicas() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 2))
|
|
observer.meta.CollectionManager.PutPartition(utils.CreateTestPartition(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(2, 1, []int64{3, 4}))
|
|
segments := []*datapb.SegmentInfo{
|
|
{
|
|
ID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
info := &datapb.SegmentInfo{
|
|
ID: 1,
|
|
CollectionID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
}
|
|
resp := &datapb.GetSegmentInfoResponse{
|
|
Infos: []*datapb.SegmentInfo{info},
|
|
}
|
|
schema := utils.CreateTestSchema()
|
|
suite.broker.EXPECT().GetSegmentInfo(mock.Anything, int64(1)).Return(
|
|
&datapb.GetSegmentInfoResponse{Infos: []*datapb.SegmentInfo{info}}, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfoV2(mock.Anything, int64(1)).Return(
|
|
channels, segments, nil)
|
|
suite.broker.EXPECT().GetCollectionSchema(mock.Anything, int64(1)).Return(schema, nil)
|
|
observer.target.UpdateCollectionNextTarget(int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
observer.dist.SegmentDistManager.Update(1, utils.CreateTestSegment(1, 1, 1, 1, 1, "test-insert-channel"))
|
|
observer.dist.SegmentDistManager.Update(4, utils.CreateTestSegment(1, 1, 1, 4, 2, "test-insert-channel"))
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
view := utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{}, map[int64]*meta.Segment{})
|
|
view.TargetVersion = observer.target.GetCollectionTargetVersion(1, meta.CurrentTarget)
|
|
observer.dist.LeaderViewManager.Update(2, view)
|
|
view2 := utils.CreateTestLeaderView(4, 1, "test-insert-channel", map[int64]int64{1: 4}, map[int64]*meta.Segment{})
|
|
view.TargetVersion = observer.target.GetCollectionTargetVersion(1, meta.CurrentTarget)
|
|
observer.dist.LeaderViewManager.Update(4, view2)
|
|
loadInfo := utils.PackSegmentLoadInfo(resp, nil)
|
|
|
|
expectReqeustFunc := func(version int64) *querypb.SyncDistributionRequest {
|
|
return &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
ReplicaID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Set,
|
|
PartitionID: 1,
|
|
SegmentID: 1,
|
|
NodeID: 1,
|
|
Version: 1,
|
|
Info: loadInfo,
|
|
},
|
|
},
|
|
Schema: schema,
|
|
LoadMeta: &querypb.LoadMetaInfo{
|
|
CollectionID: 1,
|
|
PartitionIDs: []int64{1},
|
|
},
|
|
Version: version,
|
|
}
|
|
}
|
|
called := atomic.NewBool(false)
|
|
suite.mockCluster.EXPECT().SyncDistribution(mock.Anything, int64(2),
|
|
mock.AnythingOfType("*querypb.SyncDistributionRequest")).
|
|
Run(func(ctx context.Context, nodeID int64, req *querypb.SyncDistributionRequest) {
|
|
assert.ElementsMatch(suite.T(), []*querypb.SyncDistributionRequest{req},
|
|
[]*querypb.SyncDistributionRequest{expectReqeustFunc(req.GetVersion())})
|
|
called.Store(true)
|
|
}).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start()
|
|
|
|
suite.Eventually(
|
|
func() bool {
|
|
return called.Load()
|
|
},
|
|
10*time.Second,
|
|
500*time.Millisecond,
|
|
)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestSyncRemovedSegments() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.CollectionManager.PutPartition(utils.CreateTestPartition(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
|
|
schema := utils.CreateTestSchema()
|
|
suite.broker.EXPECT().GetCollectionSchema(mock.Anything, int64(1)).Return(schema, nil)
|
|
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
|
|
suite.broker.EXPECT().GetRecoveryInfoV2(mock.Anything, int64(1)).Return(
|
|
channels, nil, nil)
|
|
observer.target.UpdateCollectionNextTarget(int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
view := utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{3: 2}, map[int64]*meta.Segment{})
|
|
view.TargetVersion = observer.target.GetCollectionTargetVersion(1, meta.CurrentTarget)
|
|
observer.dist.LeaderViewManager.Update(2, view)
|
|
|
|
expectReqeustFunc := func(version int64) *querypb.SyncDistributionRequest {
|
|
return &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
ReplicaID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Remove,
|
|
SegmentID: 3,
|
|
NodeID: 2,
|
|
},
|
|
},
|
|
Schema: schema,
|
|
LoadMeta: &querypb.LoadMetaInfo{
|
|
CollectionID: 1,
|
|
PartitionIDs: []int64{1},
|
|
},
|
|
Version: version,
|
|
}
|
|
}
|
|
ch := make(chan struct{})
|
|
suite.mockCluster.EXPECT().SyncDistribution(mock.Anything, int64(2),
|
|
mock.AnythingOfType("*querypb.SyncDistributionRequest")).
|
|
Run(func(ctx context.Context, nodeID int64, req *querypb.SyncDistributionRequest) {
|
|
assert.ElementsMatch(suite.T(), []*querypb.SyncDistributionRequest{req},
|
|
[]*querypb.SyncDistributionRequest{expectReqeustFunc(req.GetVersion())})
|
|
close(ch)
|
|
}).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start()
|
|
|
|
select {
|
|
case <-ch:
|
|
case <-time.After(2 * time.Second):
|
|
}
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestIgnoreSyncRemovedSegments() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.CollectionManager.PutPartition(utils.CreateTestPartition(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
|
|
segments := []*datapb.SegmentInfo{
|
|
{
|
|
ID: 2,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
schema := utils.CreateTestSchema()
|
|
suite.broker.EXPECT().GetCollectionSchema(mock.Anything, int64(1)).Return(schema, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfoV2(mock.Anything, int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTarget(int64(1))
|
|
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
observer.dist.LeaderViewManager.Update(2, utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{3: 2, 2: 2}, map[int64]*meta.Segment{}))
|
|
|
|
expectReqeustFunc := func(version int64) *querypb.SyncDistributionRequest {
|
|
return &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
ReplicaID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Remove,
|
|
SegmentID: 3,
|
|
NodeID: 2,
|
|
},
|
|
},
|
|
Schema: schema,
|
|
LoadMeta: &querypb.LoadMetaInfo{
|
|
CollectionID: 1,
|
|
PartitionIDs: []int64{1},
|
|
},
|
|
Version: version,
|
|
}
|
|
}
|
|
called := atomic.NewBool(false)
|
|
suite.mockCluster.EXPECT().SyncDistribution(mock.Anything, int64(2), mock.AnythingOfType("*querypb.SyncDistributionRequest")).
|
|
Run(func(ctx context.Context, nodeID int64, req *querypb.SyncDistributionRequest) {
|
|
assert.ElementsMatch(suite.T(), []*querypb.SyncDistributionRequest{req},
|
|
[]*querypb.SyncDistributionRequest{expectReqeustFunc(req.GetVersion())})
|
|
called.Store(true)
|
|
}).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start()
|
|
suite.Eventually(func() bool {
|
|
return called.Load()
|
|
},
|
|
10*time.Second,
|
|
500*time.Millisecond,
|
|
)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestSyncTargetVersion() {
|
|
collectionID := int64(1001)
|
|
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(collectionID, 1))
|
|
observer.meta.CollectionManager.PutPartition(utils.CreateTestPartition(collectionID, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, collectionID, []int64{1, 2}))
|
|
|
|
nextTargetChannels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: collectionID,
|
|
ChannelName: "channel-1",
|
|
UnflushedSegmentIds: []int64{22, 33},
|
|
},
|
|
{
|
|
CollectionID: collectionID,
|
|
ChannelName: "channel-2",
|
|
UnflushedSegmentIds: []int64{44},
|
|
},
|
|
}
|
|
|
|
nextTargetSegments := []*datapb.SegmentInfo{
|
|
{
|
|
ID: 11,
|
|
PartitionID: 1,
|
|
InsertChannel: "channel-1",
|
|
},
|
|
{
|
|
ID: 12,
|
|
PartitionID: 1,
|
|
InsertChannel: "channel-2",
|
|
},
|
|
}
|
|
|
|
suite.broker.EXPECT().GetRecoveryInfoV2(mock.Anything, collectionID).Return(nextTargetChannels, nextTargetSegments, nil)
|
|
suite.observer.target.UpdateCollectionNextTarget(collectionID)
|
|
suite.observer.target.UpdateCollectionCurrentTarget(collectionID)
|
|
TargetVersion := suite.observer.target.GetCollectionTargetVersion(collectionID, meta.CurrentTarget)
|
|
|
|
view := utils.CreateTestLeaderView(1, collectionID, "channel-1", nil, nil)
|
|
view.TargetVersion = TargetVersion
|
|
action := observer.checkNeedUpdateTargetVersion(context.Background(), view)
|
|
suite.Nil(action)
|
|
|
|
view.TargetVersion = TargetVersion - 1
|
|
action = observer.checkNeedUpdateTargetVersion(context.Background(), view)
|
|
suite.NotNil(action)
|
|
suite.Equal(querypb.SyncType_UpdateVersion, action.Type)
|
|
suite.Len(action.GrowingInTarget, 2)
|
|
suite.Len(action.SealedInTarget, 1)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestCheckTargetVersion() {
|
|
collectionID := int64(1001)
|
|
observer := suite.observer
|
|
|
|
suite.Run("check_channel_blocked", func() {
|
|
oldCh := observer.manualCheck
|
|
defer func() {
|
|
observer.manualCheck = oldCh
|
|
}()
|
|
|
|
// zero-length channel
|
|
observer.manualCheck = make(chan checkRequest)
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
// cancel context, make test return fast
|
|
cancel()
|
|
|
|
result := observer.CheckTargetVersion(ctx, collectionID)
|
|
suite.False(result)
|
|
})
|
|
|
|
suite.Run("check_return_ctx_timeout", func() {
|
|
oldCh := observer.manualCheck
|
|
defer func() {
|
|
observer.manualCheck = oldCh
|
|
}()
|
|
|
|
// make channel length = 1, task received
|
|
observer.manualCheck = make(chan checkRequest, 1)
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*200)
|
|
defer cancel()
|
|
|
|
result := observer.CheckTargetVersion(ctx, collectionID)
|
|
suite.False(result)
|
|
})
|
|
}
|
|
|
|
func TestLeaderObserverSuite(t *testing.T) {
|
|
suite.Run(t, new(LeaderObserverTestSuite))
|
|
}
|