mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-02 03:48:37 +08:00
6387403639
See also #30538 Previously the `SelectSegments` changed to clone all return value preventing possible update to returned info. Since meta is implemented following COW rules, this shall not happen and any update on segment shall have copy before it. This PR: - Remove clone for read-only Get segment info - Add Segment Operator abstraction for changing segment - Implemnt COW for updating MaxRowNum --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
50 lines
1.4 KiB
Go
50 lines
1.4 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package datacoord
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
)
|
|
|
|
type TestSegmentOperatorSuite struct {
|
|
suite.Suite
|
|
}
|
|
|
|
func (s *TestSegmentOperatorSuite) TestSetMaxRowCount() {
|
|
segment := &SegmentInfo{
|
|
SegmentInfo: &datapb.SegmentInfo{
|
|
MaxRowNum: 300,
|
|
},
|
|
}
|
|
|
|
ops := SetMaxRowCount(20000)
|
|
updated := ops(segment)
|
|
s.Require().True(updated)
|
|
s.EqualValues(20000, segment.GetMaxRowNum())
|
|
|
|
updated = ops(segment)
|
|
s.False(updated)
|
|
}
|
|
|
|
func TestSegmentOperators(t *testing.T) {
|
|
suite.Run(t, new(TestSegmentOperatorSuite))
|
|
}
|